Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add vertical scenario #27259

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Conversation

ling1726
Copy link
Member

@ling1726 ling1726 commented Mar 20, 2023

See title

vertical overflow

Related to #27249

@ling1726 ling1726 marked this pull request as ready for review March 20, 2023 08:38
@ling1726 ling1726 requested a review from a team as a code owner March 20, 2023 08:38
@github-actions github-actions bot added this to the March Project Cycle Q1 2023 milestone Mar 20, 2023
@size-auditor
Copy link

size-auditor bot commented Mar 20, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: c0dd0a6ee291bd38efc4d4a37de6bdfef3bf10da (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 20, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dc7a34a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 20, 2023

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
67.365 kB
18.199 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
206.835 kB
57.287 kB
react-components
react-components: FluentProvider & webLightTheme
38.202 kB
12.13 kB
react-overflow
hooks only
11.214 kB
4.271 kB
react-portal-compat
PortalCompatProvider
6.466 kB
2.179 kB
🤖 This report was generated against c0dd0a6ee291bd38efc4d4a37de6bdfef3bf10da

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 20, 2023

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 891 884 5000
Button mount 569 560 5000
Field mount 1645 1579 5000
FluentProvider mount 1122 1144 5000
FluentProviderWithTheme mount 300 300 10
FluentProviderWithTheme virtual-rerender 239 235 10
FluentProviderWithTheme virtual-rerender-with-unmount 296 291 10
InfoButton mount 207 210 5000
MakeStyles mount 1319 1324 50000
Persona mount 2265 2183 5000
SpinButton mount 1997 1964 5000

…ical.stories.tsx

Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
@ling1726 ling1726 enabled auto-merge (squash) March 20, 2023 09:03
@ling1726 ling1726 merged commit 198bc42 into microsoft:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants