Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Release Field component as stable #27493

Merged
merged 10 commits into from
Apr 13, 2023
Merged

Conversation

behowell
Copy link
Contributor

@behowell behowell commented Apr 7, 2023

New Behavior

Release Field as stable:

  • Export Field and related symbols from @fluentui/react-components instead of @fluentui/react-components/unstable.
  • Update references in all stories that use Field, to the new import path.
  • Update Field's version to remove -beta tag.
  • Update README.md and FieldDescription.md to remove references to the component being unstable.

Related Issue(s)

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 7, 2023

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 668 711 5000
Button mount 399 389 5000
Field mount 1225 1204 5000
FluentProvider mount 771 768 5000
FluentProviderWithTheme mount 111 107 10
FluentProviderWithTheme virtual-rerender 93 90 10
FluentProviderWithTheme virtual-rerender-with-unmount 108 99 10
InfoButton mount 13 18 5000
MakeStyles mount 1217 1177 50000
Persona mount 1873 1853 5000
SpinButton mount 1462 1456 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 7, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9ec097a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 7, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b120cc8a76bea610aeeded3eade7c78c0e9ddc0b (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 7, 2023

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-checkbox
Checkbox
37.097 kB
11.277 kB
react-combobox
Combobox (including child components)
89.865 kB
28.545 kB
react-combobox
Dropdown (including child components)
88.549 kB
28.267 kB
react-components
react-components: Button, FluentProvider & webLightTheme
68.075 kB
18.416 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
207.606 kB
57.581 kB
react-components
react-components: FluentProvider & webLightTheme
38.778 kB
12.337 kB
react-datepicker-compat
DatePicker Compat
251.351 kB
67.358 kB
react-field
Field
21.571 kB
7.437 kB
react-infobutton
InfoButton
130.671 kB
39.464 kB
react-infobutton
InfoLabel
133.97 kB
40.505 kB
react-input
Input
26.784 kB
8.141 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.185 kB
react-progress
ProgressBar
16.397 kB
5.846 kB
react-radio
Radio
29.903 kB
9.108 kB
react-radio
RadioGroup
13.897 kB
5.128 kB
react-select
Select
27.992 kB
9.215 kB
react-slider
Slider
36.922 kB
11.506 kB
react-spinbutton
SpinButton
36.693 kB
10.784 kB
react-switch
Switch
32.515 kB
9.726 kB
react-table
DataGrid
150.938 kB
41.062 kB
react-table
Table (Primitives only)
47.196 kB
12.732 kB
react-table
Table as DataGrid
133.532 kB
33.674 kB
react-table
Table (Selection only)
81.366 kB
19.658 kB
react-table
Table (Sort only)
80.696 kB
19.466 kB
react-textarea
Textarea
30.185 kB
9.502 kB
🤖 This report was generated against b120cc8a76bea610aeeded3eade7c78c0e9ddc0b

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 7, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@behowell behowell marked this pull request as ready for review April 12, 2023 17:56
@behowell behowell merged commit 36f98c3 into microsoft:master Apr 13, 2023
23 checks passed
@behowell behowell deleted the field/stable branch April 13, 2023 19:35
@behowell behowell mentioned this pull request Apr 13, 2023
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Release Field to stable
6 participants