Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont ignore lib, lib-commonjs and lib-amd files #27736

Merged
merged 2 commits into from
May 2, 2023
Merged

fix: dont ignore lib, lib-commonjs and lib-amd files #27736

merged 2 commits into from
May 2, 2023

Conversation

TristanWatanabe
Copy link
Member

Changes:

  • with the repo upgrade to node 16, it seems like certain packages like lib and lib-amd are not being published despite being built. This PR explicitly adds to the .npmignore files of @fluentui/react and all packages within its dependency graph so that the lib and lib-amd folders are always included.

Related Issue(s)

@TristanWatanabe TristanWatanabe self-assigned this May 1, 2023
@TristanWatanabe TristanWatanabe added this to the Fluent UI v9 milestone May 1, 2023
@TristanWatanabe TristanWatanabe marked this pull request as ready for review May 1, 2023 23:46
@TristanWatanabe TristanWatanabe requested review from a team, khmakoto and dzearing as code owners May 1, 2023 23:46
@TristanWatanabe TristanWatanabe changed the title fix: explicitly dont ignore lib, lib-commonjs and lib-amd files fix: dont ignore lib, lib-commonjs and lib-amd files May 1, 2023
@size-auditor
Copy link

size-auditor bot commented May 1, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5b50b810a0a86e28b91e8e441593d3e2b3f13ea5 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 1, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cdcb2c8:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
CarouselMinimalPerf.default 383 352 1.09:1
PortalMinimalPerf.default 127 117 1.09:1
ButtonSlotsPerf.default 433 407 1.06:1
ChatWithPopoverPerf.default 261 249 1.05:1
GridMinimalPerf.default 257 244 1.05:1
TableMinimalPerf.default 306 292 1.05:1
AvatarMinimalPerf.default 140 135 1.04:1
CheckboxMinimalPerf.default 1632 1564 1.04:1
DialogMinimalPerf.default 597 576 1.04:1
FormMinimalPerf.default 285 274 1.04:1
ListMinimalPerf.default 393 377 1.04:1
SegmentMinimalPerf.default 266 256 1.04:1
TooltipMinimalPerf.default 1660 1601 1.04:1
AnimationMinimalPerf.default 377 367 1.03:1
DropdownMinimalPerf.default 1880 1832 1.03:1
InputMinimalPerf.default 742 718 1.03:1
LabelMinimalPerf.default 286 277 1.03:1
MenuMinimalPerf.default 633 616 1.03:1
RefMinimalPerf.default 144 140 1.03:1
CustomToolbarPrototype.default 1987 1934 1.03:1
VideoMinimalPerf.default 544 527 1.03:1
AttachmentMinimalPerf.default 100 98 1.02:1
BoxMinimalPerf.default 257 252 1.02:1
DatepickerMinimalPerf.default 5279 5169 1.02:1
DividerMinimalPerf.default 260 255 1.02:1
EmbedMinimalPerf.default 2445 2403 1.02:1
RadioGroupMinimalPerf.default 338 330 1.02:1
ToolbarMinimalPerf.default 661 650 1.02:1
AlertMinimalPerf.default 199 198 1.01:1
ButtonMinimalPerf.default 106 105 1.01:1
HeaderMinimalPerf.default 270 267 1.01:1
MenuButtonMinimalPerf.default 1282 1268 1.01:1
SkeletonMinimalPerf.default 266 263 1.01:1
SplitButtonMinimalPerf.default 3032 2996 1.01:1
TableManyItemsPerf.default 1440 1428 1.01:1
AttachmentSlotsPerf.default 824 827 1:1
ChatDuplicateMessagesPerf.default 206 205 1:1
FlexMinimalPerf.default 205 204 1:1
HeaderSlotsPerf.default 572 574 1:1
LayoutMinimalPerf.default 268 267 1:1
ListNestedPerf.default 407 408 1:1
ListWith60ListItems.default 482 483 1:1
ProviderMergeThemesPerf.default 982 986 1:1
ProviderMinimalPerf.default 279 278 1:1
SliderMinimalPerf.default 904 907 1:1
TextMinimalPerf.default 256 255 1:1
CardMinimalPerf.default 376 381 0.99:1
PopupMinimalPerf.default 458 462 0.99:1
ReactionMinimalPerf.default 272 275 0.99:1
StatusMinimalPerf.default 502 509 0.99:1
DropdownManyItemsPerf.default 499 510 0.98:1
ImageMinimalPerf.default 279 286 0.98:1
LoaderMinimalPerf.default 237 241 0.98:1
IconMinimalPerf.default 461 472 0.98:1
ItemLayoutMinimalPerf.default 889 914 0.97:1
ListCommonPerf.default 509 527 0.97:1
TreeWith60ListItems.default 112 115 0.97:1
ButtonOverridesMissPerf.default 846 881 0.96:1
TreeMinimalPerf.default 590 613 0.96:1
RosterPerf.default 1814 1902 0.95:1
TextAreaMinimalPerf.default 361 380 0.95:1
AccordionMinimalPerf.default 102 108 0.94:1
ChatMinimalPerf.default 523 587 0.89:1

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 5b50b810a0a86e28b91e8e441593d3e2b3f13ea5

@fabricteam
Copy link
Collaborator

🕵 FluentUI-v0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 823 817 5000
Breadcrumb mount 2237 2252 1000
Checkbox mount 2167 2174 5000
CheckboxBase mount 1911 1901 5000
ChoiceGroup mount 3782 3754 5000
ComboBox mount 898 901 1000
CommandBar mount 8098 8119 1000
ContextualMenu mount 17871 17269 1000
DefaultButton mount 989 993 5000
DetailsRow mount 2939 2915 5000
DetailsRowFast mount 2961 2915 5000
DetailsRowNoStyles mount 2679 2700 5000
Dialog mount 3439 3446 1000
DocumentCardTitle mount 315 316 1000
Dropdown mount 2564 2567 5000
FocusTrapZone mount 1506 1539 5000
FocusZone mount 1462 1470 5000
GroupedList mount 51046 59311 2
GroupedList virtual-rerender 24579 24533 2
GroupedList virtual-rerender-with-unmount 76146 75898 2
GroupedListV2 mount 323 317 2
GroupedListV2 virtual-rerender 294 304 2
GroupedListV2 virtual-rerender-with-unmount 324 323 2
IconButton mount 1432 1423 5000
Label mount 452 458 5000
Layer mount 3651 3624 5000
Link mount 566 543 5000
MenuButton mount 1241 1264 5000
MessageBar mount 27865 27799 5000
Nav mount 2570 2523 1000
OverflowSet mount 1025 1036 5000
Panel mount 2307 2329 1000
Persona mount 959 984 1000
Pivot mount 1200 1205 1000
PrimaryButton mount 1113 1105 5000
Rating mount 5788 5841 5000
SearchBox mount 1168 1146 5000
Shimmer mount 2399 2339 5000
Slider mount 1744 1723 5000
SpinButton mount 3833 3809 5000
Spinner mount 518 530 5000
SplitButton mount 2452 2434 5000
Stack mount 530 541 5000
StackWithIntrinsicChildren mount 1141 1168 5000
StackWithTextChildren mount 3244 3235 5000
SwatchColorPicker mount 8187 8184 5000
TagPicker mount 2025 2020 5000
Text mount 499 510 5000
TextField mount 1231 1226 5000
ThemeProvider mount 1148 1132 5000
ThemeProvider virtual-rerender 785 784 5000
ThemeProvider virtual-rerender-with-unmount 1747 1753 5000
Toggle mount 796 813 5000
buttonNative mount 286 282 5000

@TristanWatanabe TristanWatanabe merged commit c2326dc into microsoft:master May 2, 2023
@TristanWatanabe TristanWatanabe deleted the fix/published branch May 2, 2023 00:19
@Hotell Hotell mentioned this pull request May 2, 2023
Merged
@TristanWatanabe TristanWatanabe mentioned this pull request May 2, 2023
Merged
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request May 2, 2023
@marcosmoura
Merge branch 'master' into feat/drawer-header
fde52a5 
* master:
  applying package updates
  fix: dont ignore lib, lib-commonjs and lib-amd files (microsoft#27736)
  Add DraggableZone into export map (microsoft#27569)
  Add export for FolderCover.scss (microsoft#27507)
  applying package updates
  Add filetype icon for Microsoft Designer (microsoft#27724)
  ci: add build task back as lint pre-requirement to unblock temporarily import plugin lint rule (microsoft#27729)
  fix(react-charting): add missing dependency to fix lint violations during release (microsoft#27728)
  Added partition for controlled overflow menu (microsoft#27520)
  Azure Theme 8.0: Tag Button variant for DefaultButton and PrimaryButton (microsoft#27186)
  Azure Theme 8.0 dropdown fix for high contrast themes (microsoft#27346)
  chore: enable TS intellisense in cross library projects for better/consistent DX (microsoft#26605)
  chore: enforce files naming to use .styles.ts [cxe-red files] (microsoft#27710)
  chore(v0): enable emit only dts and use new conformance test API to narrow down TS Program (microsoft#27686)
  codeowner update (microsoft#27719)
  Tag/TagButton init component setup (microsoft#27102)
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-monaco-editor@v1.7.81 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/jest-serializer-merge-styles@v8.0.26 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/cra-template@v8.4.82 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-icons-mdl2@v1.3.39 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-file-type-icons@v8.8.15 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/theme-samples@v8.7.81 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-icon-provider@v1.3.36 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/fluent2-theme@v8.107.5 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/azure-themes@v8.6.1 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/date-time-utilities@v8.5.9 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/scheme-utilities@v8.3.28 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/keyboard-key@v0.4.8 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/foundation-legacy@v8.2.35 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/dom-utilities@v2.2.8 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-cards@v0.205.81 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/merge-styles@v8.5.9 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/font-icons-mdl2@v8.5.15 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-charting@v5.16.24 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-date-time@v8.7.81 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-experiments@v8.14.76 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-docsite-components@v8.12.4 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-hooks@v8.6.22 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/utilities@v8.13.11 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-focus@v8.8.21 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/style-utilities@v8.9.8 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react@v8.109.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-window-provider@v2.2.11 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/theme@v2.6.27 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/set-version@v8.2.8 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot msft-fluent-ui-bot mentioned this pull request May 5, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khmakoto khmakoto khmakoto approved these changes

@JustSlone JustSlone JustSlone approved these changes

@dzearing dzearing Awaiting requested review from dzearing dzearing is a code owner

Assignees

@TristanWatanabe TristanWatanabe

Labels
Area: Build System
Projects
None yet
Milestone
May Project Cycle Q2 2023
Development

Successfully merging this pull request may close these issues.

[Bug]: ESM and AMD folders are missing in the 8.108.3 update
5 participants
@TristanWatanabe @fabricteam @msft-fluent-ui-bot @khmakoto @JustSlone