-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-avatar): add shape
into avatar context
#27738
feat(react-avatar): add shape
into avatar context
#27738
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3ee27a5:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 1872d7e57726762416d06261fb6e9f7e9e255392 (build) |
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
InfoButton | mount | 23 | 18 | 5000 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 710 | 699 | 5000 | |
Button | mount | 381 | 397 | 5000 | |
Field | mount | 1264 | 1240 | 5000 | |
FluentProvider | mount | 886 | 924 | 5000 | |
FluentProviderWithTheme | mount | 128 | 128 | 10 | |
FluentProviderWithTheme | virtual-rerender | 95 | 98 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 106 | 109 | 10 | |
InfoButton | mount | 23 | 18 | 5000 | Possible regression |
MakeStyles | mount | 1117 | 1111 | 50000 | |
Persona | mount | 2019 | 2001 | 5000 | |
SpinButton | mount | 1600 | 1507 | 5000 |
🕵 fluentuiv9 No visual regressions between this PR and main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
packages/react-components/react-avatar/src/components/Avatar/useAvatar.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-avatar/src/contexts/AvatarContext.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-avatar/src/contexts/AvatarContext.ts
Outdated
Show resolved
Hide resolved
…seAvatar.tsx Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
…ext.ts Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
…ext.ts Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
🎉 Handy links: |
Add
shape
into AvatarContext.This is useful when other components needs square shaped avatar.