feat: useToastController should handle toasterId #27902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toasterId can no longer be used from the individual control functions such as `dispatchToast`. Instead, the useToastController should be called with the correct toasterId to return controls for a specific toaster. This should promote modular use of the API and encapsulate toaster behaviour better.
📊 Bundle size report🤖 This report was generated against 31930f6a77d0473edea5eefef5acc63c78ff9de1 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0644a37:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 31930f6a77d0473edea5eefef5acc63c78ff9de1 (build) |
layershifter
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toasterId can no longer be used from the individual control functions such as
dispatchToast.Instead, the useToastController should be called with the correct toasterId to return controls for a specific toaster. This should promote modular use of the API and encapsulate toaster behaviour better.
before
after