Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update test-ssr script #27916

Merged
merged 3 commits into from
May 22, 2023
Merged

chore: update test-ssr script #27916

merged 3 commits into from
May 22, 2023

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented May 19, 2023 •
edited

This PR:

  • Updates test-ssr script to escape the glob
    Note: some shells evaluate globs, Why does process.argv behaves different from glob nodejs/node#15529
  • Removes test-ssr script from @fluentui/react-components, @fluentui/tokens, @fluentui/react-theme, @fluentui/react-migration-v8-v9, @fluentui/react-conformance-griffel; are there are no stories to test for SSR
  • Updates the generator to emit proper script

@github-actions github-actions bot added this to the May Project Cycle Q2 2023 milestone May 19, 2023
@layershifter layershifter marked this pull request as ready for review May 19, 2023 12:22
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 19, 2023 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9432ebd:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented May 19, 2023 •
edited

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 29 26 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 981 970 5000
Button mount 494 534 5000
Field mount 1717 1732 5000
FluentProvider mount 1222 1221 5000
FluentProviderWithTheme mount 148 157 10
FluentProviderWithTheme virtual-rerender 133 131 10
FluentProviderWithTheme virtual-rerender-with-unmount 146 154 10
InfoButton mount 29 26 5000 Possible regression
MakeStyles mount 1426 1392 50000
Persona mount 2769 2695 5000
SpinButton mount 2191 2132 5000

@fabricteam
Copy link
Collaborator

fabricteam commented May 19, 2023 •
edited

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
RefMinimalPerf.default 182 166 1.1:1
TreeWith60ListItems.default 143 131 1.09:1
TableMinimalPerf.default 371 342 1.08:1
AvatarMinimalPerf.default 167 156 1.07:1
ListCommonPerf.default 609 569 1.07:1
VideoMinimalPerf.default 645 605 1.07:1
DividerMinimalPerf.default 318 301 1.06:1
SegmentMinimalPerf.default 303 285 1.06:1
ChatDuplicateMessagesPerf.default 235 224 1.05:1
EmbedMinimalPerf.default 2951 2802 1.05:1
StatusMinimalPerf.default 601 575 1.05:1
AnimationMinimalPerf.default 445 427 1.04:1
AttachmentMinimalPerf.default 119 114 1.04:1
ButtonMinimalPerf.default 134 129 1.04:1
ItemLayoutMinimalPerf.default 1108 1066 1.04:1
LoaderMinimalPerf.default 310 299 1.04:1
PortalMinimalPerf.default 141 135 1.04:1
ToolbarMinimalPerf.default 817 788 1.04:1
DropdownMinimalPerf.default 2219 2160 1.03:1
IconMinimalPerf.default 565 547 1.03:1
AccordionMinimalPerf.default 124 121 1.02:1
BoxMinimalPerf.default 306 301 1.02:1
ButtonOverridesMissPerf.default 1028 1011 1.02:1
CardMinimalPerf.default 460 449 1.02:1
DropdownManyItemsPerf.default 597 586 1.02:1
HeaderMinimalPerf.default 316 310 1.02:1
ListNestedPerf.default 504 494 1.02:1
SkeletonMinimalPerf.default 308 301 1.02:1
TextMinimalPerf.default 309 302 1.02:1
AttachmentSlotsPerf.default 975 968 1.01:1
LabelMinimalPerf.default 339 336 1.01:1
MenuButtonMinimalPerf.default 1545 1531 1.01:1
RosterPerf.default 2209 2195 1.01:1
PopupMinimalPerf.default 550 544 1.01:1
ChatMinimalPerf.default 634 633 1:1
FlexMinimalPerf.default 239 240 1:1
ListMinimalPerf.default 467 469 1:1
RadioGroupMinimalPerf.default 404 403 1:1
SplitButtonMinimalPerf.default 3635 3617 1:1
CustomToolbarPrototype.default 2274 2275 1:1
AlertMinimalPerf.default 228 231 0.99:1
ButtonSlotsPerf.default 479 484 0.99:1
ChatWithPopoverPerf.default 292 296 0.99:1
DatepickerMinimalPerf.default 5559 5587 0.99:1
DialogMinimalPerf.default 683 689 0.99:1
FormMinimalPerf.default 340 342 0.99:1
ProviderMinimalPerf.default 333 337 0.99:1
CarouselMinimalPerf.default 419 427 0.98:1
CheckboxMinimalPerf.default 1859 1901 0.98:1
GridMinimalPerf.default 292 297 0.98:1
ListWith60ListItems.default 559 570 0.98:1
ProviderMergeThemesPerf.default 1181 1200 0.98:1
TableManyItemsPerf.default 1682 1715 0.98:1
TooltipMinimalPerf.default 1836 1875 0.98:1
HeaderSlotsPerf.default 663 686 0.97:1
ImageMinimalPerf.default 328 339 0.97:1
MenuMinimalPerf.default 744 764 0.97:1
SliderMinimalPerf.default 1061 1093 0.97:1
TreeMinimalPerf.default 713 738 0.97:1
InputMinimalPerf.default 858 891 0.96:1
TextAreaMinimalPerf.default 411 426 0.96:1
LayoutMinimalPerf.default 298 315 0.95:1
ReactionMinimalPerf.default 315 331 0.95:1

@fabricteam
Copy link
Collaborator

fabricteam commented May 19, 2023 •
edited

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 798 801 5000
Breadcrumb mount 2226 2183 1000
Checkbox mount 2140 2168 5000
CheckboxBase mount 1874 1874 5000
ChoiceGroup mount 3736 3751 5000
ComboBox mount 883 884 1000
CommandBar mount 8106 8053 1000
ContextualMenu mount 17702 17063 1000
DefaultButton mount 983 990 5000
DetailsRow mount 2898 2928 5000
DetailsRowFast mount 2899 2928 5000
DetailsRowNoStyles mount 2644 2705 5000
Dialog mount 3432 3483 1000
DocumentCardTitle mount 323 319 1000
Dropdown mount 2566 2559 5000
FocusTrapZone mount 1519 1488 5000
FocusZone mount 1478 1496 5000
GroupedList mount 50585 58866 2
GroupedList virtual-rerender 24368 24451 2
GroupedList virtual-rerender-with-unmount 74953 74644 2
GroupedListV2 mount 312 316 2
GroupedListV2 virtual-rerender 303 305 2
GroupedListV2 virtual-rerender-with-unmount 313 317 2
IconButton mount 1428 1413 5000
Label mount 459 466 5000
Layer mount 3599 3595 5000
Link mount 528 540 5000
MenuButton mount 1212 1246 5000
MessageBar mount 27548 27272 5000
Nav mount 2539 2507 1000
OverflowSet mount 1014 1012 5000
Panel mount 2230 2271 1000
Persona mount 953 983 1000
Pivot mount 1178 1174 1000
PrimaryButton mount 1097 1098 5000
Rating mount 5782 5805 5000
SearchBox mount 1148 1158 5000
Shimmer mount 2314 2379 5000
Slider mount 1707 1700 5000
SpinButton mount 3847 3746 5000
Spinner mount 528 522 5000
SplitButton mount 2464 2422 5000
Stack mount 537 534 5000
StackWithIntrinsicChildren mount 1142 1144 5000
StackWithTextChildren mount 3236 3243 5000
SwatchColorPicker mount 8162 8134 5000
TagPicker mount 1965 1976 5000
Text mount 498 502 5000
TextField mount 1206 1191 5000
ThemeProvider mount 1135 1117 5000
ThemeProvider virtual-rerender 788 780 5000
ThemeProvider virtual-rerender-with-unmount 1745 1748 5000
Toggle mount 800 803 5000
buttonNative mount 282 288 5000

@layershifter

This comment was marked as off-topic.

Sign in to view
@azure-pipelines

This comment was marked as outdated.

Sign in to view
@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@layershifter
Copy link
Member Author

/azp run

@fabricteam
Copy link
Collaborator

fabricteam commented May 19, 2023 •
edited

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 560 B
352 B
priority-overflow
createOverflowManager		 3.194 kB
1.315 kB
react-accordion
Accordion (including children components)		 88.329 kB
26.706 kB
react-alert
Alert		 93.534 kB
22.497 kB
react-avatar
Avatar		 57.754 kB
15.041 kB
react-avatar
AvatarGroup		 15.632 kB
6.258 kB
react-avatar
AvatarGroupItem		 73.968 kB
19.552 kB
react-badge
Badge		 23.512 kB
7.197 kB
react-badge
CounterBadge		 24.416 kB
7.506 kB
react-badge
PresenceBadge		 32.094 kB
8.367 kB
react-button
Button		 36.724 kB
9.458 kB
react-button
CompoundButton		 43.873 kB
10.939 kB
react-button
MenuButton		 41.411 kB
10.791 kB
react-button
SplitButton		 49.635 kB
12.364 kB
react-button
ToggleButton		 54.866 kB
11.367 kB
react-card
Card - All		 88.428 kB
25.004 kB
react-card
Card		 83.363 kB
23.556 kB
react-card
CardFooter		 9.158 kB
3.844 kB
react-card
CardHeader		 11.048 kB
4.538 kB
react-card
CardPreview		 9.963 kB
4.192 kB
react-checkbox
Checkbox		 34.268 kB
10.793 kB
react-combobox
Combobox (including child components)		 87.251 kB
28.1 kB
react-combobox
Dropdown (including child components)		 85.635 kB
27.697 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 64.855 kB
17.852 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 205.944 kB
57.706 kB
react-components
react-components: FluentProvider & webLightTheme		 36.086 kB
11.9 kB
react-datepicker-compat
DatePicker Compat		 222.161 kB
59.087 kB
react-dialog
Dialog (including children components)		 91.892 kB
27.42 kB
react-divider
Divider		 17.399 kB
6.298 kB
react-field
Field		 18.864 kB
7.004 kB
react-image
Image		 11.479 kB
4.573 kB
react-infobutton
InfoButton		 129.685 kB
39.584 kB
react-infobutton
InfoLabel		 133.154 kB
40.672 kB
react-input
Input		 24.024 kB
7.682 kB
react-label
Label		 10.104 kB
4.185 kB
react-link
Link		 12.304 kB
5.061 kB
react-menu
Menu (including children components)		 130.392 kB
39.788 kB
react-menu
Menu (including selectable components)		 133.376 kB
40.307 kB
react-overflow
hooks only		 11.214 kB
4.271 kB
react-persona
Persona		 64.675 kB
16.968 kB
react-popover
Popover		 116.676 kB
35.957 kB
react-portal
Portal		 11.649 kB
4.262 kB
react-portal-compat
PortalCompatProvider		 6.446 kB
2.186 kB
react-positioning
usePositioning		 24.008 kB
8.798 kB
react-progress
ProgressBar		 13.856 kB
5.434 kB
react-provider
FluentProvider		 18.033 kB
6.666 kB
react-radio
Radio		 27.282 kB
8.661 kB
react-radio
RadioGroup		 11.312 kB
4.71 kB
react-select
Select		 25.357 kB
8.798 kB
react-slider
Slider		 34.164 kB
11.024 kB
react-spinbutton
SpinButton		 33.934 kB
10.328 kB
react-spinner
Spinner		 20.882 kB
6.798 kB
react-switch
Switch		 29.806 kB
9.274 kB
react-table
DataGrid		 149.721 kB
41.154 kB
react-table
Table (Primitives only)		 44.348 kB
12.347 kB
react-table
Table as DataGrid		 132.279 kB
33.668 kB
react-table
Table (Selection only)		 78.056 kB
19.084 kB
react-table
Table (Sort only)		 77.386 kB
18.896 kB
react-tags
Tag		 21.99 kB
7.887 kB
react-text
Text - Default		 12.492 kB
4.92 kB
react-text
Text - Wrappers		 15.624 kB
5.232 kB
react-textarea
Textarea		 27.528 kB
9.051 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 31.33 kB
6.764 kB
react-theme
Teams: Light theme		 17.895 kB
5.162 kB
react-tooltip
Tooltip		 46.708 kB
16.376 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 4712e804cb74fe57090abcc2ac796ec464971b85

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@size-auditor
Copy link

size-auditor bot commented May 19, 2023 •
edited

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4712e804cb74fe57090abcc2ac796ec464971b85 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented May 19, 2023 •
edited

🕵 FluentUI-v0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented May 19, 2023 •
edited

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@layershifter
Copy link
Member Author

Build is passing, I have an approval from @microsoft/fluentui-react-build ✅ Force merging as it's a simple change.

@layershifter layershifter merged commit 69e0617 into microsoft:master May 22, 2023
29 checks passed
@layershifter layershifter deleted the chore/update-test-ssr-script branch May 22, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ling1726 ling1726 ling1726 left review comments

@Hotell Hotell Hotell approved these changes

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT GeoffCoxMSFT is a code owner

@sopranopillow sopranopillow Awaiting requested review from sopranopillow sopranopillow is a code owner

@khmakoto khmakoto Awaiting requested review from khmakoto khmakoto is a code owner

@Mitch-At-Work Mitch-At-Work Awaiting requested review from Mitch-At-Work Mitch-At-Work is a code owner

@tomi-msft tomi-msft Awaiting requested review from tomi-msft tomi-msft is a code owner

@ms-acalzaretto ms-acalzaretto Awaiting requested review from ms-acalzaretto ms-acalzaretto is a code owner

@chpalac chpalac Awaiting requested review from chpalac chpalac is a code owner

@behowell behowell Awaiting requested review from behowell behowell is a code owner

@spmonahan spmonahan Awaiting requested review from spmonahan spmonahan is a code owner

@micahgodbolt micahgodbolt Awaiting requested review from micahgodbolt micahgodbolt is a code owner

@smhigley smhigley Awaiting requested review from smhigley smhigley is a code owner

Assignees

@TristanWatanabe TristanWatanabe

Labels
None yet
Projects
None yet
Milestone
May Project Cycle Q2 2023
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@layershifter @fabricteam @Hotell @ling1726 @TristanWatanabe