-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Griffel/bump to 1.5.7 #27925
Griffel/bump to 1.5.7 #27925
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9315ba1:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 98c157fc502beffdee224d0b8274d700ef5ea1d8 (build) |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 565 | 592 | 5000 | |
Button | mount | 300 | 296 | 5000 | |
Field | mount | 1050 | 1027 | 5000 | |
FluentProvider | mount | 647 | 655 | 5000 | |
FluentProviderWithTheme | mount | 86 | 84 | 10 | |
FluentProviderWithTheme | virtual-rerender | 64 | 69 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 73 | 74 | 10 | |
InfoButton | mount | 16 | 10 | 5000 | |
MakeStyles | mount | 826 | 869 | 50000 | |
Persona | mount | 1573 | 1560 | 5000 | |
SpinButton | mount | 1262 | 1286 | 5000 |
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
---|---|---|---|---|
AccordionMinimalPerf.default | 82 | 71 | 1.15:1 | analysis |
PortalMinimalPerf.default | 86 | 81 | 1.06:1 | analysis |
AvatarMinimalPerf.default | 104 | 100 | 1.04:1 | analysis |
AttachmentMinimalPerf.default | 75 | 81 | 0.93:1 | analysis |
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
HeaderMinimalPerf.default | 213 | 197 | 1.08:1 |
ListWith60ListItems.default | 383 | 356 | 1.08:1 |
ReactionMinimalPerf.default | 213 | 198 | 1.08:1 |
RefMinimalPerf.default | 104 | 97 | 1.07:1 |
IconMinimalPerf.default | 379 | 356 | 1.06:1 |
AttachmentSlotsPerf.default | 640 | 609 | 1.05:1 |
ButtonMinimalPerf.default | 88 | 84 | 1.05:1 |
ChatWithPopoverPerf.default | 191 | 182 | 1.05:1 |
SliderMinimalPerf.default | 685 | 650 | 1.05:1 |
VideoMinimalPerf.default | 434 | 413 | 1.05:1 |
AlertMinimalPerf.default | 157 | 151 | 1.04:1 |
LayoutMinimalPerf.default | 198 | 191 | 1.04:1 |
TableManyItemsPerf.default | 1066 | 1028 | 1.04:1 |
InputMinimalPerf.default | 528 | 512 | 1.03:1 |
LabelMinimalPerf.default | 212 | 205 | 1.03:1 |
ToolbarMinimalPerf.default | 512 | 499 | 1.03:1 |
CardMinimalPerf.default | 294 | 287 | 1.02:1 |
EmbedMinimalPerf.default | 1686 | 1645 | 1.02:1 |
GridMinimalPerf.default | 191 | 188 | 1.02:1 |
ItemLayoutMinimalPerf.default | 699 | 684 | 1.02:1 |
ListMinimalPerf.default | 287 | 281 | 1.02:1 |
ListNestedPerf.default | 315 | 310 | 1.02:1 |
LoaderMinimalPerf.default | 178 | 174 | 1.02:1 |
MenuButtonMinimalPerf.default | 927 | 911 | 1.02:1 |
ProviderMergeThemesPerf.default | 642 | 628 | 1.02:1 |
TableMinimalPerf.default | 223 | 218 | 1.02:1 |
ChatMinimalPerf.default | 414 | 410 | 1.01:1 |
FlexMinimalPerf.default | 148 | 146 | 1.01:1 |
MenuMinimalPerf.default | 489 | 482 | 1.01:1 |
SegmentMinimalPerf.default | 189 | 188 | 1.01:1 |
SkeletonMinimalPerf.default | 185 | 184 | 1.01:1 |
TreeMinimalPerf.default | 458 | 453 | 1.01:1 |
ButtonSlotsPerf.default | 290 | 289 | 1:1 |
ChatDuplicateMessagesPerf.default | 141 | 141 | 1:1 |
CheckboxMinimalPerf.default | 1085 | 1087 | 1:1 |
DatepickerMinimalPerf.default | 3351 | 3336 | 1:1 |
DropdownManyItemsPerf.default | 371 | 370 | 1:1 |
HeaderSlotsPerf.default | 447 | 448 | 1:1 |
RosterPerf.default | 1453 | 1458 | 1:1 |
ProviderMinimalPerf.default | 191 | 191 | 1:1 |
StatusMinimalPerf.default | 393 | 394 | 1:1 |
TreeWith60ListItems.default | 80 | 80 | 1:1 |
ButtonOverridesMissPerf.default | 600 | 607 | 0.99:1 |
DividerMinimalPerf.default | 197 | 199 | 0.99:1 |
FormMinimalPerf.default | 215 | 217 | 0.99:1 |
PopupMinimalPerf.default | 331 | 336 | 0.99:1 |
SplitButtonMinimalPerf.default | 2149 | 2173 | 0.99:1 |
TextMinimalPerf.default | 188 | 189 | 0.99:1 |
TextAreaMinimalPerf.default | 274 | 276 | 0.99:1 |
CustomToolbarPrototype.default | 1376 | 1384 | 0.99:1 |
AnimationMinimalPerf.default | 281 | 286 | 0.98:1 |
BoxMinimalPerf.default | 178 | 182 | 0.98:1 |
DropdownMinimalPerf.default | 1378 | 1402 | 0.98:1 |
CarouselMinimalPerf.default | 245 | 252 | 0.97:1 |
ImageMinimalPerf.default | 221 | 228 | 0.97:1 |
TooltipMinimalPerf.default | 1166 | 1201 | 0.97:1 |
DialogMinimalPerf.default | 426 | 445 | 0.96:1 |
ListCommonPerf.default | 374 | 397 | 0.94:1 |
RadioGroupMinimalPerf.default | 235 | 251 | 0.94:1 |
🕵 FluentUI-v0 No visual regressions between this PR and main |
🕵 fluentuiv9 No visual regressions between this PR and main |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 625 | 644 | 5000 | |
Breadcrumb | mount | 1676 | 1650 | 1000 | |
Checkbox | mount | 1715 | 1689 | 5000 | |
CheckboxBase | mount | 1461 | 1455 | 5000 | |
ChoiceGroup | mount | 2968 | 2894 | 5000 | |
ComboBox | mount | 682 | 653 | 1000 | |
CommandBar | mount | 6200 | 6151 | 1000 | |
ContextualMenu | mount | 13990 | 13746 | 1000 | |
DefaultButton | mount | 763 | 762 | 5000 | |
DetailsRow | mount | 2183 | 2213 | 5000 | |
DetailsRowFast | mount | 2238 | 2177 | 5000 | |
DetailsRowNoStyles | mount | 2076 | 2039 | 5000 | |
Dialog | mount | 2572 | 2606 | 1000 | |
DocumentCardTitle | mount | 231 | 229 | 1000 | |
Dropdown | mount | 1979 | 1985 | 5000 | |
FocusTrapZone | mount | 1098 | 1167 | 5000 | |
FocusZone | mount | 1032 | 1051 | 5000 | |
GroupedList | mount | 41334 | 41484 | 2 | |
GroupedList | virtual-rerender | 17637 | 19958 | 2 | |
GroupedList | virtual-rerender-with-unmount | 49946 | 50291 | 2 | |
GroupedListV2 | mount | 217 | 219 | 2 | |
GroupedListV2 | virtual-rerender | 203 | 206 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 234 | 215 | 2 | |
IconButton | mount | 1041 | 1075 | 5000 | |
Label | mount | 338 | 344 | 5000 | |
Layer | mount | 2664 | 2672 | 5000 | |
Link | mount | 378 | 392 | 5000 | |
MenuButton | mount | 924 | 966 | 5000 | |
MessageBar | mount | 21301 | 21183 | 5000 | |
Nav | mount | 1954 | 1925 | 1000 | |
OverflowSet | mount | 750 | 761 | 5000 | |
Panel | mount | 1723 | 1711 | 1000 | |
Persona | mount | 734 | 717 | 1000 | |
Pivot | mount | 872 | 900 | 1000 | |
PrimaryButton | mount | 857 | 833 | 5000 | |
Rating | mount | 4531 | 4680 | 5000 | |
SearchBox | mount | 884 | 890 | 5000 | |
Shimmer | mount | 1857 | 1878 | 5000 | |
Slider | mount | 1320 | 1311 | 5000 | |
SpinButton | mount | 2828 | 2843 | 5000 | |
Spinner | mount | 367 | 376 | 5000 | |
SplitButton | mount | 1823 | 1779 | 5000 | |
Stack | mount | 393 | 401 | 5000 | |
StackWithIntrinsicChildren | mount | 832 | 841 | 5000 | |
StackWithTextChildren | mount | 2586 | 2634 | 5000 | |
SwatchColorPicker | mount | 6072 | 6097 | 5000 | |
TagPicker | mount | 1450 | 1449 | 5000 | |
Text | mount | 360 | 376 | 5000 | |
TextField | mount | 916 | 922 | 5000 | |
ThemeProvider | mount | 832 | 826 | 5000 | |
ThemeProvider | virtual-rerender | 564 | 583 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1263 | 1273 | 5000 | |
Toggle | mount | 617 | 602 | 5000 | |
buttonNative | mount | 188 | 192 | 5000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to run npx yarn-deduplicate --strategy fewer
to avoid duplicates in yarn.lock
.
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
* master: Added truncation and tooltips to the Breadcrumb (microsoft#27859) applying package updates applying package updates Export selection types from combobox (microsoft#28054) fix(react-datepicker-compat): Remove focus function from the deps to avoid constant move of focus (microsoft#28053) Updated poster for new stable components (microsoft#28051) Griffel/bump to 1.5.7 (microsoft#27925) feat(scripts): replace use of SWC CLI with SWC transform api (microsoft#27380) chore: Add positioning test for scroll jumps (microsoft#28043) chore: migrate to TS 4.5 (microsoft#27936) Fix toolbar divider styles (microsoft#28044) fix: createFocusOutlineStyle don't work with CSS variables (microsoft#27966) feat(react-tags): use simple button for TagButton content instead of aria button (microsoft#28033)
Bumps Griffel to 1.5.7 from 1.5.2.
A partner team needs the insertionPoint API.
Griffel CHANGELOG