Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Griffel/bump to 1.5.7 #27925

Merged
merged 12 commits into from
May 30, 2023
Merged

Conversation

spmonahan
Copy link
Contributor

Bumps Griffel to 1.5.7 from 1.5.2.

A partner team needs the insertionPoint API.

Griffel CHANGELOG

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 19, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9315ba1:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented May 19, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 98c157fc502beffdee224d0b8274d700ef5ea1d8 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented May 19, 2023

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 565 592 5000
Button mount 300 296 5000
Field mount 1050 1027 5000
FluentProvider mount 647 655 5000
FluentProviderWithTheme mount 86 84 10
FluentProviderWithTheme virtual-rerender 64 69 10
FluentProviderWithTheme virtual-rerender-with-unmount 73 74 10
InfoButton mount 16 10 5000
MakeStyles mount 826 869 50000
Persona mount 1573 1560 5000
SpinButton mount 1262 1286 5000

@fabricteam
Copy link
Collaborator

fabricteam commented May 19, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-accordion
Accordion (including children components)
88.431 kB
26.755 kB
88.516 kB
26.795 kB
85 B
40 B
react-alert
Alert
93.464 kB
22.496 kB
93.549 kB
22.537 kB
85 B
41 B
react-avatar
Avatar
57.712 kB
15.048 kB
57.797 kB
15.091 kB
85 B
43 B
react-avatar
AvatarGroup
15.561 kB
6.25 kB
15.646 kB
6.298 kB
85 B
48 B
react-avatar
AvatarGroupItem
73.888 kB
19.537 kB
73.973 kB
19.582 kB
85 B
45 B
react-badge
Badge
23.47 kB
7.203 kB
23.555 kB
7.256 kB
85 B
53 B
react-badge
CounterBadge
24.372 kB
7.51 kB
24.457 kB
7.559 kB
85 B
49 B
react-badge
PresenceBadge
32.05 kB
8.37 kB
32.135 kB
8.423 kB
85 B
53 B
react-button
Button
36.657 kB
9.451 kB
36.742 kB
9.5 kB
85 B
49 B
react-button
CompoundButton
43.811 kB
10.931 kB
43.896 kB
10.98 kB
85 B
49 B
react-button
MenuButton
41.342 kB
10.786 kB
41.427 kB
10.836 kB
85 B
50 B
react-button
SplitButton
49.564 kB
12.365 kB
49.649 kB
12.42 kB
85 B
55 B
react-button
ToggleButton
54.939 kB
11.39 kB
55.024 kB
11.436 kB
85 B
46 B
react-card
Card - All
88.631 kB
25.056 kB
88.716 kB
25.114 kB
85 B
58 B
react-card
Card
83.566 kB
23.604 kB
83.651 kB
23.658 kB
85 B
54 B
react-card
CardFooter
9.108 kB
3.846 kB
9.193 kB
3.892 kB
85 B
46 B
react-card
CardHeader
11.004 kB
4.541 kB
11.089 kB
4.588 kB
85 B
47 B
react-card
CardPreview
9.913 kB
4.197 kB
9.998 kB
4.24 kB
85 B
43 B
react-checkbox
Checkbox
34.415 kB
10.828 kB
34.5 kB
10.878 kB
85 B
50 B
react-combobox
Combobox (including child components)
87.65 kB
28.201 kB
87.735 kB
28.243 kB
85 B
42 B
react-combobox
Dropdown (including child components)
85.989 kB
27.807 kB
86.074 kB
27.848 kB
85 B
41 B
react-components
react-components: Button, FluentProvider & webLightTheme
64.814 kB
17.858 kB
64.899 kB
17.91 kB
85 B
52 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
206.34 kB
57.876 kB
206.425 kB
57.914 kB
85 B
38 B
react-components
react-components: FluentProvider & webLightTheme
36.047 kB
11.912 kB
36.132 kB
11.954 kB
85 B
42 B
react-datepicker-compat
DatePicker Compat
222.477 kB
59.161 kB
222.562 kB
59.206 kB
85 B
45 B
react-dialog
Dialog (including children components)
91.991 kB
27.45 kB
92.076 kB
27.492 kB
85 B
42 B
react-divider
Divider
17.356 kB
6.302 kB
17.441 kB
6.349 kB
85 B
47 B
react-field
Field
18.815 kB
7.03 kB
18.9 kB
7.083 kB
85 B
53 B
react-image
Image
11.429 kB
4.578 kB
11.514 kB
4.619 kB
85 B
41 B
react-infobutton
InfoButton
130.036 kB
39.727 kB
130.121 kB
39.785 kB
85 B
58 B
react-infobutton
InfoLabel
133.501 kB
40.805 kB
133.586 kB
40.852 kB
85 B
47 B
react-input
Input
24.098 kB
7.717 kB
24.183 kB
7.772 kB
85 B
55 B
react-label
Label
10.054 kB
4.19 kB
10.139 kB
4.231 kB
85 B
41 B
react-link
Link
12.254 kB
5.069 kB
12.339 kB
5.105 kB
85 B
36 B
react-menu
Menu (including children components)
130.763 kB
39.909 kB
130.848 kB
39.946 kB
85 B
37 B
react-menu
Menu (including selectable components)
133.747 kB
40.422 kB
133.832 kB
40.479 kB
85 B
57 B
react-persona
Persona
64.633 kB
16.971 kB
64.718 kB
17.012 kB
85 B
41 B
react-popover
Popover
116.998 kB
36.074 kB
117.083 kB
36.122 kB
85 B
48 B
react-portal
Portal
11.591 kB
4.261 kB
11.676 kB
4.31 kB
85 B
49 B
react-progress
ProgressBar
13.806 kB
5.438 kB
13.891 kB
5.482 kB
85 B
44 B
react-provider
FluentProvider
17.994 kB
6.67 kB
18.079 kB
6.713 kB
85 B
43 B
react-radio
Radio
27.319 kB
8.667 kB
27.404 kB
8.722 kB
85 B
55 B
react-radio
RadioGroup
11.241 kB
4.704 kB
11.326 kB
4.743 kB
85 B
39 B
react-select
Select
25.288 kB
8.788 kB
25.373 kB
8.826 kB
85 B
38 B
react-slider
Slider
34.237 kB
11.054 kB
34.322 kB
11.099 kB
85 B
45 B
react-spinbutton
SpinButton
34.036 kB
10.376 kB
34.121 kB
10.421 kB
85 B
45 B
react-spinner
Spinner
21.242 kB
6.971 kB
21.327 kB
7.015 kB
85 B
44 B
react-switch
Switch
29.839 kB
9.292 kB
29.924 kB
9.342 kB
85 B
50 B
react-table
DataGrid
150.783 kB
41.468 kB
150.868 kB
41.518 kB
85 B
50 B
react-table
Table (Primitives only)
45.026 kB
12.519 kB
45.111 kB
12.567 kB
85 B
48 B
react-table
Table as DataGrid
133.271 kB
33.956 kB
133.356 kB
34.002 kB
85 B
46 B
react-table
Table (Selection only)
79.04 kB
19.33 kB
79.125 kB
19.379 kB
85 B
49 B
react-table
Table (Sort only)
78.37 kB
19.138 kB
78.455 kB
19.187 kB
85 B
49 B
react-tags
Tag
21.919 kB
7.883 kB
22.004 kB
7.93 kB
85 B
47 B
react-text
Text - Default
12.442 kB
4.924 kB
12.527 kB
4.963 kB
85 B
39 B
react-text
Text - Wrappers
15.592 kB
5.24 kB
15.677 kB
5.284 kB
85 B
44 B
react-textarea
Textarea
27.601 kB
9.085 kB
27.686 kB
9.126 kB
85 B
41 B
react-tooltip
Tooltip
47.034 kB
16.485 kB
47.119 kB
16.528 kB
85 B
43 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
510 B
330 B
global-context
createContextSelector
537 B
342 B
priority-overflow
createOverflowManager
3.194 kB
1.315 kB
react-overflow
hooks only
11.206 kB
4.266 kB
react-portal-compat
PortalCompatProvider
6.473 kB
2.196 kB
react-positioning
usePositioning
24.249 kB
8.856 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
31.33 kB
6.764 kB
react-theme
Teams: Light theme
17.895 kB
5.162 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against 98c157fc502beffdee224d0b8274d700ef5ea1d8

@fabricteam
Copy link
Collaborator

fabricteam commented May 19, 2023

Perf Analysis (@fluentui/react-northstar)

⚠️ 4 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AccordionMinimalPerf.default 82 71 1.15:1 analysis
PortalMinimalPerf.default 86 81 1.06:1 analysis
AvatarMinimalPerf.default 104 100 1.04:1 analysis
AttachmentMinimalPerf.default 75 81 0.93:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
HeaderMinimalPerf.default 213 197 1.08:1
ListWith60ListItems.default 383 356 1.08:1
ReactionMinimalPerf.default 213 198 1.08:1
RefMinimalPerf.default 104 97 1.07:1
IconMinimalPerf.default 379 356 1.06:1
AttachmentSlotsPerf.default 640 609 1.05:1
ButtonMinimalPerf.default 88 84 1.05:1
ChatWithPopoverPerf.default 191 182 1.05:1
SliderMinimalPerf.default 685 650 1.05:1
VideoMinimalPerf.default 434 413 1.05:1
AlertMinimalPerf.default 157 151 1.04:1
LayoutMinimalPerf.default 198 191 1.04:1
TableManyItemsPerf.default 1066 1028 1.04:1
InputMinimalPerf.default 528 512 1.03:1
LabelMinimalPerf.default 212 205 1.03:1
ToolbarMinimalPerf.default 512 499 1.03:1
CardMinimalPerf.default 294 287 1.02:1
EmbedMinimalPerf.default 1686 1645 1.02:1
GridMinimalPerf.default 191 188 1.02:1
ItemLayoutMinimalPerf.default 699 684 1.02:1
ListMinimalPerf.default 287 281 1.02:1
ListNestedPerf.default 315 310 1.02:1
LoaderMinimalPerf.default 178 174 1.02:1
MenuButtonMinimalPerf.default 927 911 1.02:1
ProviderMergeThemesPerf.default 642 628 1.02:1
TableMinimalPerf.default 223 218 1.02:1
ChatMinimalPerf.default 414 410 1.01:1
FlexMinimalPerf.default 148 146 1.01:1
MenuMinimalPerf.default 489 482 1.01:1
SegmentMinimalPerf.default 189 188 1.01:1
SkeletonMinimalPerf.default 185 184 1.01:1
TreeMinimalPerf.default 458 453 1.01:1
ButtonSlotsPerf.default 290 289 1:1
ChatDuplicateMessagesPerf.default 141 141 1:1
CheckboxMinimalPerf.default 1085 1087 1:1
DatepickerMinimalPerf.default 3351 3336 1:1
DropdownManyItemsPerf.default 371 370 1:1
HeaderSlotsPerf.default 447 448 1:1
RosterPerf.default 1453 1458 1:1
ProviderMinimalPerf.default 191 191 1:1
StatusMinimalPerf.default 393 394 1:1
TreeWith60ListItems.default 80 80 1:1
ButtonOverridesMissPerf.default 600 607 0.99:1
DividerMinimalPerf.default 197 199 0.99:1
FormMinimalPerf.default 215 217 0.99:1
PopupMinimalPerf.default 331 336 0.99:1
SplitButtonMinimalPerf.default 2149 2173 0.99:1
TextMinimalPerf.default 188 189 0.99:1
TextAreaMinimalPerf.default 274 276 0.99:1
CustomToolbarPrototype.default 1376 1384 0.99:1
AnimationMinimalPerf.default 281 286 0.98:1
BoxMinimalPerf.default 178 182 0.98:1
DropdownMinimalPerf.default 1378 1402 0.98:1
CarouselMinimalPerf.default 245 252 0.97:1
ImageMinimalPerf.default 221 228 0.97:1
TooltipMinimalPerf.default 1166 1201 0.97:1
DialogMinimalPerf.default 426 445 0.96:1
ListCommonPerf.default 374 397 0.94:1
RadioGroupMinimalPerf.default 235 251 0.94:1

@fabricteam
Copy link
Collaborator

fabricteam commented May 19, 2023

🕵 FluentUI-v0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented May 19, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented May 19, 2023

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 625 644 5000
Breadcrumb mount 1676 1650 1000
Checkbox mount 1715 1689 5000
CheckboxBase mount 1461 1455 5000
ChoiceGroup mount 2968 2894 5000
ComboBox mount 682 653 1000
CommandBar mount 6200 6151 1000
ContextualMenu mount 13990 13746 1000
DefaultButton mount 763 762 5000
DetailsRow mount 2183 2213 5000
DetailsRowFast mount 2238 2177 5000
DetailsRowNoStyles mount 2076 2039 5000
Dialog mount 2572 2606 1000
DocumentCardTitle mount 231 229 1000
Dropdown mount 1979 1985 5000
FocusTrapZone mount 1098 1167 5000
FocusZone mount 1032 1051 5000
GroupedList mount 41334 41484 2
GroupedList virtual-rerender 17637 19958 2
GroupedList virtual-rerender-with-unmount 49946 50291 2
GroupedListV2 mount 217 219 2
GroupedListV2 virtual-rerender 203 206 2
GroupedListV2 virtual-rerender-with-unmount 234 215 2
IconButton mount 1041 1075 5000
Label mount 338 344 5000
Layer mount 2664 2672 5000
Link mount 378 392 5000
MenuButton mount 924 966 5000
MessageBar mount 21301 21183 5000
Nav mount 1954 1925 1000
OverflowSet mount 750 761 5000
Panel mount 1723 1711 1000
Persona mount 734 717 1000
Pivot mount 872 900 1000
PrimaryButton mount 857 833 5000
Rating mount 4531 4680 5000
SearchBox mount 884 890 5000
Shimmer mount 1857 1878 5000
Slider mount 1320 1311 5000
SpinButton mount 2828 2843 5000
Spinner mount 367 376 5000
SplitButton mount 1823 1779 5000
Stack mount 393 401 5000
StackWithIntrinsicChildren mount 832 841 5000
StackWithTextChildren mount 2586 2634 5000
SwatchColorPicker mount 6072 6097 5000
TagPicker mount 1450 1449 5000
Text mount 360 376 5000
TextField mount 916 922 5000
ThemeProvider mount 832 826 5000
ThemeProvider virtual-rerender 564 583 5000
ThemeProvider virtual-rerender-with-unmount 1263 1273 5000
Toggle mount 617 602 5000
buttonNative mount 188 192 5000

Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run npx yarn-deduplicate --strategy fewer to avoid duplicates in yarn.lock.

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-text@v9.3.12 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-textarea@v9.3.16 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-toolbar@v9.1.17 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-tooltip@v9.2.16 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-tree@v9.0.0-beta.18 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-accordion@v9.1.16 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-alert@v9.0.0-beta.51 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-avatar@v9.5.5 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-badge@v9.1.15 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-button@v9.3.16 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-checkbox@v9.1.17 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-dialog@v9.5.9 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-divider@v9.2.15 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-field@v9.1.6 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-image@v9.1.12 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-infobutton@v9.0.0-beta.34 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-input@v9.4.16 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-label@v9.1.15 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-link@v9.0.42 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-menu@v9.7.16 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-migration-v0-v9@v9.0.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-migration-v8-v9@v9.2.16 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-overflow@v9.0.19 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-card@v9.0.14 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-tabster@v9.7.5 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-virtualizer@v9.0.0-alpha.22 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-datepicker-compat@v0.1.5 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-drawer@v9.0.0-beta.1 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-components@v9.21.0 has been released which incorporates this pull request.:tada:

Handy links:

marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request May 31, 2023
* master:
  Added truncation and tooltips to the Breadcrumb (microsoft#27859)
  applying package updates
  applying package updates
  Export selection types from combobox (microsoft#28054)
  fix(react-datepicker-compat): Remove focus function from the deps to avoid constant move of focus (microsoft#28053)
  Updated poster for new stable components (microsoft#28051)
  Griffel/bump to 1.5.7 (microsoft#27925)
  feat(scripts): replace use of SWC CLI with SWC transform api (microsoft#27380)
  chore: Add positioning test for scroll jumps (microsoft#28043)
  chore: migrate to TS 4.5 (microsoft#27936)
  Fix toolbar divider styles (microsoft#28044)
  fix: createFocusOutlineStyle don't work with CSS variables (microsoft#27966)
  feat(react-tags): use simple button for TagButton content instead of aria button (microsoft#28033)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet