-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertical Bar Chart - Component tests #28013
Vertical Bar Chart - Component tests #28013
Conversation
…sers/srmukher/ComponentTestsVBC
…/srmukher/fluentui into users/srmukher/ComponentTestsVBC
📊 Bundle size report🤖 This report was generated against 8d1440d45a86ccedae6aeb20825b0756342c1b49 |
Asset size changes
Baseline commit: 8d1440d45a86ccedae6aeb20825b0756342c1b49 (build) |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2f6418b:
|
…sers/srmukher/ComponentTestsVBC
ef67ec8
to
aa54a5c
Compare
…sers/srmukher/ComponentTestsVBC
packages/react-charting/docs/TestPlans/VerticalBarChart/ComponentTests.md
Outdated
Show resolved
Hide resolved
packages/react-charting/docs/TestPlans/VerticalBarChart/ComponentTests.md
Outdated
Show resolved
Hide resolved
packages/react-charting/docs/TestPlans/VerticalBarChart/ComponentTests.md
Outdated
Show resolved
Hide resolved
packages/react-charting/docs/TestPlans/VerticalBarChart/ComponentTests.md
Outdated
Show resolved
Hide resolved
packages/react-charting/src/components/VerticalBarChart/VerticalBarChartRTL.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-charting/src/components/VerticalBarChart/VerticalBarChartRTL.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-charting/src/components/VerticalBarChart/VerticalBarChartRTL.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-charting/src/components/VerticalBarChart/VerticalBarChartRTL.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-charting/src/components/VerticalBarChart/VerticalBarChartRTL.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-charting/src/components/VerticalBarChart/VerticalBarChartRTL.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-charting/src/components/VerticalBarChart/VerticalBarChartRTL.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-charting/src/components/VerticalBarChart/VerticalBarChartRTL.test.tsx
Outdated
Show resolved
Hide resolved
482e3a2
to
db3af23
Compare
bb38558
to
9db4484
Compare
Added component tests for vertical bar chart. Improved the test coverage from 57% to 77%
Improved the test coverage:
From:
![image](https://private-user-images.githubusercontent.com/120183316/241215654-c514dabf-3a02-4c33-a63f-ca9165c915fa.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA4MjE2NTYsIm5iZiI6MTcyMDgyMTM1NiwicGF0aCI6Ii8xMjAxODMzMTYvMjQxMjE1NjU0LWM1MTRkYWJmLTNhMDItNGMzMy1hNjNmLWNhOTE2NWM5MTVmYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxMlQyMTU1NTZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yNzM5Y2VmMDIwNDE3NzZhZWI4ZTllNTFjNTM4OTUyZDFiNmRmYTA1NmFlNjdkMzkyNGI4N2ZlNjdkODMxMjZkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.zxFHWOMUJLSMe-ovPMif2tZXlvLoRZARpOF66F15Zvc)
To:
![image](https://private-user-images.githubusercontent.com/120183316/241215027-78257fcd-c2fa-47b6-b8ff-f41cd2efc126.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA4MjE2NTYsIm5iZiI6MTcyMDgyMTM1NiwicGF0aCI6Ii8xMjAxODMzMTYvMjQxMjE1MDI3LTc4MjU3ZmNkLWMyZmEtNDdiNi1iOGZmLWY0MWNkMmVmYzEyNi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxMlQyMTU1NTZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03YjM0MGFkMTk2MDkxMzg5NGZjYzEyMWRmMDkyNzRkZTA2NTVjZTQxNmI5ZTc3NjViYzEzMTkxNTZlZmZlNTYxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.vkd-MVAyNk1qKBh4c5iT5wlu5YhubZCfRsPHfb1Ld8Q)