-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-datepicker-compat): Add null to value prop and handle controlled cases correctly #28056
feat(react-datepicker-compat): Add null to value prop and handle controlled cases correctly #28056
Conversation
📊 Bundle size report
🤖 This report was generated against 0eae1bc208e0d69febb4bc1e70ab1e2c7c96b623 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4bbb936:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 0eae1bc208e0d69febb4bc1e70ab1e2c7c96b623 (build) |
🕵 fluentuiv9 No visual regressions between this PR and main |
…to datepicker-compat/controlled
…to datepicker-compat/controlled
...react-components/react-datepicker-compat/stories/DatePicker/DatePickerControlled.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-datepicker-compat/src/components/DatePicker/DatePicker.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-datepicker-compat/src/components/DatePicker/useDatePicker.tsx
Show resolved
Hide resolved
packages/react-components/react-datepicker-compat/src/components/DatePicker/useDatePicker.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-datepicker-compat/src/components/DatePicker/useDatePicker.tsx
Outdated
Show resolved
Hide resolved
…pranopillow/fluentui into datepicker-compat/controlled
* master: applying package updates doc: Remove wrong recommendation from input (microsoft#28168) fix: Outline color now respects OS force colors settings (microsoft#28182) Datepicker onCalendarOpenStateChange prop (microsoft#28136) feat(react-file-type-icons): Add getFileTypeIconAsUrl utility (microsoft#27336) applying package updates [FIX] Updates selection dot and label positioning for ChoiceGroupOption when an Image or Icon is present. (microsoft#28173) chore(react-infobutton): Rename InfoTip to InfoIcon (microsoft#28177) fix(react-datepicker-compat): Make DatePicker Compat stories SSR safe (microsoft#28017) Added `tab` focus mode to the Breadcrumb (microsoft#28046) docs: Add usable documentation (microsoft#28155) applying package updates Fix up rebase code (microsoft#27864) fix: ContextualMenu indexing in sections (microsoft#28127) applying package updates fix: Layer sets focus visible classname for its FocusRectsProvider (microsoft#28157) docs(react-infobutton): Update stories to show better guidance (microsoft#28144) fix(react-avatar): Do not render the image when src prop is undefined (microsoft#28146) feat(react-datepicker-compat): Add null to value prop and handle controlled cases correctly (microsoft#28056)
🎉 Handy links: |
🎉 Handy links: |
Previous Behavior
Currently the controlled vs uncontrolled use cases are handled the same way as in v8. This is an issue since v8 switches between controlled and controlled without warning.
New Behavior
To avoid this issue and continue using the useControllableState hook, the null type was added to the value prop to handle the controlled cases with null.
Related Issue(s)