-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(web-components): Add playwright testing for v3 web components #28142
chore(web-components): Add playwright testing for v3 web components #28142
Conversation
@Hotell Would love your help figuring out where/when to install playwright as part of the build. I expect this to fail since w/o a global playwright installation the chrome binaries won't be available. |
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: bad22a25ca9c4551f0910425b4fb1fd428f5a5f0 (build) |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 485e9b1:
|
}, | ||
webServer: { | ||
// double-quotes are required for Windows | ||
command: `node -e "import('express').then(({ default: e }) => e().use(e.static('./storybook-static')).listen(6006))"`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What builds the storybook to ./storybook-static
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Locally you'd run the storybook server and then run yarn test
. I added a note in the package readme about this. In the case of CI, it'll run the server itself, but locally we reuse it.
2bb200b
to
e4ead0d
Compare
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
ab71121
to
1b0006d
Compare
/azp |
Supported commands
See additional documentation. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
1b0006d
to
d0d3754
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
45b378c
to
b98e70d
Compare
b98e70d
to
6417f5f
Compare
@TristanWatanabe @ling1726 we need sign off from fluent ui react build now that Martin's out, can you review this? |
…28142) * setup playwright testing * fix deps and update readme * add playwright to ensure browsers and deps are installed * test npx command playwright * add pretest hook to test * add dev specific testing command so we can run ci pretest * point to the right directory chris...
…icrosoft#28142) * setup playwright testing * fix deps and update readme * add playwright to ensure browsers and deps are installed * test npx command playwright * add pretest hook to test * add dev specific testing command so we can run ci pretest * point to the right directory chris...
…icrosoft#28142) * setup playwright testing * fix deps and update readme * add playwright to ensure browsers and deps are installed * test npx command playwright * add pretest hook to test * add dev specific testing command so we can run ci pretest * point to the right directory chris...
…icrosoft#28142) * setup playwright testing * fix deps and update readme * add playwright to ensure browsers and deps are installed * test npx command playwright * add pretest hook to test * add dev specific testing command so we can run ci pretest * point to the right directory chris...
…28142) * setup playwright testing * fix deps and update readme * add playwright to ensure browsers and deps are installed * test npx command playwright * add pretest hook to test * add dev specific testing command so we can run ci pretest * point to the right directory chris...
…28142) * setup playwright testing * fix deps and update readme * add playwright to ensure browsers and deps are installed * test npx command playwright * add pretest hook to test * add dev specific testing command so we can run ci pretest * point to the right directory chris...
…28142) * setup playwright testing * fix deps and update readme * add playwright to ensure browsers and deps are installed * test npx command playwright * add pretest hook to test * add dev specific testing command so we can run ci pretest * point to the right directory chris...
…28142) * setup playwright testing * fix deps and update readme * add playwright to ensure browsers and deps are installed * test npx command playwright * add pretest hook to test * add dev specific testing command so we can run ci pretest * point to the right directory chris...
…28142) * setup playwright testing * fix deps and update readme * add playwright to ensure browsers and deps are installed * test npx command playwright * add pretest hook to test * add dev specific testing command so we can run ci pretest * point to the right directory chris...
…28142) * setup playwright testing * fix deps and update readme * add playwright to ensure browsers and deps are installed * test npx command playwright * add pretest hook to test * add dev specific testing command so we can run ci pretest * point to the right directory chris...
…28142) * setup playwright testing * fix deps and update readme * add playwright to ensure browsers and deps are installed * test npx command playwright * add pretest hook to test * add dev specific testing command so we can run ci pretest * point to the right directory chris...
…28142) * setup playwright testing * fix deps and update readme * add playwright to ensure browsers and deps are installed * test npx command playwright * add pretest hook to test * add dev specific testing command so we can run ci pretest * point to the right directory chris...
…icrosoft#28142) * setup playwright testing * fix deps and update readme * add playwright to ensure browsers and deps are installed * test npx command playwright * add pretest hook to test * add dev specific testing command so we can run ci pretest * point to the right directory chris...
…28142) * setup playwright testing * fix deps and update readme * add playwright to ensure browsers and deps are installed * test npx command playwright * add pretest hook to test * add dev specific testing command so we can run ci pretest * point to the right directory chris...
Previous Behavior
No tests
New Behavior
Tests!
Related Issue(s)