feat(web-components): update to use foundation export paths and add extensions for package exports #28912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamedmansour
approved these changes
Aug 18, 2023
| @@ -1,4 +1,4 @@ | |||
| import { ValuesOf } from '@microsoft/fast-foundation'; | |||
| import type { ValuesOf } from '@microsoft/fast-foundation/utilities.js'; | |||
There was a problem hiding this comment.
What is the motivation behind switching from the default export to the mapped exports here? Bundle size or build fix or anything else?
There was a problem hiding this comment.
For types specifically it was just convention to match other scenarios where we are bringing things in. For non-type imports we want to ensure we are exporting pure es modules.
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8e94e5c9041b143e43af851db35a7d1fc74aa33b (build) |
miroslavstastny
approved these changes
Aug 18, 2023
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1f37e6f:
|
chrisdholt
force-pushed
the
users/chhol/update-to-use-foundation-export-paths-and-add-extensions
branch
6 times, most recently
from
9ea8750
to
a0de5cd
Compare
…tensions to web component export paths
chrisdholt
force-pushed
the
users/chhol/update-to-use-foundation-export-paths-and-add-extensions
branch
from
a0de5cd
to
4015aae
Compare
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
chrisdholt
force-pushed
the
users/chhol/update-to-use-foundation-export-paths-and-add-extensions
branch
from
c0f26fb
to
3033b1a
Compare
chrisdholt
force-pushed
the
users/chhol/update-to-use-foundation-export-paths-and-add-extensions
branch
from
3033b1a
to
1f37e6f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
chrisdholt
deleted the
users/chhol/update-to-use-foundation-export-paths-and-add-extensions
branch
chrisdholt
added a commit
that referenced
this pull request
Apr 29, 2024
…xtensions for package exports (#28912) * update core component paths to use foundation export paths and add extensions to web component export paths * change files * update rollup to use esbuild and support package exports * update to use esm package exports * dedupe deps * fix order of alias resolutions * update paths for start end and patterns * fix extension order for web component vr tests * update module resolution for web component vr tests * resolve tsx to js as well
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
…xtensions for package exports (microsoft#28912) * update core component paths to use foundation export paths and add extensions to web component export paths * change files * update rollup to use esbuild and support package exports * update to use esm package exports * dedupe deps * fix order of alias resolutions * update paths for start end and patterns * fix extension order for web component vr tests * update module resolution for web component vr tests * resolve tsx to js as well
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
…xtensions for package exports (microsoft#28912) * update core component paths to use foundation export paths and add extensions to web component export paths * change files * update rollup to use esbuild and support package exports * update to use esm package exports * dedupe deps * fix order of alias resolutions * update paths for start end and patterns * fix extension order for web component vr tests * update module resolution for web component vr tests * resolve tsx to js as well
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
…xtensions for package exports (microsoft#28912) * update core component paths to use foundation export paths and add extensions to web component export paths * change files * update rollup to use esbuild and support package exports * update to use esm package exports * dedupe deps * fix order of alias resolutions * update paths for start end and patterns * fix extension order for web component vr tests * update module resolution for web component vr tests * resolve tsx to js as well
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
…xtensions for package exports (#28912) * update core component paths to use foundation export paths and add extensions to web component export paths * change files * update rollup to use esbuild and support package exports * update to use esm package exports * dedupe deps * fix order of alias resolutions * update paths for start end and patterns * fix extension order for web component vr tests * update module resolution for web component vr tests * resolve tsx to js as well
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
…xtensions for package exports (#28912) * update core component paths to use foundation export paths and add extensions to web component export paths * change files * update rollup to use esbuild and support package exports * update to use esm package exports * dedupe deps * fix order of alias resolutions * update paths for start end and patterns * fix extension order for web component vr tests * update module resolution for web component vr tests * resolve tsx to js as well
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
…xtensions for package exports (#28912) * update core component paths to use foundation export paths and add extensions to web component export paths * change files * update rollup to use esbuild and support package exports * update to use esm package exports * dedupe deps * fix order of alias resolutions * update paths for start end and patterns * fix extension order for web component vr tests * update module resolution for web component vr tests * resolve tsx to js as well
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
…xtensions for package exports (#28912) * update core component paths to use foundation export paths and add extensions to web component export paths * change files * update rollup to use esbuild and support package exports * update to use esm package exports * dedupe deps * fix order of alias resolutions * update paths for start end and patterns * fix extension order for web component vr tests * update module resolution for web component vr tests * resolve tsx to js as well
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
…xtensions for package exports (#28912) * update core component paths to use foundation export paths and add extensions to web component export paths * change files * update rollup to use esbuild and support package exports * update to use esm package exports * dedupe deps * fix order of alias resolutions * update paths for start end and patterns * fix extension order for web component vr tests * update module resolution for web component vr tests * resolve tsx to js as well
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
…xtensions for package exports (#28912) * update core component paths to use foundation export paths and add extensions to web component export paths * change files * update rollup to use esbuild and support package exports * update to use esm package exports * dedupe deps * fix order of alias resolutions * update paths for start end and patterns * fix extension order for web component vr tests * update module resolution for web component vr tests * resolve tsx to js as well
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
…xtensions for package exports (#28912) * update core component paths to use foundation export paths and add extensions to web component export paths * change files * update rollup to use esbuild and support package exports * update to use esm package exports * dedupe deps * fix order of alias resolutions * update paths for start end and patterns * fix extension order for web component vr tests * update module resolution for web component vr tests * resolve tsx to js as well
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
…xtensions for package exports (#28912) * update core component paths to use foundation export paths and add extensions to web component export paths * change files * update rollup to use esbuild and support package exports * update to use esm package exports * dedupe deps * fix order of alias resolutions * update paths for start end and patterns * fix extension order for web component vr tests * update module resolution for web component vr tests * resolve tsx to js as well
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
…xtensions for package exports (#28912) * update core component paths to use foundation export paths and add extensions to web component export paths * change files * update rollup to use esbuild and support package exports * update to use esm package exports * dedupe deps * fix order of alias resolutions * update paths for start end and patterns * fix extension order for web component vr tests * update module resolution for web component vr tests * resolve tsx to js as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
We previously imported from the root of fast-foundation for most core component pathing. This changes to primarily leverage specific package export paths when available. We also previously did not include file extensions for the fluent web component package exports which is problematic for import maps.
See here for more: https://nodejs.dev/en/api/v18/packages/#extensions-in-subpaths
New Behavior
Uses package exports where we can. Adds extensions to component specific package exports.