Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(switch): Add screenshot tests #28930

Merged

Conversation

miroslavstastny
Copy link
Member

Add screenshot tests for fluent-switch

@miroslavstastny miroslavstastny added the Fluent UI WC (v3) Fluent UI Web Component V3 label Aug 21, 2023
@miroslavstastny miroslavstastny requested a review from a team as a code owner August 21, 2023 22:52
@miroslavstastny miroslavstastny self-assigned this Aug 21, 2023
@github-actions github-actions bot added this to the August Project Cycle Q4 2023 milestone Aug 21, 2023
@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 2f59582504dca05054a49aa2d47a483356fb6a69

@@ -0,0 +1,82 @@
import * as React from 'react';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots

Switch 34 screenshots
Image Name Diff(in Pixels) Image Type
Switch.Checked - Dark Mode.hover.chromium.png 0 Added
Switch.Checked - Dark Mode.normal.chromium.png 0 Added
Switch.Checked - RTL.hover.chromium.png 0 Added
Switch.Checked - RTL.normal.chromium.png 0 Added
Switch.Checked.hover.chromium.png 0 Added
Switch.Checked.normal.chromium.png 0 Added
Switch.Default - Dark Mode.hover.chromium.png 0 Added
Switch.Default - Dark Mode.normal.chromium.png 0 Added
Switch.Default - RTL.hover.chromium.png 0 Added
Switch.Default - RTL.normal.chromium.png 0 Added
Switch.Default.hover.chromium.png 0 Added
Switch.Default.normal.chromium.png 0 Added
Switch.Disabled - Dark Mode.hover.chromium.png 0 Added
Switch.Disabled - Dark Mode.normal.chromium.png 0 Added
Switch.Disabled - RTL.hover.chromium.png 0 Added
Switch.Disabled - RTL.normal.chromium.png 0 Added
Switch.Disabled Checked - Dark Mode.hover.chromium.png 0 Added
Switch.Disabled Checked - Dark Mode.normal.chromium.png 0 Added
Switch.Disabled Checked.hover.chromium.png 0 Added
Switch.Disabled Checked.normal.chromium.png 0 Added
Switch.Disabled.hover.chromium.png 0 Added
Switch.Disabled.normal.chromium.png 0 Added
Switch.Label Above - RTL.hover.chromium.png 0 Added
Switch.Label Above - RTL.normal.chromium.png 0 Added
Switch.Label Above.hover.chromium.png 0 Added
Switch.Label Above.normal.chromium.png 0 Added
Switch.Label After - RTL.hover.chromium.png 0 Added
Switch.Label After - RTL.normal.chromium.png 0 Added
Switch.Label After.hover.chromium.png 0 Added
Switch.Label After.normal.chromium.png 0 Added
Switch.Label Before - RTL.hover.chromium.png 0 Added
Switch.Label Before - RTL.normal.chromium.png 0 Added
Switch.Label Before.hover.chromium.png 0 Added
Switch.Label Before.normal.chromium.png 0 Added

@size-auditor
Copy link

size-auditor bot commented Aug 21, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2f59582504dca05054a49aa2d47a483356fb6a69 (build)

@miroslavstastny
Copy link
Member Author

RTL issue: #28933

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 673f618:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@miroslavstastny miroslavstastny merged commit a00dd1d into microsoft:web-components-v3 Aug 21, 2023
25 checks passed
@miroslavstastny miroslavstastny deleted the chore/vr-switch branch August 21, 2023 23:09
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 29, 2024
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 29, 2024
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 30, 2024
radium-v pushed a commit that referenced this pull request Apr 30, 2024
radium-v pushed a commit that referenced this pull request May 2, 2024
radium-v pushed a commit that referenced this pull request May 2, 2024
radium-v pushed a commit that referenced this pull request May 2, 2024
radium-v pushed a commit that referenced this pull request May 3, 2024
radium-v pushed a commit that referenced this pull request May 6, 2024
radium-v pushed a commit that referenced this pull request May 6, 2024
radium-v pushed a commit that referenced this pull request May 8, 2024
radium-v pushed a commit that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI WC (v3) Fluent UI Web Component V3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants