chore(tabs): Add screenshot tests #28931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
📊 Bundle size report🤖 This report was generated against 2f59582504dca05054a49aa2d47a483356fb6a69 |
fabricteam
reviewed
Aug 21, 2023
| @@ -0,0 +1,136 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots
Tabs 36 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Tabs.Appearance Subtle.hover.chromium.png | 0 | Added |
| Tabs.Appearance Subtle.normal.chromium.png | 0 | Added |
| Tabs.Appearance Transparent.hover.chromium.png | 0 | Added |
| Tabs.Appearance Transparent.normal.chromium.png | 0 | Added |
| Tabs.Default - Dark Mode.normal.chromium.png | 0 | Added |
| Tabs.Default - RTL.normal.chromium.png | 0 | Added |
| Tabs.Default.normal.chromium.png | 0 | Added |
| Tabs.Disabled - Dark Mode.normal.chromium.png | 0 | Added |
| Tabs.Disabled.normal.chromium.png | 0 | Added |
| Tabs.Horizontal.normal.chromium.png | 0 | Added |
| Tabs.Navigation - RTL.2nd tab click.chromium.png | 0 | Added |
| Tabs.Navigation - RTL.hover.chromium.png | 0 | Added |
| Tabs.Navigation - RTL.normal.chromium.png | 0 | Added |
| Tabs.Navigation - RTL.right arrow.chromium.png | 0 | Added |
| Tabs.Navigation Over Disabled Item.2nd tab click.chromium.png | 0 | Added |
| Tabs.Navigation Over Disabled Item.hover.chromium.png | 0 | Added |
| Tabs.Navigation Over Disabled Item.normal.chromium.png | 0 | Added |
| Tabs.Navigation Over Disabled Item.right arrow.chromium.png | 0 | Added |
| Tabs.Navigation Vertical.chromium.png | 0 | Added |
| Tabs.Navigation.2nd tab click.chromium.png | 0 | Added |
| Tabs.Navigation.down arrow.chromium.png | 0 | Added |
| Tabs.Navigation.hover.chromium.png | 0 | Added |
| Tabs.Navigation.normal.chromium.png | 0 | Added |
| Tabs.Size Large - Dark Mode.normal.chromium.png | 0 | Added |
| Tabs.Size Large Vertical - Dark Mode.normal.chromium.png | 0 | Added |
| Tabs.Size Large Vertical.normal.chromium.png | 0 | Added |
| Tabs.Size Large.normal.chromium.png | 0 | Added |
| Tabs.Size Medium - Dark Mode.normal.chromium.png | 0 | Added |
| Tabs.Size Medium Vertical - Dark Mode.normal.chromium.png | 0 | Added |
| Tabs.Size Medium Vertical.normal.chromium.png | 0 | Added |
| Tabs.Size Medium.normal.chromium.png | 0 | Added |
| Tabs.Size Small - Dark Mode.normal.chromium.png | 0 | Added |
| Tabs.Size Small Vertical - Dark Mode.normal.chromium.png | 0 | Added |
| Tabs.Size Small Vertical.normal.chromium.png | 0 | Added |
| Tabs.Size Small.normal.chromium.png | 0 | Added |
| Tabs.Vertical.normal.chromium.png | 0 | Added |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 2f59582504dca05054a49aa2d47a483356fb6a69 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9a25b9e:
|
|
Keyboard navigation not flipped in RTL: #28935 |
miroslavstastny
merged commit 6532f2f
into
microsoft:web-components-v3
25 checks passed
chrisdholt
pushed a commit
that referenced
this pull request
Apr 29, 2024
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add screenshot tests for
fluent-tabs,fluent-tabandfluent-tab-panel