feat(web-components): add explicit exports for design tokens and add package export path for theme utills #28952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report🤖 This report was generated against eee4a63c0af9e2c51b30477053c4d990cd331405 |
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: eee4a63c0af9e2c51b30477053c4d990cd331405 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4f118b1:
|
| @@ -1,2 +1,387 @@ | |||
| export * from './design-tokens.js'; | |||
| export { | |||
There was a problem hiding this comment.
we should eventually add a test which verifies that this file exports everything what is exported from design-tokens
miroslavstastny
approved these changes
Aug 22, 2023
chrisdholt
added a commit
that referenced
this pull request
Apr 29, 2024
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Certain bundlers such as ESBuild don't tree shake two levels of
export *instances, so all tokens are included.New Behavior
Introduces named exports and package export path for convenience + better esm support.
Related Issue(s)
n/a