Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web components V3 - updating disclaimer message on storybook intro page #29924

Conversation

bearcat-msft
Copy link
Contributor

@bearcat-msft bearcat-msft marked this pull request as ready for review November 27, 2023 19:45
@bearcat-msft bearcat-msft requested a review from a team as a code owner November 27, 2023 20:16
@fabricteam
Copy link
Collaborator

fabricteam commented Nov 27, 2023

📊 Bundle size report

🤖 This report was generated against 177242e84f7eb5a5c29b75a89d7935d2ee320f3f

@@ -0,0 +1,7 @@
{
Copy link
Collaborator

@fabricteam fabricteam Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots

Switch 2 screenshots
Image Name Diff(in Pixels) Image Type
Switch.Checked - RTL.hover.chromium.png 104 Changed
Switch.Checked - RTL.normal.chromium.png 97 Changed

Copy link

size-auditor bot commented Nov 27, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 177242e84f7eb5a5c29b75a89d7935d2ee320f3f (build)

Copy link

codesandbox-ci bot commented Nov 27, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a2ad772:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@Falkicon
Copy link
Contributor

We would like to remove the part about being production ready as well. The whole notice can read something like "While in Beta, breaking changes may be made based on feedback from users."

@bearcat-msft bearcat-msft changed the title Bearcat msft/disclaimer Web components V3 - updating disclaimer message on storybook intro page Nov 29, 2023
@miroslavstastny miroslavstastny merged commit ebe7e48 into microsoft:web-components-v3 Nov 30, 2023
26 checks passed
chrisdholt pushed a commit that referenced this pull request Apr 29, 2024
…ge (#29924)

* updating disclaimer

* updating storybook disclaimer

* tweaking disclaimer
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 29, 2024
…ge (microsoft#29924)

* updating disclaimer

* updating storybook disclaimer

* tweaking disclaimer
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 29, 2024
…ge (microsoft#29924)

* updating disclaimer

* updating storybook disclaimer

* tweaking disclaimer
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 30, 2024
…ge (microsoft#29924)

* updating disclaimer

* updating storybook disclaimer

* tweaking disclaimer
radium-v pushed a commit that referenced this pull request Apr 30, 2024
…ge (#29924)

* updating disclaimer

* updating storybook disclaimer

* tweaking disclaimer
radium-v pushed a commit that referenced this pull request May 2, 2024
…ge (#29924)

* updating disclaimer

* updating storybook disclaimer

* tweaking disclaimer
radium-v pushed a commit that referenced this pull request May 2, 2024
…ge (#29924)

* updating disclaimer

* updating storybook disclaimer

* tweaking disclaimer
radium-v pushed a commit that referenced this pull request May 2, 2024
…ge (#29924)

* updating disclaimer

* updating storybook disclaimer

* tweaking disclaimer
radium-v pushed a commit that referenced this pull request May 3, 2024
…ge (#29924)

* updating disclaimer

* updating storybook disclaimer

* tweaking disclaimer
radium-v pushed a commit that referenced this pull request May 6, 2024
…ge (#29924)

* updating disclaimer

* updating storybook disclaimer

* tweaking disclaimer
radium-v pushed a commit that referenced this pull request May 6, 2024
…ge (#29924)

* updating disclaimer

* updating storybook disclaimer

* tweaking disclaimer
radium-v pushed a commit that referenced this pull request May 8, 2024
…ge (#29924)

* updating disclaimer

* updating storybook disclaimer

* tweaking disclaimer
radium-v pushed a commit that referenced this pull request May 10, 2024
…ge (#29924)

* updating disclaimer

* updating storybook disclaimer

* tweaking disclaimer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants