fix: updates should be synchronous in unit tests #30014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React testing platforms will often output errors when state updates happen outside `act` Since there is nothing obvious to wait for we just avoid debouncing in unit test environments. Adds tests to make sure that the synchronous update only happens in test environment
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 64 | 67 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 646 | 680 | 5000 | |
| Button | mount | 335 | 315 | 5000 | |
| Field | mount | 1124 | 1134 | 5000 | |
| FluentProvider | mount | 701 | 713 | 5000 | |
| FluentProviderWithTheme | mount | 85 | 89 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 64 | 67 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 82 | 89 | 10 | |
| MakeStyles | mount | 858 | 873 | 50000 | |
| Persona | mount | 1806 | 1722 | 5000 | |
| SpinButton | mount | 1391 | 1386 | 5000 |
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2bc9522:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a704aaca45c895f5c4b9e22d1ea5e731fe679107 (build) |
layershifter
reviewed
Dec 7, 2023
packages/react-components/react-overflow/src/components/Overflow.test.tsx
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React testing platforms will often output errors when state updates happen outside
actSince there is nothing obvious to wait for we just avoid debouncing in unit test environments.Adds tests to make sure that the synchronous update only happens in test environment