-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 2:1 spacing in vertical bar charts with string x-axis #30192
Conversation
📊 Bundle size report🤖 This report was generated against b1f669dceb6855bdd01d9e7be7764687aa161cf5 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
packages/react-charting/src/components/VerticalBarChart/VerticalBarChart.base.tsx
Outdated
Show resolved
Hide resolved
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 99e1128925fa5863a99e311884cc2c710c2606bd (build) |
Can we keep the existing functionality as default behavior if the user does not use the new props. |
@AtishayMsft To keep the existing functionality as default behavior, we will have to make following changes:
|
packages/react-charting/src/components/VerticalBarChart/VerticalBarChart.types.ts
Outdated
Show resolved
Hide resolved
packages/react-charting/src/components/VerticalBarChart/VerticalBarChart.base.tsx
Show resolved
Hide resolved
packages/react-charting/src/components/VerticalStackedBarChart/VerticalStackedBarChart.base.tsx
Show resolved
Hide resolved
packages/react-charting/src/components/VerticalBarChart/VerticalBarChart.types.ts
Show resolved
Hide resolved
Another bug: On selecting the xAxisOuterPadding field, the bar labels are disappearing. |
For more information, see RFC: Fix 2:1 spacing