-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DataGrid selection performance improvement #30288
Merged
ling1726
merged 2 commits into
microsoft:master
from
ling1726:fix/data-grid-selection-perf
Jan 12, 2024
Merged
fix: DataGrid selection performance improvement #30288
ling1726
merged 2 commits into
microsoft:master
from
ling1726:fix/data-grid-selection-perf
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves context selector usage and memoization so that a selected row will only re-render itself and not the entire grid. Before: After: ![image](https://github.com/microsoft/fluentui/assets/20744592/38490bbc-3c63-4247-977b-7bb7883f31bd) Fixes partially microsoft#29908
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 623 | 619 | 5000 | |
Button | mount | 306 | 303 | 5000 | |
Field | mount | 1135 | 1140 | 5000 | |
FluentProvider | mount | 697 | 716 | 5000 | |
FluentProviderWithTheme | mount | 81 | 81 | 10 | |
FluentProviderWithTheme | virtual-rerender | 65 | 65 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 82 | 81 | 10 | |
MakeStyles | mount | 850 | 848 | 50000 | |
Persona | mount | 1715 | 1671 | 5000 | |
SpinButton | mount | 1430 | 1388 | 5000 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dd9f6ea:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 38b6a76ef54c02106cf10d989922fbcc9d2cfb31 (build) |
🕵 fluentuiv9 No visual regressions between this PR and main |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
bsunderhus
approved these changes
Jan 12, 2024
📊 Bundle size reportUnchanged fixtures
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves context selector usage and memoization so that a selected row will only re-render itself and not the entire grid.
Before:
After:
Fixes #29908 when #30289