feat(eslint-rules): add `consistent-callback-type` rule for event callback typing for react-components and enable it in all v9 packages #30293

YuanboXue-Amber · 2024-01-11T16:28:17Z

Background:

We agreed on new event type for v9 callbacks.

Below types will be exported from react-utilities as helpers:

export type EventData<Type extends string, TEvent> =
  | { type: undefined; event: React.SyntheticEvent | Event }
  | { type: Type; event: TEvent };

export type EventHandler<TData extends EventData<string, unknown>> = (
  ev: React.SyntheticEvent | Event,
  data: TData,
) => void;

And they will be used for typing callbacks:

type MyComponentElement = HTMLElement;

type OnSomeEventData = (
  | EventData<'click', React.MouseEvent<MyComponentElement>>
  | EventData<'focus', React.FocusEvent<MyComponentElement>>
) & {
  open: boolean;
};

type SomeProps = {
  onSomeEvent?: EventHandler<OnSomeEventData>;
};

detailed proposal: https://github.com/microsoft/fluentui/blob/master/rfcs/react-components/convergence/event-handlers-event-type.md

This PR does:

export the helper types as mentioned above
create eslint rule consistent-callback-type, disable this rule for existing callbacks.

Related issue

#30372

fabricteam · 2024-01-11T16:39:42Z

Perf Analysis (`@fluentui/react-components`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
FluentProviderWithTheme	virtual-rerender	68	59	10	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	636	629	5000
Button	mount	300	309	5000
Field	mount	1141	1094	5000
FluentProvider	mount	693	695	5000
FluentProviderWithTheme	mount	81	81	10
FluentProviderWithTheme	virtual-rerender	68	59	10	Possible regression
FluentProviderWithTheme	virtual-rerender-with-unmount	78	73	10
MakeStyles	mount	857	848	50000
Persona	mount	1743	1692	5000
SpinButton	mount	1378	1342	5000

codesandbox-ci · 2024-01-11T16:41:07Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a704db8:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2024-01-11T16:43:27Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ChatDuplicateMessagesPerf.default	167	145	1.15:1
LayoutMinimalPerf.default	218	196	1.11:1
ButtonMinimalPerf.default	92	86	1.07:1
FlexMinimalPerf.default	148	140	1.06:1
ListWith60ListItems.default	379	359	1.06:1
PortalMinimalPerf.default	86	81	1.06:1
TreeMinimalPerf.default	510	483	1.06:1
CarouselMinimalPerf.default	269	255	1.05:1
DatepickerMinimalPerf.default	3940	3762	1.05:1
DropdownManyItemsPerf.default	397	377	1.05:1
ProviderMinimalPerf.default	205	196	1.05:1
AlertMinimalPerf.default	165	159	1.04:1
CardMinimalPerf.default	307	296	1.04:1
FormMinimalPerf.default	231	222	1.04:1
RosterPerf.default	1589	1522	1.04:1
RadioGroupMinimalPerf.default	265	255	1.04:1
ButtonSlotsPerf.default	327	317	1.03:1
CheckboxMinimalPerf.default	1166	1134	1.03:1
ListMinimalPerf.default	316	308	1.03:1
MenuButtonMinimalPerf.default	995	969	1.03:1
TextAreaMinimalPerf.default	292	284	1.03:1
AccordionMinimalPerf.default	88	86	1.02:1
AttachmentSlotsPerf.default	648	633	1.02:1
BoxMinimalPerf.default	191	187	1.02:1
DividerMinimalPerf.default	209	205	1.02:1
HeaderMinimalPerf.default	210	205	1.02:1
ItemLayoutMinimalPerf.default	719	702	1.02:1
ProviderMergeThemesPerf.default	655	645	1.02:1
SplitButtonMinimalPerf.default	2327	2282	1.02:1
CustomToolbarPrototype.default	1510	1481	1.02:1
TreeWith60ListItems.default	91	89	1.02:1
AttachmentMinimalPerf.default	84	83	1.01:1
HeaderSlotsPerf.default	475	472	1.01:1
ImageMinimalPerf.default	224	222	1.01:1
MenuMinimalPerf.default	516	512	1.01:1
RefMinimalPerf.default	108	107	1.01:1
SliderMinimalPerf.default	761	756	1.01:1
StatusMinimalPerf.default	379	376	1.01:1
AvatarMinimalPerf.default	109	109	1:1
ChatWithPopoverPerf.default	200	201	1:1
DialogMinimalPerf.default	449	449	1:1
EmbedMinimalPerf.default	1872	1871	1:1
InputMinimalPerf.default	549	547	1:1
TextMinimalPerf.default	202	201	1:1
AnimationMinimalPerf.default	296	300	0.99:1
DropdownMinimalPerf.default	1438	1453	0.99:1
ListCommonPerf.default	406	410	0.99:1
ReactionMinimalPerf.default	208	211	0.99:1
SegmentMinimalPerf.default	187	188	0.99:1
TableManyItemsPerf.default	1113	1123	0.99:1
TableMinimalPerf.default	239	241	0.99:1
ToolbarMinimalPerf.default	541	548	0.99:1
TooltipMinimalPerf.default	1268	1283	0.99:1
ButtonOverridesMissPerf.default	648	663	0.98:1
LoaderMinimalPerf.default	184	188	0.98:1
SkeletonMinimalPerf.default	199	203	0.98:1
GridMinimalPerf.default	190	196	0.97:1
PopupMinimalPerf.default	349	361	0.97:1
LabelMinimalPerf.default	209	218	0.96:1
IconMinimalPerf.default	395	411	0.96:1
ChatMinimalPerf.default	425	446	0.95:1
ListNestedPerf.default	318	338	0.94:1
VideoMinimalPerf.default	429	457	0.94:1

fabricteam · 2024-01-11T16:48:10Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`510 B` `328 B`
`global-context` createContextSelector	`537 B` `339 B`
`keyboard-key` keyboard-key package	`3.746 kB` `1.928 kB`
`priority-overflow` createOverflowManager	`4.447 kB` `1.853 kB`
`react` ActivityItem	`68.833 kB` `22.613 kB`
`react` Announced	`36.473 kB` `12.628 kB`
`react` Autofill	`15.365 kB` `4.743 kB`
`react` Breadcrumb	`196.083 kB` `58.757 kB`
`react` Button	`190.127 kB` `55.019 kB`
`react` ButtonGrid	`175.918 kB` `53.25 kB`
`react` Calendar	`118.756 kB` `36.101 kB`
`react` Callout	`80.866 kB` `26.564 kB`
`react` Check	`51.062 kB` `17.152 kB`
`react` Checkbox	`57.791 kB` `19.17 kB`
`react` ChoiceGroup	`63.339 kB` `20.824 kB`
`react` ChoiceGroupOption	`56.601 kB` `18.695 kB`
`react` Coachmark	`89.704 kB` `28.407 kB`
`react` Color	`7.737 kB` `3.106 kB`
`react` ColorPicker	`129.984 kB` `40.589 kB`
`react` ComboBox	`245.355 kB` `70.51 kB`
`react` CommandBar	`197.362 kB` `58.46 kB`
`react` ContextualMenu	`150.967 kB` `46.982 kB`
`react` DatePicker	`180.203 kB` `54.911 kB`
`react` DateTimeUtilities	`5.244 kB` `1.849 kB`
`react` DetailsList	`225.886 kB` `64.647 kB`
`react` Dialog	`205.294 kB` `61.428 kB`
`react` Divider	`17.63 kB` `6.234 kB`
`react` DocumentCard	`211.08 kB` `62.793 kB`
`react` DragDrop	`8.343 kB` `2.724 kB`
`react` DraggableZone	`33.345 kB` `11.166 kB`
`react` Dropdown	`227.732 kB` `66.867 kB`
`react` ExtendedPicker	`94.987 kB` `27.297 kB`
`react` Fabric	`39.75 kB` `13.688 kB`
`react` Facepile	`205.992 kB` `61.67 kB`
`react` FloatingPicker	`236.233 kB` `67.368 kB`
`react` FocusTrapZone	`15.831 kB` `5.54 kB`
`react` FocusZone	`53.259 kB` `16.869 kB`
`react` Grid	`175.918 kB` `53.25 kB`
`react` GroupedList	`131.636 kB` `39.657 kB`
`react` GroupedListV2	`119.324 kB` `36.822 kB`
`react` HoverCard	`93.735 kB` `29.778 kB`
`react` Icon	`49.74 kB` `16.603 kB`
`react` Icons	`65.829 kB` `24.212 kB`
`react` Image	`44.79 kB` `15.024 kB`
`react` Keytip	`78.588 kB` `25.825 kB`
`react` KeytipData	`13.585 kB` `4.418 kB`
`react` KeytipLayer	`100.422 kB` `31.128 kB`
`react` Keytips	`103.175 kB` `32.07 kB`
`react` Label	`36.347 kB` `12.639 kB`
`react` Layer	`45.683 kB` `15.585 kB`
`react` Link	`37.673 kB` `12.993 kB`
`react` List	`38.136 kB` `12.004 kB`
`react` MarqueeSelection	`72.119 kB` `21.676 kB`
`react` MessageBar	`184.707 kB` `55.523 kB`
`react` Modal	`90.409 kB` `29.213 kB`
`react` Nav	`183.442 kB` `55.093 kB`
`react` OverflowSet	`31.044 kB` `10.593 kB`
`react` Overlay	`38.784 kB` `13.401 kB`
`react` Panel	`194.946 kB` `58.34 kB`
`react` Persona	`111.705 kB` `35.58 kB`
`react` PersonaCoin	`111.705 kB` `35.58 kB`
`react` PersonaPresence	`55.928 kB` `18.715 kB`
`react` Pickers	`287.603 kB` `80.607 kB`
`react` Pivot	`184.252 kB` `55.823 kB`
`react` Popup	`12.032 kB` `4.114 kB`
`react` Positioning	`21.821 kB` `7.334 kB`
`react` PositioningContainer	`70.754 kB` `22.84 kB`
`react` ProgressIndicator	`37.498 kB` `12.906 kB`
`react` Rating	`78.989 kB` `25.18 kB`
`react` ResizeGroup	`13.286 kB` `4.365 kB`
`react` ResponsiveMode	`8.078 kB` `2.95 kB`
`react` ScrollablePane	`53.538 kB` `17.113 kB`
`react` SearchBox	`182.982 kB` `55.1 kB`
`react` SelectableOption	`724 B` `413 B`
`react` SelectedItemsList	`226.659 kB` `66.321 kB`
`react` Selection	`41.202 kB` `11.839 kB`
`react` Separator	`33.397 kB` `11.529 kB`
`react` Shimmer	`47.265 kB` `15.632 kB`
`react` ShimmeredDetailsList	`236.654 kB` `67.42 kB`
`react` Slider	`55.575 kB` `18.574 kB`
`react` SpinButton	`186.661 kB` `56.205 kB`
`react` Spinner	`39.691 kB` `13.815 kB`
`react` Stack	`40.761 kB` `13.931 kB`
`react` Sticky	`32.064 kB` `10.324 kB`
`react` Styling	`44.812 kB` `14.688 kB`
`react` SwatchColorPicker	`186.166 kB` `56.724 kB`
`react` TeachingBubble	`200.004 kB` `59.345 kB`
`react` Text	`35.931 kB` `12.486 kB`
`react` TextField	`78.587 kB` `24.642 kB`
`react` Theme	`42.456 kB` `13.773 kB`
`react` ThemeGenerator	`12.34 kB` `4.106 kB`
`react` TimePicker	`235.197 kB` `68.29 kB`
`react` Toggle	`44.17 kB` `15.346 kB`
`react` Tooltip	`84.225 kB` `27.277 kB`
`react` Utilities	`71.851 kB` `21.843 kB`
`react` Viewport	`22.945 kB` `7.292 kB`
`react` WeeklyDayPicker	`98.762 kB` `30.828 kB`
`react` WindowProvider	`1.059 kB` `541 B`
`react-accordion` Accordion (including children components)	`100.12 kB` `30.421 kB`
`react-alert` Alert	`83.737 kB` `23.474 kB`
`react-avatar` Avatar	`50.175 kB` `15.944 kB`
`react-avatar` AvatarGroup	`19.704 kB` `7.796 kB`
`react-avatar` AvatarGroupItem	`64.831 kB` `20.274 kB`
`react-badge` Badge	`26.905 kB` `8.729 kB`
`react-badge` CounterBadge	`27.806 kB` `9.024 kB`
`react-badge` PresenceBadge	`25.311 kB` `9.306 kB`
`react-button` Button	`39.513 kB` `11.169 kB`
`react-button` CompoundButton	`46.874 kB` `12.661 kB`
`react-button` MenuButton	`44.292 kB` `12.542 kB`
`react-button` SplitButton	`52.306 kB` `14.134 kB`
`react-button` ToggleButton	`56.559 kB` `13.068 kB`
`react-calendar-compat` Calendar Compat	`152.029 kB` `39.809 kB`
`react-card` Card - All	`101.55 kB` `28.92 kB`
`react-card` Card	`96.373 kB` `27.403 kB`
`react-card` CardFooter	`13.064 kB` `5.385 kB`
`react-card` CardHeader	`15.307 kB` `6.143 kB`
`react-card` CardPreview	`14.015 kB` `5.752 kB`
`react-checkbox` Checkbox	`35.65 kB` `12.076 kB`
`react-combobox` Combobox (including child components)	`98.361 kB` `31.717 kB`
`react-combobox` Dropdown (including child components)	`99.582 kB` `31.715 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`70.688 kB` `20.464 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`217.082 kB` `61.913 kB`
`react-components` react-components: FluentProvider & webLightTheme	`43.173 kB` `14.298 kB`
`react-datepicker-compat` DatePicker Compat	`224.131 kB` `62.802 kB`
`react-dialog` Dialog (including children components)	`100.865 kB` `29.91 kB`
`react-divider` Divider	`20.82 kB` `7.763 kB`
`react-field` Field	`22.544 kB` `8.61 kB`
`react-image` Image	`15.736 kB` `6.228 kB`
`react-infobutton` InfoButton	`138.593 kB` `43.364 kB`
`react-infobutton` InfoLabel	`142.394 kB` `44.604 kB`
`react-input` Input	`26.887 kB` `9.118 kB`
`react-jsx-runtime` Classic Pragma	`1.057 kB` `530 B`
`react-jsx-runtime` JSX Dev Runtime	`3.783 kB` `1.648 kB`
`react-jsx-runtime` JSX Runtime	`4.377 kB` `1.881 kB`
`react-label` Label	`14.266 kB` `5.828 kB`
`react-link` Link	`17.082 kB` `6.911 kB`
`react-menu` Menu (including children components)	`149.37 kB` `45.493 kB`
`react-menu` Menu (including selectable components)	`152.056 kB` `46.004 kB`
`react-message-bar` MessageBar (all components)	`25.566 kB` `9.131 kB`
`react-northstar` Accordion	`85.357 kB` `26.509 kB`
`react-northstar` Alert	`87.425 kB` `26.91 kB`
`react-northstar` Animation	`55.304 kB` `17.834 kB`
`react-northstar` Attachment	`86.819 kB` `26.7 kB`
`react-northstar` Avatar	`80.254 kB` `24.634 kB`
`react-northstar` Box	`75.223 kB` `23.814 kB`
`react-northstar` Breadcrumb	`79.889 kB` `24.707 kB`
`react-northstar` Button	`83.135 kB` `25.957 kB`
`react-northstar` Card	`82.674 kB` `25.027 kB`
`react-northstar` Carousel	`105.15 kB` `31.882 kB`
`react-northstar` Chat	`152.326 kB` `45.963 kB`
`react-northstar` Checkbox	`79.782 kB` `25.085 kB`
`react-northstar` Datepicker	`184.887 kB` `56.167 kB`
`react-northstar` Debug	`8.801 kB` `3.594 kB`
`react-northstar` Design	`36.564 kB` `12.07 kB`
`react-northstar` Dialog	`112.02 kB` `33.638 kB`
`react-northstar` Divider	`76.594 kB` `24.137 kB`
`react-northstar` Dropdown	`196.43 kB` `59.442 kB`
`react-northstar` Embed	`81.446 kB` `25.42 kB`
`react-northstar` Flex	`47.702 kB` `15.45 kB`
`react-northstar` Form	`92.492 kB` `28.881 kB`
`react-northstar` Grid	`70.555 kB` `22.283 kB`
`react-northstar` Header	`74.731 kB` `23.476 kB`
`react-northstar` Image	`73.566 kB` `23.339 kB`
`react-northstar` Input	`88.31 kB` `27.784 kB`
`react-northstar` ItemLayout	`78.206 kB` `24.458 kB`
`react-northstar` Label	`77.895 kB` `24.415 kB`
`react-northstar` Layout	`75.368 kB` `23.806 kB`
`react-northstar` List	`88.472 kB` `27.57 kB`
`react-northstar` Loader	`78.591 kB` `24.745 kB`
`react-northstar` Menu	`126.85 kB` `39.875 kB`
`react-northstar` MenuButton	`161.254 kB` `48.881 kB`
`react-northstar` Pill	`83.697 kB` `26.077 kB`
`react-northstar` Popup	`133.56 kB` `41.486 kB`
`react-northstar` Portal	`58.294 kB` `18.855 kB`
`react-northstar` Provider	`93.114 kB` `29.626 kB`
`react-northstar` RadioGroup	`83.25 kB` `26.056 kB`
`react-northstar` Reaction	`77.255 kB` `24.138 kB`
`react-northstar` Segment	`76.184 kB` `23.899 kB`
`react-northstar` Skeleton	`77.74 kB` `24.21 kB`
`react-northstar` Slider	`84.235 kB` `26.744 kB`
`react-northstar` SplitButton	`176.487 kB` `52.632 kB`
`react-northstar` Status	`76.247 kB` `24.059 kB`
`react-northstar` SvgIcon	`36.819 kB` `11.744 kB`
`react-northstar` Table	`80.765 kB` `25.159 kB`
`react-northstar` Text	`74.089 kB` `23.522 kB`
`react-northstar` TextArea	`74.223 kB` `23.501 kB`
`react-northstar` Toolbar	`173.3 kB` `52.087 kB`
`react-northstar` Tooltip	`108.23 kB` `34.491 kB`
`react-northstar` Tree	`87.83 kB` `27.223 kB`
`react-northstar` Video	`75.379 kB` `23.794 kB`
`react-overflow` hooks only	`12.862 kB` `4.827 kB`
`react-persona` Persona	`57.066 kB` `17.821 kB`
`react-popover` Popover	`126.783 kB` `39.788 kB`
`react-portal` Portal	`13.591 kB` `4.869 kB`
`react-portal-compat` PortalCompatProvider	`7.902 kB` `2.586 kB`
`react-positioning` usePositioning	`26.398 kB` `9.539 kB`
`react-progress` ProgressBar	`17.428 kB` `6.898 kB`
`react-provider` FluentProvider	`23.713 kB` `8.655 kB`
`react-radio` Radio	`32.946 kB` `10.252 kB`
`react-radio` RadioGroup	`15.345 kB` `6.263 kB`
`react-select` Select	`28.609 kB` `10.205 kB`
`react-slider` Slider	`39.943 kB` `12.969 kB`
`react-spinbutton` SpinButton	`36.774 kB` `11.788 kB`
`react-spinner` Spinner	`23.517 kB` `8.512 kB`
`react-switch` Switch	`35.134 kB` `11.198 kB`
`react-table` DataGrid	`165.124 kB` `45.892 kB`
`react-table` Table (Primitives only)	`45.28 kB` `14.111 kB`
`react-table` Table as DataGrid	`136.504 kB` `36.822 kB`
`react-table` Table (Selection only)	`76.269 kB` `20.541 kB`
`react-table` Table (Sort only)	`74.935 kB` `20.151 kB`
`react-tags` InteractionTag	`15.259 kB` `6.058 kB`
`react-tags` Tag	`29.982 kB` `9.439 kB`
`react-tags` TagGroup	`80.55 kB` `24.027 kB`
`react-text` Text - Default	`16.705 kB` `6.569 kB`
`react-text` Text - Wrappers	`19.878 kB` `6.896 kB`
`react-textarea` Textarea	`30.947 kB` `10.476 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`34.616 kB` `7.317 kB`
`react-theme` Teams: Light theme	`19.287 kB` `5.498 kB`
`react-timepicker-compat` TimePicker	`100.234 kB` `33.18 kB`
`react-toast` Toast (including Toaster)	`100.154 kB` `29.761 kB`
`react-tooltip` Tooltip	`54.538 kB` `19.187 kB`
`react-utilities` SSRProvider	`180 B` `160 B`

_{🤖 This report was generated against 239dedf0af4e79d8510f8ba692756c3ae3c5e701}

size-auditor · 2024-01-11T16:49:51Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: be3a3d59d5c30f75d55c739548d576594ddf5c53 (build)

fabricteam · 2024-01-11T16:50:32Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	630	620	5000
Breadcrumb	mount	1665	1684	1000
Checkbox	mount	1709	1672	5000
CheckboxBase	mount	1467	1449	5000
ChoiceGroup	mount	2979	2960	5000
ComboBox	mount	665	680	1000
CommandBar	mount	6202	6254	1000
ContextualMenu	mount	13038	12945	1000
DefaultButton	mount	750	766	5000
DetailsRow	mount	2220	2169	5000
DetailsRowFast	mount	2168	2221	5000
DetailsRowNoStyles	mount	1987	2018	5000
Dialog	mount	2667	2677	1000
DocumentCardTitle	mount	225	226	1000
Dropdown	mount	1975	1985	5000
FocusTrapZone	mount	1148	1149	5000
FocusZone	mount	1076	1068	5000
GroupedList	mount	42033	42715	2
GroupedList	virtual-rerender	19961	19968	2
GroupedList	virtual-rerender-with-unmount	52883	53166	2
GroupedListV2	mount	227	226	2
GroupedListV2	virtual-rerender	219	204	2
GroupedListV2	virtual-rerender-with-unmount	230	233	2
IconButton	mount	1083	1085	5000
Label	mount	325	344	5000
Layer	mount	2711	2752	5000
Link	mount	386	404	5000
MenuButton	mount	952	959	5000
MessageBar	mount	21244	21359	5000
Nav	mount	1956	1972	1000
OverflowSet	mount	785	774	5000
Panel	mount	1853	1801	1000
Persona	mount	735	747	1000
Pivot	mount	865	860	1000
PrimaryButton	mount	825	849	5000
Rating	mount	4637	4580	5000
SearchBox	mount	912	946	5000
Shimmer	mount	1894	1877	5000
Slider	mount	1343	1317	5000
SpinButton	mount	2859	2895	5000
Spinner	mount	383	387	5000
SplitButton	mount	1821	1859	5000
Stack	mount	404	413	5000
StackWithIntrinsicChildren	mount	867	842	5000
StackWithTextChildren	mount	2570	2594	5000
SwatchColorPicker	mount	6184	6175	5000
TagPicker	mount	1447	1417	5000
Text	mount	380	378	5000
TextField	mount	952	926	5000
ThemeProvider	mount	833	841	5000
ThemeProvider	virtual-rerender	592	587	5000
ThemeProvider	virtual-rerender-with-unmount	1280	1280	5000
Toggle	mount	607	604	5000
buttonNative	mount	190	181	5000

fabricteam · 2024-01-11T16:52:19Z

🕵 fluentuiv9 No visual regressions between this PR and main

packages/eslint-plugin/src/rules/consistent-callback-type/index.js

packages/eslint-plugin/src/rules/consistent-callback-type/index.test.js

packages/eslint-plugin/src/configs/react.js

Co-authored-by: Martin Hochel <hochelmartin@gmail.com>

Hotell

🚢🚀🎉

fabricteam · 2024-01-25T11:01:44Z

🕵 FluentUIV0 No visual regressions between this PR and main

YuanboXue-Amber force-pushed the event-test-lint branch from 8ad647a to 8ac65a7 Compare January 12, 2024 11:46

YuanboXue-Amber mentioned this pull request Jan 12, 2024

feat(react-conformance): Deprecate conformance test consistent-callback-args #30301

Merged

YuanboXue-Amber changed the title ~~[DRAFT] Add lint rule for event callback typing~~ Add lint rule for event callback typing Jan 12, 2024

YuanboXue-Amber changed the title ~~Add lint rule for event callback typing~~ Add lint rule consistent-callback-type for event callback typing Jan 12, 2024

YuanboXue-Amber marked this pull request as ready for review January 12, 2024 15:02

YuanboXue-Amber requested review from a team, Mitch-At-Work, tomi-msft, sopranopillow, khmakoto, chpalac, ling1726, behowell, GeoffCoxMSFT, spmonahan, micahgodbolt, smhigley and marcosmoura as code owners January 12, 2024 15:02

YuanboXue-Amber mentioned this pull request Jan 12, 2024

Add conformance test for event callback typing: consistent-callback-type #30200

Closed

Hotell reviewed Jan 18, 2024

View reviewed changes

packages/eslint-plugin/src/rules/consistent-callback-type/index.js Outdated Show resolved Hide resolved

packages/eslint-plugin/src/rules/consistent-callback-type/index.test.js Outdated Show resolved Hide resolved

YuanboXue-Amber added 2 commits January 23, 2024 11:58

update lint rule

9b8fbc0

Merge branch 'master' into event-test-lint

2c1632a

YuanboXue-Amber mentioned this pull request Jan 23, 2024

[Feature]: New lint rule to test event callback type and deprecate/migrate conformance test consistent-callback-args #30372

Open

1 task

YuanboXue-Amber added 4 commits January 23, 2024 15:07

move rule to internal

04a9131

update lint disable

02b6d75

update change log for eslint-plugin

84209ac

add internal lint rule in the proper way

51bc1ba

Hotell reviewed Jan 23, 2024

View reviewed changes

packages/eslint-plugin/src/configs/react.js Outdated Show resolved Hide resolved

Update packages/eslint-plugin/src/configs/react.js

e1c4b0a

Co-authored-by: Martin Hochel <hochelmartin@gmail.com>

Hotell approved these changes Jan 23, 2024

View reviewed changes

Hotell changed the title ~~feat(eslint-plugin): add consistent-callback-type rule for event callback typing for react-components~~ feat(eslint-rules): add consistent-callback-type rule for event callback typing for react-components Jan 23, 2024

Hotell changed the title ~~feat(eslint-rules): add consistent-callback-type rule for event callback typing for react-components~~ feat(eslint-rules): add consistent-callback-type rule for event callback typing for react-components and enable it in all v9 packages Jan 23, 2024

YuanboXue-Amber added 2 commits January 25, 2024 11:40

Merge branch 'master' into event-test-lint

8b671d5

remove react-rating-preview change log after merge

8c7e484

marcosmoura approved these changes Jan 30, 2024

View reviewed changes

Merge branch 'master' into event-test-lint

cc028b1

layershifter approved these changes Feb 6, 2024

View reviewed changes

Mitch-At-Work approved these changes Feb 6, 2024

View reviewed changes

Merge branch 'master' into event-test-lint

5d12e30

YuanboXue-Amber enabled auto-merge (squash) February 7, 2024 08:51

add lint disable after merge

99871ce

YuanboXue-Amber disabled auto-merge February 7, 2024 09:13

YuanboXue-Amber added 2 commits February 7, 2024 17:22

add changelog

13f7c3e

Merge branch 'master' into event-test-lint

a704db8

YuanboXue-Amber enabled auto-merge (squash) February 7, 2024 10:25

YuanboXue-Amber merged commit 4cfa006 into microsoft:master Feb 7, 2024
21 checks passed

YuanboXue-Amber deleted the event-test-lint branch February 7, 2024 11:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eslint-rules): add `consistent-callback-type` rule for event callback typing for react-components and enable it in all v9 packages #30293

feat(eslint-rules): add `consistent-callback-type` rule for event callback typing for react-components and enable it in all v9 packages #30293

YuanboXue-Amber commented Jan 11, 2024 •

edited

fabricteam commented Jan 11, 2024 •

edited

codesandbox-ci bot commented Jan 11, 2024 •

edited

fabricteam commented Jan 11, 2024 •

edited

fabricteam commented Jan 11, 2024 •

edited

size-auditor bot commented Jan 11, 2024 •

edited

fabricteam commented Jan 11, 2024 •

edited

fabricteam commented Jan 11, 2024 •

edited

Hotell left a comment

fabricteam commented Jan 25, 2024 •

edited

feat(eslint-rules): add consistent-callback-type rule for event callback typing for react-components and enable it in all v9 packages #30293

feat(eslint-rules): add consistent-callback-type rule for event callback typing for react-components and enable it in all v9 packages #30293

Conversation

YuanboXue-Amber commented Jan 11, 2024 • edited

Background:

This PR does:

Related issue

fabricteam commented Jan 11, 2024 • edited

Perf Analysis (@fluentui/react-components)

codesandbox-ci bot commented Jan 11, 2024 • edited

fabricteam commented Jan 11, 2024 • edited

Perf Analysis (@fluentui/react-northstar)

fabricteam commented Jan 11, 2024 • edited

📊 Bundle size report

size-auditor bot commented Jan 11, 2024 • edited

Asset size changes

fabricteam commented Jan 11, 2024 • edited

Perf Analysis (@fluentui/react)

fabricteam commented Jan 11, 2024 • edited

🕵 fluentuiv9 No visual regressions between this PR and main

Hotell left a comment

Choose a reason for hiding this comment

fabricteam commented Jan 25, 2024 • edited

🕵 FluentUIV0 No visual regressions between this PR and main

feat(eslint-rules): add `consistent-callback-type` rule for event callback typing for react-components and enable it in all v9 packages #30293

feat(eslint-rules): add `consistent-callback-type` rule for event callback typing for react-components and enable it in all v9 packages #30293

YuanboXue-Amber commented Jan 11, 2024 •

edited

fabricteam commented Jan 11, 2024 •

edited

Perf Analysis (`@fluentui/react-components`)

codesandbox-ci bot commented Jan 11, 2024 •

edited

fabricteam commented Jan 11, 2024 •

edited

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Jan 11, 2024 •

edited

size-auditor bot commented Jan 11, 2024 •

edited

fabricteam commented Jan 11, 2024 •

edited

Perf Analysis (`@fluentui/react`)

fabricteam commented Jan 11, 2024 •

edited

fabricteam commented Jan 25, 2024 •

edited