Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(react-combobox): export internal hooks and types #30646

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Feb 28, 2024

Previous Behavior

New Behavior

  1. exports internal hooks from combobox as they'll be required for the react-tag-picker package

Related Issue(s)

  • Fixes #

@bsunderhus bsunderhus self-assigned this Feb 28, 2024
@bsunderhus bsunderhus marked this pull request as ready for review February 28, 2024 10:52
@bsunderhus bsunderhus requested review from smhigley and a team as code owners February 28, 2024 10:52
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 626 608 5000
Button mount 297 301 5000
Field mount 1159 1097 5000
FluentProvider mount 696 702 5000
FluentProviderWithTheme mount 87 75 10
FluentProviderWithTheme virtual-rerender 61 60 10
FluentProviderWithTheme virtual-rerender-with-unmount 74 67 10
MakeStyles mount 842 860 50000
Persona mount 1756 1702 5000
SpinButton mount 1375 1371 5000

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-combobox
Combobox (including child components)
102.463 kB
33.101 kB
react-combobox
Dropdown (including child components)
103.837 kB
33.038 kB
react-components
react-components: Button, FluentProvider & webLightTheme
70.732 kB
20.465 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
217.207 kB
61.943 kB
react-components
react-components: FluentProvider & webLightTheme
43.219 kB
14.299 kB
react-portal-compat
PortalCompatProvider
7.944 kB
2.588 kB
react-timepicker-compat
TimePicker
104.484 kB
34.49 kB
🤖 This report was generated against d27ded5aae466199135de53d143cc9d88659770d

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus enabled auto-merge (squash) February 28, 2024 12:35
@bsunderhus bsunderhus merged commit a64d8f6 into microsoft:master Feb 28, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants