[xplat] Initial implementation of griffel-to-stylex converter #30754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonVMo
approved these changes
Mar 12, 2024
| @@ -38,7 +38,9 @@ | |||
| "@fluentui/react-theme": "^9.1.17", | |||
| "@fluentui/react-utilities": "^9.18.3", | |||
| "@griffel/react": "^1.5.14", | |||
| "@swc/helpers": "^0.5.1" | |||
| "@stylexjs/stylex": "0.5.0-alpha.4", | |||
There was a problem hiding this comment.
If you are only calling stylex.create from the native side I don't think you need to bring it in directly. I believe you can call it via:
import { css } from 'react-strict-dom';
const styles = css.create(...There was a problem hiding this comment.
Actually looks like you already saw this below. I think they added TS support to RSD just recently, might be in 0.0.3, so if this is for types you may want to try updating to that build.
There was a problem hiding this comment.
I'll merge it as it is for now and we can look at switching over to the RSD types once we update to 0.0.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
Adds an initial implementation of a converter from griffel to stylex. This will enable existing web styles to be reused on native.