-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
poc/try shorthands #30765
Closed
Closed
poc/try shorthands #30765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
force-pushed
the
poc/try-shorthands
branch
from
March 12, 2024 09:40
ac4d0af
to
1d67ef9
Compare
📊 Bundle size reportUnchanged fixtures
|
layershifter
force-pushed
the
poc/try-shorthands
branch
from
March 12, 2024 09:47
1d67ef9
to
3268fa6
Compare
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
FluentProviderWithTheme | virtual-rerender | 35 | 33 | 10 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 650 | 626 | 5000 | |
Button | mount | 307 | 292 | 5000 | |
Field | mount | 1125 | 1150 | 5000 | |
FluentProvider | mount | 715 | 702 | 5000 | |
FluentProviderWithTheme | mount | 81 | 93 | 10 | |
FluentProviderWithTheme | virtual-rerender | 35 | 33 | 10 | Possible regression |
FluentProviderWithTheme | virtual-rerender-with-unmount | 81 | 83 | 10 | |
MakeStyles | mount | 868 | 880 | 50000 | |
Persona | mount | 1764 | 1712 | 5000 | |
SpinButton | mount | 1368 | 1378 | 5000 | |
SwatchPicker | mount | 1530 | 1555 | 5000 |
Perf Analysis (
|
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
AccordionMinimalPerf.default | 88 | 75 | 1.17:1 |
ChatDuplicateMessagesPerf.default | 162 | 143 | 1.13:1 |
PortalMinimalPerf.default | 94 | 84 | 1.12:1 |
FlexMinimalPerf.default | 160 | 144 | 1.11:1 |
AttachmentMinimalPerf.default | 86 | 80 | 1.08:1 |
ButtonMinimalPerf.default | 92 | 87 | 1.06:1 |
LabelMinimalPerf.default | 223 | 211 | 1.06:1 |
ListWith60ListItems.default | 375 | 354 | 1.06:1 |
StatusMinimalPerf.default | 404 | 382 | 1.06:1 |
TableMinimalPerf.default | 235 | 221 | 1.06:1 |
AttachmentSlotsPerf.default | 672 | 637 | 1.05:1 |
InputMinimalPerf.default | 560 | 531 | 1.05:1 |
ReactionMinimalPerf.default | 213 | 203 | 1.05:1 |
DialogMinimalPerf.default | 458 | 440 | 1.04:1 |
ItemLayoutMinimalPerf.default | 727 | 699 | 1.04:1 |
SkeletonMinimalPerf.default | 194 | 187 | 1.04:1 |
ToolbarMinimalPerf.default | 544 | 524 | 1.04:1 |
TreeMinimalPerf.default | 504 | 484 | 1.04:1 |
VideoMinimalPerf.default | 454 | 435 | 1.04:1 |
ButtonOverridesMissPerf.default | 657 | 640 | 1.03:1 |
CarouselMinimalPerf.default | 267 | 258 | 1.03:1 |
DatepickerMinimalPerf.default | 3587 | 3490 | 1.03:1 |
DividerMinimalPerf.default | 202 | 197 | 1.03:1 |
ImageMinimalPerf.default | 233 | 226 | 1.03:1 |
RadioGroupMinimalPerf.default | 264 | 257 | 1.03:1 |
IconMinimalPerf.default | 390 | 380 | 1.03:1 |
AvatarMinimalPerf.default | 115 | 113 | 1.02:1 |
CardMinimalPerf.default | 312 | 305 | 1.02:1 |
CheckboxMinimalPerf.default | 1147 | 1120 | 1.02:1 |
DropdownMinimalPerf.default | 1424 | 1397 | 1.02:1 |
ListCommonPerf.default | 394 | 386 | 1.02:1 |
MenuButtonMinimalPerf.default | 956 | 935 | 1.02:1 |
PopupMinimalPerf.default | 352 | 346 | 1.02:1 |
SplitButtonMinimalPerf.default | 2262 | 2215 | 1.02:1 |
TextAreaMinimalPerf.default | 291 | 286 | 1.02:1 |
EmbedMinimalPerf.default | 1888 | 1877 | 1.01:1 |
LoaderMinimalPerf.default | 200 | 198 | 1.01:1 |
MenuMinimalPerf.default | 510 | 506 | 1.01:1 |
ProviderMinimalPerf.default | 206 | 203 | 1.01:1 |
SliderMinimalPerf.default | 739 | 730 | 1.01:1 |
AnimationMinimalPerf.default | 301 | 300 | 1:1 |
ChatMinimalPerf.default | 436 | 434 | 1:1 |
FormMinimalPerf.default | 230 | 230 | 1:1 |
HeaderMinimalPerf.default | 205 | 204 | 1:1 |
SegmentMinimalPerf.default | 192 | 192 | 1:1 |
TableManyItemsPerf.default | 1112 | 1113 | 1:1 |
BoxMinimalPerf.default | 193 | 194 | 0.99:1 |
HeaderSlotsPerf.default | 453 | 457 | 0.99:1 |
ListMinimalPerf.default | 303 | 305 | 0.99:1 |
ProviderMergeThemesPerf.default | 644 | 649 | 0.99:1 |
GridMinimalPerf.default | 186 | 189 | 0.98:1 |
LayoutMinimalPerf.default | 193 | 196 | 0.98:1 |
TextMinimalPerf.default | 191 | 194 | 0.98:1 |
CustomToolbarPrototype.default | 1454 | 1487 | 0.98:1 |
AlertMinimalPerf.default | 161 | 166 | 0.97:1 |
DropdownManyItemsPerf.default | 373 | 384 | 0.97:1 |
RosterPerf.default | 1540 | 1582 | 0.97:1 |
TooltipMinimalPerf.default | 1258 | 1303 | 0.97:1 |
ButtonSlotsPerf.default | 311 | 323 | 0.96:1 |
ListNestedPerf.default | 310 | 322 | 0.96:1 |
RefMinimalPerf.default | 101 | 106 | 0.95:1 |
ChatWithPopoverPerf.default | 186 | 197 | 0.94:1 |
TreeWith60ListItems.default | 85 | 90 | 0.94:1 |
🕵 FluentUIV0 No visual regressions between this PR and main |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 624 | 635 | 5000 | |
Breadcrumb | mount | 1699 | 1706 | 1000 | |
Checkbox | mount | 1701 | 1684 | 5000 | |
CheckboxBase | mount | 1472 | 1500 | 5000 | |
ChoiceGroup | mount | 3052 | 2966 | 5000 | |
ComboBox | mount | 689 | 693 | 1000 | |
CommandBar | mount | 6543 | 6551 | 1000 | |
ContextualMenu | mount | 13405 | 13122 | 1000 | |
DefaultButton | mount | 786 | 801 | 5000 | |
DetailsRow | mount | 2226 | 2232 | 5000 | |
DetailsRowFast | mount | 2221 | 2235 | 5000 | |
DetailsRowNoStyles | mount | 2022 | 2109 | 5000 | |
Dialog | mount | 2831 | 2813 | 1000 | |
DocumentCardTitle | mount | 243 | 236 | 1000 | |
Dropdown | mount | 2041 | 2029 | 5000 | |
FocusTrapZone | mount | 1143 | 1146 | 5000 | |
FocusZone | mount | 1070 | 1054 | 5000 | |
GroupedList | mount | 42379 | 42358 | 2 | |
GroupedList | virtual-rerender | 18234 | 20329 | 2 | |
GroupedList | virtual-rerender-with-unmount | 51149 | 50967 | 2 | |
GroupedListV2 | mount | 230 | 223 | 2 | |
GroupedListV2 | virtual-rerender | 213 | 205 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 236 | 231 | 2 | |
IconButton | mount | 1139 | 1147 | 5000 | |
Label | mount | 339 | 343 | 5000 | |
Layer | mount | 2742 | 2768 | 5000 | |
Link | mount | 394 | 382 | 5000 | |
MenuButton | mount | 985 | 978 | 5000 | |
MessageBar | mount | 21500 | 21521 | 5000 | |
Nav | mount | 2057 | 2076 | 1000 | |
OverflowSet | mount | 801 | 783 | 5000 | |
Panel | mount | 1798 | 1828 | 1000 | |
Persona | mount | 749 | 751 | 1000 | |
Pivot | mount | 917 | 902 | 1000 | |
PrimaryButton | mount | 942 | 924 | 5000 | |
Rating | mount | 4682 | 4674 | 5000 | |
SearchBox | mount | 914 | 906 | 5000 | |
Shimmer | mount | 1885 | 1932 | 5000 | |
Slider | mount | 1381 | 1359 | 5000 | |
SpinButton | mount | 3034 | 3057 | 5000 | |
Spinner | mount | 396 | 381 | 5000 | |
SplitButton | mount | 1897 | 1877 | 5000 | |
Stack | mount | 412 | 407 | 5000 | |
StackWithIntrinsicChildren | mount | 880 | 890 | 5000 | |
StackWithTextChildren | mount | 2702 | 2657 | 5000 | |
SwatchColorPicker | mount | 6343 | 6441 | 5000 | |
TagPicker | mount | 1479 | 1465 | 5000 | |
Text | mount | 379 | 375 | 5000 | |
TextField | mount | 974 | 968 | 5000 | |
ThemeProvider | mount | 847 | 854 | 5000 | |
ThemeProvider | virtual-rerender | 578 | 583 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1321 | 1290 | 5000 | |
Toggle | mount | 600 | 605 | 5000 | |
buttonNative | mount | 190 | 196 | 5000 |
layershifter
force-pushed
the
poc/try-shorthands
branch
from
March 12, 2024 10:35
3268fa6
to
f2440dd
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
layershifter
force-pushed
the
poc/try-shorthands
branch
6 times, most recently
from
March 12, 2024 14:23
5689342
to
a9fbc04
Compare
🕵 fluentuiv8 No visual regressions between this PR and main |
layershifter
force-pushed
the
poc/try-shorthands
branch
from
April 8, 2024 14:46
a9fbc04
to
006900c
Compare
github-actions
bot
modified the milestones:
March Project Cycle Q1 2024,
April Project Cycle Q1 2024
Apr 8, 2024
layershifter
force-pushed
the
poc/try-shorthands
branch
6 times, most recently
from
April 12, 2024 15:53
94d40d6
to
a197fbe
Compare
layershifter
force-pushed
the
poc/try-shorthands
branch
2 times, most recently
from
April 16, 2024 11:31
84adea5
to
9eb88aa
Compare
layershifter
force-pushed
the
poc/try-shorthands
branch
3 times, most recently
from
April 17, 2024 08:34
42ae137
to
082c5ef
Compare
layershifter
force-pushed
the
poc/try-shorthands
branch
6 times, most recently
from
May 2, 2024 09:48
78153f7
to
a5f52a6
Compare
layershifter
force-pushed
the
poc/try-shorthands
branch
from
May 2, 2024 12:22
a5f52a6
to
8fb93cb
Compare
🕵 fluentuiv9 No visual regressions between this PR and main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Related Issue(s)