-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabster 7.1.0 #30969
Merged
Merged
Tabster 7.1.0 #30969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
FluentProviderWithTheme | virtual-rerender | 40 | 30 | 10 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 637 | 661 | 5000 | |
Button | mount | 303 | 294 | 5000 | |
Field | mount | 1130 | 1096 | 5000 | |
FluentProvider | mount | 697 | 717 | 5000 | |
FluentProviderWithTheme | mount | 82 | 74 | 10 | |
FluentProviderWithTheme | virtual-rerender | 40 | 30 | 10 | Possible regression |
FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 84 | 10 | |
MakeStyles | mount | 879 | 864 | 50000 | |
Persona | mount | 1741 | 1712 | 5000 | |
SpinButton | mount | 1354 | 1435 | 5000 |
Perf Analysis (
|
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
AttachmentMinimalPerf.default | 88 | 74 | 1.19:1 |
ButtonMinimalPerf.default | 95 | 87 | 1.09:1 |
TreeWith60ListItems.default | 94 | 86 | 1.09:1 |
FlexMinimalPerf.default | 154 | 143 | 1.08:1 |
ListWith60ListItems.default | 365 | 337 | 1.08:1 |
TableMinimalPerf.default | 244 | 226 | 1.08:1 |
StatusMinimalPerf.default | 398 | 371 | 1.07:1 |
CarouselMinimalPerf.default | 264 | 250 | 1.06:1 |
PortalMinimalPerf.default | 88 | 84 | 1.05:1 |
SegmentMinimalPerf.default | 204 | 194 | 1.05:1 |
IconMinimalPerf.default | 396 | 378 | 1.05:1 |
CardMinimalPerf.default | 308 | 296 | 1.04:1 |
ChatMinimalPerf.default | 439 | 424 | 1.04:1 |
LabelMinimalPerf.default | 221 | 212 | 1.04:1 |
LayoutMinimalPerf.default | 200 | 192 | 1.04:1 |
ListNestedPerf.default | 326 | 312 | 1.04:1 |
RadioGroupMinimalPerf.default | 271 | 261 | 1.04:1 |
SkeletonMinimalPerf.default | 200 | 192 | 1.04:1 |
DatepickerMinimalPerf.default | 3524 | 3434 | 1.03:1 |
FormMinimalPerf.default | 232 | 226 | 1.03:1 |
RosterPerf.default | 1620 | 1575 | 1.03:1 |
PopupMinimalPerf.default | 357 | 346 | 1.03:1 |
ProviderMinimalPerf.default | 203 | 197 | 1.03:1 |
SplitButtonMinimalPerf.default | 2273 | 2212 | 1.03:1 |
AccordionMinimalPerf.default | 83 | 81 | 1.02:1 |
AnimationMinimalPerf.default | 300 | 293 | 1.02:1 |
ButtonOverridesMissPerf.default | 654 | 642 | 1.02:1 |
ChatDuplicateMessagesPerf.default | 150 | 147 | 1.02:1 |
ChatWithPopoverPerf.default | 192 | 189 | 1.02:1 |
CheckboxMinimalPerf.default | 1126 | 1104 | 1.02:1 |
DialogMinimalPerf.default | 444 | 437 | 1.02:1 |
HeaderMinimalPerf.default | 208 | 203 | 1.02:1 |
ListMinimalPerf.default | 304 | 298 | 1.02:1 |
MenuMinimalPerf.default | 499 | 489 | 1.02:1 |
MenuButtonMinimalPerf.default | 951 | 933 | 1.02:1 |
ReactionMinimalPerf.default | 212 | 208 | 1.02:1 |
TableManyItemsPerf.default | 1107 | 1082 | 1.02:1 |
TextMinimalPerf.default | 196 | 193 | 1.02:1 |
ToolbarMinimalPerf.default | 533 | 525 | 1.02:1 |
ButtonSlotsPerf.default | 313 | 311 | 1.01:1 |
GridMinimalPerf.default | 187 | 185 | 1.01:1 |
AttachmentSlotsPerf.default | 639 | 636 | 1:1 |
AvatarMinimalPerf.default | 110 | 110 | 1:1 |
EmbedMinimalPerf.default | 1844 | 1845 | 1:1 |
RefMinimalPerf.default | 108 | 108 | 1:1 |
TreeMinimalPerf.default | 472 | 472 | 1:1 |
DividerMinimalPerf.default | 196 | 198 | 0.99:1 |
DropdownManyItemsPerf.default | 390 | 393 | 0.99:1 |
DropdownMinimalPerf.default | 1401 | 1412 | 0.99:1 |
ItemLayoutMinimalPerf.default | 709 | 718 | 0.99:1 |
ListCommonPerf.default | 377 | 380 | 0.99:1 |
ProviderMergeThemesPerf.default | 628 | 634 | 0.99:1 |
TooltipMinimalPerf.default | 1265 | 1274 | 0.99:1 |
AlertMinimalPerf.default | 153 | 156 | 0.98:1 |
HeaderSlotsPerf.default | 459 | 467 | 0.98:1 |
LoaderMinimalPerf.default | 186 | 189 | 0.98:1 |
SliderMinimalPerf.default | 734 | 752 | 0.98:1 |
CustomToolbarPrototype.default | 1463 | 1490 | 0.98:1 |
BoxMinimalPerf.default | 184 | 190 | 0.97:1 |
ImageMinimalPerf.default | 226 | 232 | 0.97:1 |
InputMinimalPerf.default | 522 | 547 | 0.95:1 |
TextAreaMinimalPerf.default | 273 | 289 | 0.94:1 |
VideoMinimalPerf.default | 422 | 447 | 0.94:1 |
🕵 FluentUIV0 No visual regressions between this PR and main |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
CheckboxBase | mount | 1449 | 1505 | 5000 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 628 | 630 | 5000 | |
Breadcrumb | mount | 1676 | 1666 | 1000 | |
Checkbox | mount | 1709 | 1665 | 5000 | |
CheckboxBase | mount | 1449 | 1505 | 5000 | Possible regression |
ChoiceGroup | mount | 2880 | 2986 | 5000 | |
ComboBox | mount | 661 | 652 | 1000 | |
CommandBar | mount | 6213 | 6211 | 1000 | |
ContextualMenu | mount | 12675 | 12705 | 1000 | |
DefaultButton | mount | 760 | 772 | 5000 | |
DetailsRow | mount | 2214 | 2221 | 5000 | |
DetailsRowFast | mount | 2219 | 2194 | 5000 | |
DetailsRowNoStyles | mount | 2042 | 2023 | 5000 | |
Dialog | mount | 2630 | 2643 | 1000 | |
DocumentCardTitle | mount | 237 | 229 | 1000 | |
Dropdown | mount | 1932 | 1964 | 5000 | |
FocusTrapZone | mount | 1148 | 1143 | 5000 | |
FocusZone | mount | 1068 | 1085 | 5000 | |
GroupedList | mount | 41563 | 41440 | 2 | |
GroupedList | virtual-rerender | 19868 | 19948 | 2 | |
GroupedList | virtual-rerender-with-unmount | 51262 | 51039 | 2 | |
GroupedListV2 | mount | 223 | 235 | 2 | |
GroupedListV2 | virtual-rerender | 216 | 208 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 226 | 229 | 2 | |
IconButton | mount | 1092 | 1112 | 5000 | |
Label | mount | 335 | 346 | 5000 | |
Layer | mount | 2736 | 2717 | 5000 | |
Link | mount | 384 | 385 | 5000 | |
MenuButton | mount | 951 | 918 | 5000 | |
MessageBar | mount | 21263 | 21264 | 5000 | |
Nav | mount | 1956 | 1958 | 1000 | |
OverflowSet | mount | 779 | 784 | 5000 | |
Panel | mount | 2031 | 1805 | 1000 | |
Persona | mount | 726 | 760 | 1000 | |
Pivot | mount | 872 | 870 | 1000 | |
PrimaryButton | mount | 836 | 823 | 5000 | |
Rating | mount | 4578 | 4595 | 5000 | |
SearchBox | mount | 898 | 932 | 5000 | |
Shimmer | mount | 1894 | 1901 | 5000 | |
Slider | mount | 1304 | 1305 | 5000 | |
SpinButton | mount | 2883 | 2903 | 5000 | |
Spinner | mount | 384 | 389 | 5000 | |
SplitButton | mount | 1799 | 1775 | 5000 | |
Stack | mount | 403 | 404 | 5000 | |
StackWithIntrinsicChildren | mount | 876 | 858 | 5000 | |
StackWithTextChildren | mount | 2614 | 2624 | 5000 | |
SwatchColorPicker | mount | 6178 | 6126 | 5000 | |
TagPicker | mount | 1488 | 1499 | 5000 | |
Text | mount | 384 | 366 | 5000 | |
TextField | mount | 944 | 928 | 5000 | |
ThemeProvider | mount | 833 | 841 | 5000 | |
ThemeProvider | virtual-rerender | 589 | 571 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1265 | 1252 | 5000 | |
Toggle | mount | 610 | 595 | 5000 | |
buttonNative | mount | 192 | 189 | 5000 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
🕵 fluentuiv9 No visual regressions between this PR and main |
Hotell
reviewed
Apr 5, 2024
packages/react-components/react-tabster/src/tabster-types-6.0.1-do-not-use.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-tabster/src/tabster-types-6.0.1-do-not-use.ts
Show resolved
Hide resolved
🕵 fluentuiv8 No visual regressions between this PR and main |
ling1726
approved these changes
Apr 16, 2024
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Apr 17, 2024
Pulling Tabster 7.1.0. Putting a snapshot of older Tabster typings that were exposed accidentally (for backwards compatibility) and marking them as deprecated. Exposing MoverMoveFocusEvent and GroupperMoveFocusEvent. Adjusting all deprecated tabster API usages with the new APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling Tabster 7.1.0.
Putting a snapshot of older Tabster typings that were exposed accidentally (for backwards compatibility) and marking them as deprecated.
Exposing MoverMoveFocusEvent and GroupperMoveFocusEvent.
Adjusting all deprecated tabster API usages with the new APIs.