fix(web-components): remove final dependencies on fast-foundation #31009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eljefe223
approved these changes
Apr 9, 2024
📊 Bundle size reportUnchanged fixtures
|
radium-v
reviewed
Apr 9, 2024
| "type": "prerelease", | ||
| "comment": "fix(web-components): remove final dependencies on fast-foundation", | ||
| "packageName": "@fluentui/web-components", | ||
| "email": "=", |
There was a problem hiding this comment.
I don't think it matters - I'll look and see why it's "not" setting.
chrisdholt
force-pushed
the
users/chhol/remove-fast-foundation-completely
branch
from
615fb50
to
c33493b
Compare
fabricteam
reviewed
Apr 9, 2024
| @@ -2,12 +2,9 @@ import * as React from 'react'; | |||
| import { StoryContext } from '@storybook/addons'; | |||
There was a problem hiding this comment.
🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots
Text 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Text.Block.normal.chromium.png | 995 | Changed |
There was a problem hiding this comment.
This didn't update with the last one - the background is expected
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Hotell
approved these changes
Apr 12, 2024
chrisdholt
added a commit
that referenced
this pull request
Apr 29, 2024
…1009) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
…crosoft#31009) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
…crosoft#31009) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
…crosoft#31009) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
…1009) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
…1009) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
…1009) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
…1009) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
…1009) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
…1009) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
…1009) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
…1009) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
…1009) Co-authored-by: Christopher Holt <=>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final PR to fully remove the dependency on the fast-foundation project. There are two utilities being moved here (along with some cleanup found while changing/removing imports): the
displayhelper and thematch-media-stylesheetbehavior and corresponding code.