Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update react-icons version to 2.0.235 #31011

Merged
merged 7 commits into from Apr 17, 2024
Merged

chore: Update react-icons version to 2.0.235 #31011

merged 7 commits into from Apr 17, 2024

Conversation

tomi-msft
Copy link
Contributor

This PR updates the react-icons version in the repo to the latest to pick up changes in the export map. Part of #30909

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone Apr 9, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 9, 2024 •
edited

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 221.141 kB
62.432 kB		 221.098 kB
62.406 kB		 -43 B
-26 B
react-infobutton
InfoButton		 139.645 kB
43.648 kB		 139.602 kB
43.628 kB		 -43 B
-20 B
react-infobutton
InfoLabel		 143.46 kB
44.86 kB		 143.417 kB
44.844 kB		 -43 B
-16 B
react-menu
Menu (including children components)		 153.681 kB
46.03 kB		 153.638 kB
46.013 kB		 -43 B
-17 B
react-menu
Menu (including selectable components)		 156.367 kB
46.586 kB		 156.324 kB
46.568 kB		 -43 B
-18 B
react-message-bar
MessageBar (all components)		 24.204 kB
8.984 kB		 24.204 kB
8.983 kB
-1 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 510 B
328 B
global-context
createContextSelector		 537 B
339 B
keyboard-key
keyboard-key package		 3.746 kB
1.928 kB
priority-overflow
createOverflowManager		 4.447 kB
1.853 kB
react
ActivityItem		 68.833 kB
22.613 kB
react
Announced		 36.473 kB
12.628 kB
react
Autofill		 15.365 kB
4.743 kB
react
Breadcrumb		 196.131 kB
58.76 kB
react
Button		 190.127 kB
55.019 kB
react
ButtonGrid		 175.918 kB
53.25 kB
react
Calendar		 118.756 kB
36.101 kB
react
Callout		 80.866 kB
26.564 kB
react
Check		 51.062 kB
17.152 kB
react
Checkbox		 57.791 kB
19.17 kB
react
ChoiceGroup		 63.339 kB
20.824 kB
react
ChoiceGroupOption		 56.601 kB
18.695 kB
react
Coachmark		 89.704 kB
28.407 kB
react
Color		 7.737 kB
3.106 kB
react
ColorPicker		 130.032 kB
40.591 kB
react
ComboBox		 245.355 kB
70.51 kB
react
CommandBar		 197.41 kB
58.464 kB
react
ContextualMenu		 150.967 kB
46.982 kB
react
DatePicker		 180.318 kB
54.947 kB
react
DateTimeUtilities		 5.244 kB
1.849 kB
react
DetailsList		 225.911 kB
64.65 kB
react
Dialog		 205.294 kB
61.428 kB
react
Divider		 17.63 kB
6.234 kB
react
DocumentCard		 211.08 kB
62.793 kB
react
DragDrop		 8.343 kB
2.724 kB
react
DraggableZone		 33.345 kB
11.166 kB
react
Dropdown		 227.809 kB
66.884 kB
react
ExtendedPicker		 94.987 kB
27.297 kB
react
Fabric		 39.75 kB
13.688 kB
react
Facepile		 206.04 kB
61.687 kB
react
FloatingPicker		 236.281 kB
67.376 kB
react
FocusTrapZone		 15.831 kB
5.54 kB
react
FocusZone		 53.259 kB
16.869 kB
react
Grid		 175.918 kB
53.25 kB
react
GroupedList		 131.707 kB
39.689 kB
react
GroupedListV2		 119.324 kB
36.822 kB
react
HoverCard		 93.735 kB
29.778 kB
react
Icon		 49.74 kB
16.603 kB
react
Icons		 65.829 kB
24.212 kB
react
Image		 44.79 kB
15.024 kB
react
Keytip		 78.588 kB
25.825 kB
react
KeytipData		 13.585 kB
4.418 kB
react
KeytipLayer		 100.422 kB
31.128 kB
react
Keytips		 103.175 kB
32.07 kB
react
Label		 36.347 kB
12.639 kB
react
Layer		 45.683 kB
15.585 kB
react
Link		 37.673 kB
12.993 kB
react
List		 38.136 kB
12.004 kB
react
MarqueeSelection		 72.119 kB
21.676 kB
react
MessageBar		 184.707 kB
55.523 kB
react
Modal		 90.409 kB
29.213 kB
react
Nav		 183.442 kB
55.093 kB
react
OverflowSet		 31.044 kB
10.593 kB
react
Overlay		 38.784 kB
13.401 kB
react
Panel		 194.946 kB
58.34 kB
react
Persona		 111.753 kB
35.58 kB
react
PersonaCoin		 111.753 kB
35.58 kB
react
PersonaPresence		 55.928 kB
18.715 kB
react
Pickers		 287.867 kB
80.661 kB
react
Pivot		 184.252 kB
55.823 kB
react
Popup		 12.032 kB
4.114 kB
react
Positioning		 21.821 kB
7.334 kB
react
PositioningContainer		 70.754 kB
22.84 kB
react
ProgressIndicator		 37.498 kB
12.906 kB
react
Rating		 78.989 kB
25.18 kB
react
ResizeGroup		 13.286 kB
4.365 kB
react
ResponsiveMode		 8.078 kB
2.95 kB
react
ScrollablePane		 53.538 kB
17.113 kB
react
SearchBox		 182.982 kB
55.1 kB
react
SelectableOption		 724 B
413 B
react
SelectedItemsList		 226.707 kB
66.319 kB
react
Selection		 41.202 kB
11.839 kB
react
Separator		 33.397 kB
11.529 kB
react
Shimmer		 47.265 kB
15.632 kB
react
ShimmeredDetailsList		 236.679 kB
67.422 kB
react
Slider		 55.575 kB
18.574 kB
react
SpinButton		 186.661 kB
56.205 kB
react
Spinner		 39.691 kB
13.815 kB
react
Stack		 40.761 kB
13.931 kB
react
Sticky		 32.064 kB
10.324 kB
react
Styling		 44.812 kB
14.688 kB
react
SwatchColorPicker		 186.166 kB
56.724 kB
react
TeachingBubble		 200.004 kB
59.345 kB
react
Text		 35.931 kB
12.486 kB
react
TextField		 78.587 kB
24.642 kB
react
Theme		 42.456 kB
13.773 kB
react
ThemeGenerator		 12.34 kB
4.106 kB
react
TimePicker		 235.197 kB
68.29 kB
react
Toggle		 44.17 kB
15.346 kB
react
Tooltip		 84.273 kB
27.284 kB
react
Utilities		 71.851 kB
21.843 kB
react
Viewport		 22.945 kB
7.292 kB
react
WeeklyDayPicker		 98.762 kB
30.828 kB
react
WindowProvider		 1.059 kB
541 B
react-accordion
Accordion (including children components)		 100.94 kB
30.574 kB
react-alert
Alert		 83.737 kB
23.475 kB
react-avatar
Avatar		 50.175 kB
15.944 kB
react-avatar
AvatarGroup		 19.702 kB
7.794 kB
react-avatar
AvatarGroupItem		 64.829 kB
20.272 kB
react-badge
Badge		 26.905 kB
8.73 kB
react-badge
CounterBadge		 27.806 kB
9.025 kB
react-badge
PresenceBadge		 25.311 kB
9.307 kB
react-breadcrumb
@fluentui/react-breadcrumb - package		 116.817 kB
32.173 kB
react-button
Button		 39.513 kB
11.17 kB
react-button
CompoundButton		 46.874 kB
12.662 kB
react-button
MenuButton		 44.292 kB
12.544 kB
react-button
SplitButton		 52.306 kB
14.135 kB
react-button
ToggleButton		 56.558 kB
13.068 kB
react-calendar-compat
Calendar Compat		 153.428 kB
40.128 kB
react-card
Card - All		 103.992 kB
29.35 kB
react-card
Card		 97.003 kB
27.61 kB
react-card
CardFooter		 13.971 kB
5.626 kB
react-card
CardHeader		 16.214 kB
6.386 kB
react-card
CardPreview		 14.015 kB
5.752 kB
react-checkbox
Checkbox		 35.656 kB
12.07 kB
react-combobox
Combobox (including child components)		 103.128 kB
33.283 kB
react-combobox
Dropdown (including child components)		 104.606 kB
33.244 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 71.104 kB
20.52 kB
react-components
react-components: FluentProvider & webLightTheme		 43.591 kB
14.356 kB
react-datepicker-compat
DatePicker Compat		 227.367 kB
63.503 kB
react-dialog
Dialog (including children components)		 100.478 kB
30.071 kB
react-divider
Divider		 20.922 kB
7.791 kB
react-field
Field		 22.976 kB
8.722 kB
react-image
Image		 15.745 kB
6.231 kB
react-input
Input		 28.122 kB
9.36 kB
react-jsx-runtime
Classic Pragma		 1.057 kB
530 B
react-jsx-runtime
JSX Dev Runtime		 3.781 kB
1.646 kB
react-jsx-runtime
JSX Runtime		 4.377 kB
1.881 kB
react-label
Label		 14.266 kB
5.829 kB
react-link
Link		 17.082 kB
6.911 kB
react-northstar
Accordion		 85.392 kB
26.518 kB
react-northstar
Alert		 87.45 kB
26.902 kB
react-northstar
Animation		 55.34 kB
17.829 kB
react-northstar
Attachment		 86.844 kB
26.692 kB
react-northstar
Avatar		 80.279 kB
24.629 kB
react-northstar
Box		 75.248 kB
23.806 kB
react-northstar
Breadcrumb		 79.92 kB
24.709 kB
react-northstar
Button		 83.16 kB
25.947 kB
react-northstar
Card		 82.705 kB
25.023 kB
react-northstar
Carousel		 105.182 kB
31.871 kB
react-northstar
Chat		 152.378 kB
45.964 kB
react-northstar
Checkbox		 79.807 kB
25.078 kB
react-northstar
Datepicker		 184.939 kB
56.194 kB
react-northstar
Debug		 8.801 kB
3.594 kB
react-northstar
Design		 36.589 kB
12.067 kB
react-northstar
Dialog		 112.058 kB
33.615 kB
react-northstar
Divider		 76.619 kB
24.129 kB
react-northstar
Dropdown		 196.499 kB
59.455 kB
react-northstar
Embed		 81.477 kB
25.417 kB
react-northstar
Flex		 47.728 kB
15.438 kB
react-northstar
Form		 92.527 kB
28.879 kB
react-northstar
Grid		 70.584 kB
22.278 kB
react-northstar
Header		 74.756 kB
23.461 kB
react-northstar
Image		 73.591 kB
23.329 kB
react-northstar
Input		 88.346 kB
27.78 kB
react-northstar
ItemLayout		 78.231 kB
24.454 kB
react-northstar
Label		 77.92 kB
24.41 kB
react-northstar
Layout		 75.393 kB
23.798 kB
react-northstar
List		 88.493 kB
27.547 kB
react-northstar
Loader		 78.616 kB
24.729 kB
react-northstar
Menu		 126.89 kB
39.872 kB
react-northstar
MenuButton		 161.296 kB
48.883 kB
react-northstar
Pill		 83.722 kB
26.069 kB
react-northstar
Popup		 133.604 kB
41.483 kB
react-northstar
Portal		 58.338 kB
18.852 kB
react-northstar
Provider		 93.138 kB
29.63 kB
react-northstar
RadioGroup		 83.282 kB
26.053 kB
react-northstar
Reaction		 77.28 kB
24.122 kB
react-northstar
Segment		 76.209 kB
23.892 kB
react-northstar
Skeleton		 77.765 kB
24.2 kB
react-northstar
Slider		 84.27 kB
26.737 kB
react-northstar
SplitButton		 176.534 kB
52.63 kB
react-northstar
Status		 76.272 kB
24.05 kB
react-northstar
SvgIcon		 36.823 kB
11.743 kB
react-northstar
Table		 80.796 kB
25.154 kB
react-northstar
Text		 74.114 kB
23.507 kB
react-northstar
TextArea		 74.248 kB
23.492 kB
react-northstar
Toolbar		 173.345 kB
52.08 kB
react-northstar
Tooltip		 108.261 kB
34.482 kB
react-northstar
Tree		 87.855 kB
27.217 kB
react-northstar
Video		 75.411 kB
23.799 kB
react-overflow
hooks only		 12.86 kB
4.825 kB
react-persona
Persona		 57.066 kB
17.821 kB
react-popover
Popover		 127.849 kB
40.049 kB
react-portal
Portal		 13.717 kB
4.886 kB
react-portal-compat
PortalCompatProvider		 7.944 kB
2.588 kB
react-positioning
usePositioning		 26.398 kB
9.539 kB
react-progress
ProgressBar		 17.428 kB
6.899 kB
react-provider
FluentProvider		 23.765 kB
8.662 kB
react-radio
Radio		 32.95 kB
10.252 kB
react-radio
RadioGroup		 15.354 kB
6.265 kB
react-select
Select		 28.609 kB
10.204 kB
react-slider
Slider		 39.949 kB
12.968 kB
react-spinbutton
SpinButton		 36.774 kB
11.789 kB
react-spinner
Spinner		 24.71 kB
8.35 kB
react-swatch-picker-preview
@fluentui/react-swatch-picker-preview - package		 108.371 kB
30.261 kB
react-switch
Switch		 35.14 kB
11.199 kB
react-table
DataGrid		 168.498 kB
46.732 kB
react-table
Table (Primitives only)		 45.324 kB
14.116 kB
react-table
Table as DataGrid		 137.918 kB
37.149 kB
react-table
Table (Selection only)		 76.334 kB
20.553 kB
react-table
Table (Sort only)		 74.977 kB
20.155 kB
react-tag-picker-preview
@fluentui/react-tag-picker-preview - package		 185.135 kB
55.305 kB
react-tags
InteractionTag		 15.284 kB
6.07 kB
react-tags
Tag		 29.035 kB
9.39 kB
react-tags
TagGroup		 82.012 kB
24.382 kB
react-text
Text - Default		 16.705 kB
6.57 kB
react-text
Text - Wrappers		 19.878 kB
6.897 kB
react-textarea
Textarea		 30.947 kB
10.477 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 35.666 kB
7.453 kB
react-theme
Teams: Light theme		 19.642 kB
5.549 kB
react-timepicker-compat
TimePicker		 105.149 kB
34.653 kB
react-toast
Toast (including Toaster)		 98.381 kB
29.706 kB
react-tooltip
Tooltip		 54.664 kB
19.206 kB
react-utilities
SSRProvider		 180 B
160 B
🤖 This report was generated against 6441cd2b0654e1b1404c5c3bcea59c7c66d9617a

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 9, 2024 •
edited

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 29 34 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 639 627 5000
Button mount 308 308 5000
Field mount 1144 1149 5000
FluentProvider mount 718 694 5000
FluentProviderWithTheme mount 76 96 10
FluentProviderWithTheme virtual-rerender 29 34 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 76 80 10
MakeStyles mount 868 839 50000
Persona mount 1763 1712 5000
SpinButton mount 1446 1380 5000

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Apr 9, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 9, 2024 •
edited

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ChatDuplicateMessagesPerf.default 159 139 1.14:1
ChatWithPopoverPerf.default 212 189 1.12:1
TableMinimalPerf.default 246 225 1.09:1
TextMinimalPerf.default 196 179 1.09:1
AvatarMinimalPerf.default 124 115 1.08:1
FlexMinimalPerf.default 161 149 1.08:1
FormMinimalPerf.default 223 207 1.08:1
ButtonSlotsPerf.default 318 296 1.07:1
AttachmentMinimalPerf.default 86 81 1.06:1
LoaderMinimalPerf.default 195 184 1.06:1
TreeWith60ListItems.default 90 85 1.06:1
AnimationMinimalPerf.default 308 292 1.05:1
ButtonMinimalPerf.default 90 86 1.05:1
DropdownManyItemsPerf.default 390 371 1.05:1
SegmentMinimalPerf.default 210 200 1.05:1
BoxMinimalPerf.default 196 189 1.04:1
PortalMinimalPerf.default 87 84 1.04:1
SliderMinimalPerf.default 749 723 1.04:1
TextAreaMinimalPerf.default 302 290 1.04:1
TreeMinimalPerf.default 494 474 1.04:1
CardMinimalPerf.default 307 298 1.03:1
HeaderMinimalPerf.default 209 202 1.03:1
HeaderSlotsPerf.default 461 446 1.03:1
ImageMinimalPerf.default 231 224 1.03:1
ProviderMergeThemesPerf.default 663 643 1.03:1
ProviderMinimalPerf.default 204 199 1.03:1
EmbedMinimalPerf.default 1866 1828 1.02:1
ListCommonPerf.default 382 376 1.02:1
ListMinimalPerf.default 304 298 1.02:1
MenuMinimalPerf.default 508 499 1.02:1
PopupMinimalPerf.default 349 343 1.02:1
SplitButtonMinimalPerf.default 2271 2236 1.02:1
StatusMinimalPerf.default 393 384 1.02:1
CarouselMinimalPerf.default 262 260 1.01:1
ChatMinimalPerf.default 428 424 1.01:1
LayoutMinimalPerf.default 194 192 1.01:1
ListWith60ListItems.default 359 357 1.01:1
MenuButtonMinimalPerf.default 947 940 1.01:1
TableManyItemsPerf.default 1103 1095 1.01:1
ToolbarMinimalPerf.default 523 518 1.01:1
AttachmentSlotsPerf.default 640 640 1:1
ButtonOverridesMissPerf.default 650 649 1:1
DatepickerMinimalPerf.default 3491 3487 1:1
DialogMinimalPerf.default 439 439 1:1
ItemLayoutMinimalPerf.default 714 713 1:1
LabelMinimalPerf.default 223 223 1:1
ListNestedPerf.default 319 318 1:1
RadioGroupMinimalPerf.default 254 255 1:1
ReactionMinimalPerf.default 215 215 1:1
DropdownMinimalPerf.default 1404 1425 0.99:1
GridMinimalPerf.default 185 187 0.99:1
SkeletonMinimalPerf.default 192 193 0.99:1
CustomToolbarPrototype.default 1439 1449 0.99:1
TooltipMinimalPerf.default 1219 1234 0.99:1
CheckboxMinimalPerf.default 1117 1141 0.98:1
DividerMinimalPerf.default 201 205 0.98:1
RefMinimalPerf.default 106 108 0.98:1
AccordionMinimalPerf.default 85 88 0.97:1
InputMinimalPerf.default 536 553 0.97:1
IconMinimalPerf.default 386 397 0.97:1
RosterPerf.default 1510 1576 0.96:1
VideoMinimalPerf.default 423 452 0.94:1
AlertMinimalPerf.default 148 162 0.91:1

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 9, 2024 •
edited

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 9, 2024 •
edited

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 632 661 5000
Breadcrumb mount 1682 1680 1000
Checkbox mount 1662 1703 5000
CheckboxBase mount 1465 1473 5000
ChoiceGroup mount 2950 3000 5000
ComboBox mount 653 652 1000
CommandBar mount 6196 6202 1000
ContextualMenu mount 12766 13670 1000
DefaultButton mount 750 755 5000
DetailsRow mount 2256 2193 5000
DetailsRowFast mount 2233 2179 5000
DetailsRowNoStyles mount 2017 1995 5000
Dialog mount 2628 2876 1000
DocumentCardTitle mount 235 236 1000
Dropdown mount 2001 1996 5000
FocusTrapZone mount 1131 1169 5000
FocusZone mount 1066 1060 5000
GroupedList mount 41837 42144 2
GroupedList virtual-rerender 20047 19965 2
GroupedList virtual-rerender-with-unmount 51059 50455 2
GroupedListV2 mount 221 212 2
GroupedListV2 virtual-rerender 212 212 2
GroupedListV2 virtual-rerender-with-unmount 227 242 2
IconButton mount 1094 1079 5000
Label mount 333 341 5000
Layer mount 2743 2697 5000
Link mount 380 394 5000
MenuButton mount 949 899 5000
MessageBar mount 21170 21198 5000
Nav mount 1992 1970 1000
OverflowSet mount 787 757 5000
Panel mount 2143 1790 1000
Persona mount 726 730 1000
Pivot mount 875 883 1000
PrimaryButton mount 828 847 5000
Rating mount 4632 4591 5000
SearchBox mount 911 904 5000
Shimmer mount 1866 1866 5000
Slider mount 1337 1333 5000
SpinButton mount 2839 2840 5000
Spinner mount 381 395 5000
SplitButton mount 1847 1808 5000
Stack mount 416 416 5000
StackWithIntrinsicChildren mount 853 841 5000
StackWithTextChildren mount 2561 2624 5000
SwatchColorPicker mount 6192 6222 5000
TagPicker mount 1473 1443 5000
Text mount 384 371 5000
TextField mount 906 959 5000
ThemeProvider mount 838 842 5000
ThemeProvider virtual-rerender 573 571 5000
ThemeProvider virtual-rerender-with-unmount 1280 1281 5000
Toggle mount 608 606 5000
buttonNative mount 194 194 5000

@Hotell Hotell self-requested a review April 10, 2024 11:59
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 11, 2024 •
edited

🕵 FluentUIV0 No visual regressions between this PR and main

@tomi-msft tomi-msft merged commit 45fb4d4 into microsoft:master Apr 17, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@Hotell Hotell Hotell approved these changes

@micahgodbolt micahgodbolt micahgodbolt approved these changes

@khmakoto khmakoto khmakoto approved these changes

@TristanWatanabe TristanWatanabe TristanWatanabe approved these changes

@layershifter layershifter layershifter approved these changes

@Mitch-At-Work Mitch-At-Work Mitch-At-Work approved these changes

@sopranopillow sopranopillow Awaiting requested review from sopranopillow sopranopillow is a code owner

@mltejera mltejera Awaiting requested review from mltejera mltejera is a code owner

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT GeoffCoxMSFT is a code owner

@ms-acalzaretto ms-acalzaretto Awaiting requested review from ms-acalzaretto ms-acalzaretto is a code owner

@behowell behowell Awaiting requested review from behowell behowell is a code owner

@spmonahan spmonahan Awaiting requested review from spmonahan spmonahan is a code owner

@smhigley smhigley Awaiting requested review from smhigley smhigley is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
April Project Cycle Q1 2024
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@tomi-msft @fabricteam @Hotell @micahgodbolt @khmakoto @TristanWatanabe @layershifter @Mitch-At-Work