Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: typo on griffel link and code example using compareMediaQueries #31039

Merged
merged 1 commit into from Apr 16, 2024

Conversation

njsokol
Copy link
Contributor

@njsokol njsokol commented Apr 12, 2024

Previous Behavior

(screen shots grabbed from the public docs site (live))

There was a broken link
image

There was also a code example that didn't match the expected
image

New Behavior

(screen shots grabbed from github preview)

The link is no longer broken
image

The code example matches the output example of properly ordered media queries.
image

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@njsokol njsokol marked this pull request as ready for review April 12, 2024 16:32
@njsokol njsokol requested review from a team as code owners April 12, 2024 16:32
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@layershifter
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@layershifter layershifter merged commit 6933b0e into microsoft:master Apr 16, 2024
18 checks passed
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants