fix: Button stories shouldn't shrink past min-content #31058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 38 | 25 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 644 | 642 | 5000 | |
| Button | mount | 294 | 305 | 5000 | |
| Field | mount | 1120 | 1090 | 5000 | |
| FluentProvider | mount | 690 | 701 | 5000 | |
| FluentProviderWithTheme | mount | 85 | 77 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 38 | 25 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 79 | 84 | 10 | |
| MakeStyles | mount | 829 | 867 | 50000 | |
| Persona | mount | 1749 | 1746 | 5000 | |
| SpinButton | mount | 1410 | 1394 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
📊 Bundle size report✅ No changes found |
🕵 fluentuiv9 No visual regressions between this PR and main |
khmakoto
approved these changes
Apr 15, 2024
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story-only styles, lots of adding
min-width: min-content:DPreviously some text was getting clipped when there was a word that went longer than the
min-width: 96pxon Button.