Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-tag-picker): ensure navigation between TagPickerGroup and TagPickerInput #31085

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Apr 17, 2024

Previous Behavior

New Behavior

  1. adds role listbox to TagPickerGroup
  2. LeftArrow on beginning of the TagPickerInput should focus on the last focusable element inside TagPickerGroup
  3. RigthArrow on the last Tag of the TagPickerGroup should focus trigger
  4. adds tests to ensure navigation behaviours

Related Issue(s)

  • Fixes #

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone Apr 17, 2024
@bsunderhus bsunderhus self-assigned this Apr 17, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 17, 2024

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-tag-picker-preview
@fluentui/react-tag-picker-preview - package
185.281 kB
55.349 kB
185.641 kB
54.844 kB
360 B
-505 B

🤖 This report was generated against b2c686709da13ad15b934f264f6303ca2db8ee52

Copy link

codesandbox-ci bot commented Apr 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@bsunderhus bsunderhus marked this pull request as ready for review April 17, 2024 12:42
@bsunderhus bsunderhus requested a review from a team as a code owner April 17, 2024 12:42
@bsunderhus bsunderhus force-pushed the react-tag-picker/chore-ensure-navigation-beteween-TagPickerGroup-and-TagPickerInput branch from 02b97c9 to 4cfe8dd Compare April 17, 2024 13:03
@bsunderhus bsunderhus merged commit 5c4fa80 into microsoft:master Apr 18, 2024
18 checks passed
@bsunderhus bsunderhus deleted the react-tag-picker/chore-ensure-navigation-beteween-TagPickerGroup-and-TagPickerInput branch April 18, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants