Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scripts-tasks): don't run swc:compile task twice #31100

Merged
merged 2 commits into from Apr 17, 2024
Merged

fix(scripts-tasks): don't run swc:compile task twice #31100

merged 2 commits into from Apr 17, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Apr 17, 2024

Previous Behavior

  • swc:compile is being run twice for every react-components:build task
  • api-extractor task ends up with failure if no config is present
    • image

New Behavior

Related Issue(s)

  • Fixes #

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone Apr 17, 2024
@Hotell Hotell marked this pull request as ready for review April 17, 2024 18:32
@Hotell Hotell requested a review from a team as a code owner April 17, 2024 18:32
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 43 37 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 643 645 5000
Button mount 312 299 5000
Field mount 1132 1122 5000
FluentProvider mount 701 700 5000
FluentProviderWithTheme mount 88 80 10
FluentProviderWithTheme virtual-rerender 43 37 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 73 73 10
MakeStyles mount 850 880 50000
Persona mount 1748 1698 5000
SpinButton mount 1393 1371 5000
SwatchPicker mount 1531 1509 5000

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Hotell Hotell enabled auto-merge (squash) April 17, 2024 18:43
@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 93 80 1.16:1
PortalMinimalPerf.default 93 83 1.12:1
CardMinimalPerf.default 322 295 1.09:1
GridMinimalPerf.default 195 179 1.09:1
LayoutMinimalPerf.default 206 193 1.07:1
ProviderMinimalPerf.default 208 197 1.06:1
ChatMinimalPerf.default 435 414 1.05:1
DividerMinimalPerf.default 215 204 1.05:1
TextAreaMinimalPerf.default 303 289 1.05:1
AttachmentSlotsPerf.default 654 626 1.04:1
ChatDuplicateMessagesPerf.default 166 160 1.04:1
ChatWithPopoverPerf.default 200 193 1.04:1
FlexMinimalPerf.default 156 150 1.04:1
LoaderMinimalPerf.default 202 195 1.04:1
MenuButtonMinimalPerf.default 988 948 1.04:1
SkeletonMinimalPerf.default 204 197 1.04:1
TreeMinimalPerf.default 492 475 1.04:1
BoxMinimalPerf.default 204 199 1.03:1
ButtonMinimalPerf.default 90 87 1.03:1
CheckboxMinimalPerf.default 1140 1110 1.03:1
LabelMinimalPerf.default 219 213 1.03:1
TableMinimalPerf.default 232 226 1.03:1
ToolbarMinimalPerf.default 551 533 1.03:1
TreeWith60ListItems.default 91 88 1.03:1
AccordionMinimalPerf.default 87 85 1.02:1
CarouselMinimalPerf.default 263 259 1.02:1
DatepickerMinimalPerf.default 3604 3526 1.02:1
DialogMinimalPerf.default 437 429 1.02:1
ListMinimalPerf.default 310 305 1.02:1
SplitButtonMinimalPerf.default 2280 2230 1.02:1
TableManyItemsPerf.default 1115 1094 1.02:1
DropdownMinimalPerf.default 1420 1404 1.01:1
EmbedMinimalPerf.default 1875 1856 1.01:1
HeaderMinimalPerf.default 215 212 1.01:1
HeaderSlotsPerf.default 451 448 1.01:1
ItemLayoutMinimalPerf.default 699 692 1.01:1
RosterPerf.default 1595 1572 1.01:1
TooltipMinimalPerf.default 1274 1264 1.01:1
ButtonOverridesMissPerf.default 656 655 1:1
DropdownManyItemsPerf.default 391 390 1:1
ListCommonPerf.default 390 389 1:1
ListNestedPerf.default 328 329 1:1
PopupMinimalPerf.default 350 349 1:1
IconMinimalPerf.default 379 380 1:1
AnimationMinimalPerf.default 298 301 0.99:1
MenuMinimalPerf.default 501 506 0.99:1
ProviderMergeThemesPerf.default 641 649 0.99:1
RefMinimalPerf.default 112 113 0.99:1
StatusMinimalPerf.default 396 401 0.99:1
TextMinimalPerf.default 192 193 0.99:1
FormMinimalPerf.default 220 225 0.98:1
ListWith60ListItems.default 368 377 0.98:1
RadioGroupMinimalPerf.default 261 265 0.98:1
SegmentMinimalPerf.default 189 192 0.98:1
SliderMinimalPerf.default 738 751 0.98:1
CustomToolbarPrototype.default 1464 1488 0.98:1
ButtonSlotsPerf.default 305 313 0.97:1
InputMinimalPerf.default 542 556 0.97:1
VideoMinimalPerf.default 443 456 0.97:1
AvatarMinimalPerf.default 104 108 0.96:1
ImageMinimalPerf.default 222 231 0.96:1
ReactionMinimalPerf.default 215 226 0.95:1
AlertMinimalPerf.default 154 166 0.93:1

@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 627 635 5000
Breadcrumb mount 1657 1673 1000
Checkbox mount 1697 1709 5000
CheckboxBase mount 1469 1472 5000
ChoiceGroup mount 2935 2946 5000
ComboBox mount 662 665 1000
CommandBar mount 6242 6264 1000
ContextualMenu mount 12144 12279 1000
DefaultButton mount 769 763 5000
DetailsRow mount 2228 2182 5000
DetailsRowFast mount 2161 2181 5000
DetailsRowNoStyles mount 2010 2005 5000
Dialog mount 2764 2824 1000
DocumentCardTitle mount 225 223 1000
Dropdown mount 1999 2001 5000
FocusTrapZone mount 1124 1137 5000
FocusZone mount 1085 1090 5000
GroupedList mount 41646 42104 2
GroupedList virtual-rerender 19876 20112 2
GroupedList virtual-rerender-with-unmount 50913 50672 2
GroupedListV2 mount 226 232 2
GroupedListV2 virtual-rerender 205 205 2
GroupedListV2 virtual-rerender-with-unmount 230 229 2
IconButton mount 1099 1085 5000
Label mount 334 328 5000
Layer mount 2740 2741 5000
Link mount 402 383 5000
MenuButton mount 947 942 5000
MessageBar mount 21467 21570 5000
Nav mount 1924 1972 1000
OverflowSet mount 775 787 5000
Panel mount 1820 1790 1000
Persona mount 759 760 1000
Pivot mount 855 866 1000
PrimaryButton mount 857 842 5000
Rating mount 4601 4582 5000
SearchBox mount 920 911 5000
Shimmer mount 1853 1886 5000
Slider mount 1296 1322 5000
SpinButton mount 2906 2867 5000
Spinner mount 378 376 5000
SplitButton mount 1811 1854 5000
Stack mount 411 414 5000
StackWithIntrinsicChildren mount 857 853 5000
StackWithTextChildren mount 2597 2577 5000
SwatchColorPicker mount 6149 6195 5000
TagPicker mount 1513 1455 5000
Text mount 375 376 5000
TextField mount 939 924 5000
ThemeProvider mount 837 838 5000
ThemeProvider virtual-rerender 591 588 5000
ThemeProvider virtual-rerender-with-unmount 1289 1280 5000
Toggle mount 580 624 5000
buttonNative mount 196 198 5000

@Hotell Hotell merged commit b888e95 into microsoft:master Apr 17, 2024
21 checks passed
@Hotell Hotell deleted the perf/speed-up-beachbal-config-creation-fix branch April 17, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TristanWatanabe TristanWatanabe TristanWatanabe approved these changes

Assignees
No one assigned
Labels
Area: Build System Fluent UI react (v8) Issues about @fluentui/react (v8) Fluent UI react-components (v9) Type: Regression 🌩🌩 Lightning strikes twice.
Projects
None yet
Milestone
April Project Cycle Q1 2024
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Hotell @fabricteam @TristanWatanabe