Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtualizer: Update IO/Timer to use Fluent hooks #31250

Conversation

Mitch-At-Work
Copy link
Contributor

Previous Behavior

Used native IO and timer functions

New Behavior

Uses equivalent Fluent hooks.

Related Issue(s)

@fabricteam
Copy link
Collaborator

fabricteam commented May 1, 2024

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 623 619 5000
Button mount 302 326 5000
Field mount 1123 1137 5000
FluentProvider mount 715 704 5000
FluentProviderWithTheme mount 77 84 10
FluentProviderWithTheme virtual-rerender 35 38 10
FluentProviderWithTheme virtual-rerender-with-unmount 78 83 10
MakeStyles mount 860 858 50000
Persona mount 1782 1753 5000
SpinButton mount 1448 1379 5000
SwatchPicker mount 1550 1525 5000

Copy link

codesandbox-ci bot commented May 1, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented May 1, 2024

📊 Bundle size report

✅ No changes found

@Mitch-At-Work Mitch-At-Work marked this pull request as ready for review May 1, 2024 20:23
@Mitch-At-Work Mitch-At-Work requested a review from a team as a code owner May 1, 2024 20:23
@Mitch-At-Work Mitch-At-Work merged commit 2939b63 into microsoft:master May 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants