feat: use ariaNotify when available for AriaLiveAnnouncer #31251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 634 | 616 | 5000 | |
| Button | mount | 297 | 314 | 5000 | |
| Field | mount | 1124 | 1124 | 5000 | |
| FluentProvider | mount | 709 | 695 | 5000 | |
| FluentProviderWithTheme | mount | 79 | 75 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 34 | 34 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 76 | 74 | 10 | |
| MakeStyles | mount | 850 | 864 | 50000 | |
| Persona | mount | 1754 | 1763 | 5000 | |
| SpinButton | mount | 1296 | 1361 | 5000 | |
| SwatchPicker | mount | 1495 | 1526 | 5000 |
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
🕵 fluentuiv9 No visual regressions between this PR and main |
spmonahan
approved these changes
May 1, 2024
packages/react-components/react-aria/src/AriaLiveAnnouncer/useAriaNotifyAnnounce.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-aria/src/AriaLiveAnnouncer/useAriaNotifyAnnounce.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-aria/src/AriaLiveAnnouncer/useDomAnnounce.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-aria/src/AriaLiveAnnouncer/useDomAnnounce.ts
Show resolved
Hide resolved
layershifter
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ariaNotifyis a new live notification API in ARIA (ref: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/Accessibility/AriaNotify/explainer.md). The Edge team has implemented this in canary builds of Edge and Chrome, behind a flag. The next step towards gettingariaNotifyinto the spec is to have real-world implementations to test against, which is why we agreed to test this out in Fluent & Fluent AI.This won't change the behavior for people who haven't turned on the flag (so in practice, all our real-world customers) until
ariaNotifyis shipped as a stable feature. But it should allow us, Edge, and screen reader vendors to test how well this works as an API in practice.