Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: usePositioning - respect overflowBoundaryPadding when autoSize on #31277

Conversation

george-cz
Copy link
Contributor

Previous Behavior

When autoSize is enabled in positioning props, it was ignoring overflowBoundaryPadding settings. See #30901 for details.

New Behavior

overflowBoundaryPadding is now respected when autoSize is enabled.

Screenshot 2024-05-06 at 15 17 26

Related Issue(s)

@fabricteam
Copy link
Collaborator

fabricteam commented May 6, 2024

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-combobox
Combobox (including child components)
105.372 kB
33.874 kB
105.464 kB
33.885 kB
92 B
11 B
react-combobox
Dropdown (including child components)
106.844 kB
33.85 kB
106.936 kB
33.86 kB
92 B
10 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
221.733 kB
62.557 kB
221.825 kB
62.568 kB
92 B
11 B
react-components
react-components: entire library
1.101 MB
267.232 kB
1.101 MB
267.249 kB
92 B
17 B
react-datepicker-compat
DatePicker Compat
227.897 kB
63.584 kB
227.989 kB
63.592 kB
92 B
8 B
react-menu
Menu (including children components)
154.292 kB
46.144 kB
154.383 kB
46.161 kB
91 B
17 B
react-menu
Menu (including selectable components)
156.978 kB
46.695 kB
157.069 kB
46.71 kB
91 B
15 B
react-popover
Popover
128.578 kB
40.244 kB
128.669 kB
40.26 kB
91 B
16 B
react-positioning
usePositioning
26.398 kB
9.539 kB
26.489 kB
9.552 kB
91 B
13 B
react-tag-picker-preview
@fluentui/react-tag-picker-preview - package
188.778 kB
55.767 kB
188.87 kB
55.778 kB
92 B
11 B
react-timepicker-compat
TimePicker
107.39 kB
35.223 kB
107.482 kB
35.234 kB
92 B
11 B
react-tooltip
Tooltip
55.11 kB
19.268 kB
55.201 kB
19.285 kB
91 B
17 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-alert
Alert
83.737 kB
23.475 kB
react-avatar
Avatar
50.175 kB
15.944 kB
react-avatar
AvatarGroup
19.702 kB
7.794 kB
react-avatar
AvatarGroupItem
64.829 kB
20.272 kB
react-breadcrumb
@fluentui/react-breadcrumb - package
117.263 kB
32.241 kB
react-components
react-components: Button, FluentProvider & webLightTheme
71.55 kB
20.584 kB
react-components
react-components: FluentProvider & webLightTheme
44.037 kB
14.418 kB
react-dialog
Dialog (including children components)
117.345 kB
36.161 kB
react-persona
Persona
57.066 kB
17.821 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-table
DataGrid
169.274 kB
46.907 kB
react-table
Table (Primitives only)
45.77 kB
14.174 kB
react-table
Table as DataGrid
138.358 kB
37.213 kB
react-table
Table (Selection only)
76.774 kB
20.602 kB
react-table
Table (Sort only)
75.417 kB
20.205 kB
react-tags
InteractionTag
15.299 kB
6.08 kB
react-tags
Tag
29.092 kB
9.418 kB
react-tags
TagGroup
82.49 kB
24.46 kB
🤖 This report was generated against 23ed4a226a8126494acae2b025810678c77537d3

@george-cz george-cz marked this pull request as ready for review May 6, 2024 13:29
@george-cz george-cz requested a review from a team as a code owner May 6, 2024 13:29
@fabricteam
Copy link
Collaborator

fabricteam commented May 6, 2024

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 651 632 5000
Button mount 316 320 5000
Field mount 1148 1144 5000
FluentProvider mount 709 712 5000
FluentProviderWithTheme mount 74 95 10
FluentProviderWithTheme virtual-rerender 37 37 10
FluentProviderWithTheme virtual-rerender-with-unmount 74 82 10
MakeStyles mount 845 868 50000
Persona mount 1799 1716 5000
SpinButton mount 1388 1355 5000
SwatchPicker mount 1544 1607 5000

Copy link

codesandbox-ci bot commented May 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@YuanboXue-Amber
Copy link
Contributor

Could you add a screenshot test? We have screenshot tests for autoSize at

@george-cz george-cz requested a review from a team as a code owner May 7, 2024 08:03
@george-cz george-cz merged commit 2f4006a into microsoft:master May 7, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Menu autosize positioning does not apply boundary padding vertically
3 participants