-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: usePositioning - respect overflowBoundaryPadding when autoSize on #31277
Merged
george-cz
merged 6 commits into
microsoft:master
from
george-cz:jirivyhnalek/fix-positioning-autosize-overflowpadding
May 7, 2024
Merged
fix: usePositioning - respect overflowBoundaryPadding when autoSize on #31277
george-cz
merged 6 commits into
microsoft:master
from
george-cz:jirivyhnalek/fix-positioning-autosize-overflowpadding
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 651 | 632 | 5000 | |
Button | mount | 316 | 320 | 5000 | |
Field | mount | 1148 | 1144 | 5000 | |
FluentProvider | mount | 709 | 712 | 5000 | |
FluentProviderWithTheme | mount | 74 | 95 | 10 | |
FluentProviderWithTheme | virtual-rerender | 37 | 37 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 74 | 82 | 10 | |
MakeStyles | mount | 845 | 868 | 50000 | |
Persona | mount | 1799 | 1716 | 5000 | |
SpinButton | mount | 1388 | 1355 | 5000 | |
SwatchPicker | mount | 1544 | 1607 | 5000 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Could you add a screenshot test? We have screenshot tests for autoSize at
|
YuanboXue-Amber
approved these changes
May 6, 2024
YuanboXue-Amber
approved these changes
May 7, 2024
fabricteam
reviewed
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
When
autoSize
is enabled in positioning props, it was ignoringoverflowBoundaryPadding
settings. See #30901 for details.New Behavior
overflowBoundaryPadding
is now respected whenautoSize
is enabled.Related Issue(s)