Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(react-swatch-picker): added description and best practices #31280

Conversation

ValentinaKozlova
Copy link
Contributor

New Behavior

  • Returned back BestPractices because we don't have it yet on Fluent 2 website
  • Added description to all the stories
  • Changed order of stories
  • Made image example smaller
  • Removed images from Layout stories
  • Added "MixedSwatches" story
  • Made "Shape" story using the same layout everywhere

@ValentinaKozlova ValentinaKozlova self-assigned this May 6, 2024
@ValentinaKozlova ValentinaKozlova mentioned this pull request May 6, 2024
28 tasks
@ValentinaKozlova ValentinaKozlova marked this pull request as ready for review May 6, 2024 15:48
@ValentinaKozlova ValentinaKozlova requested a review from a team as a code owner May 6, 2024 15:48
Copy link

codesandbox-ci bot commented May 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented May 6, 2024

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented May 6, 2024

🕵 fluentuiv9 No visual regressions between this PR and main

@Hotell Hotell requested a review from marcosmoura May 7, 2024 12:12
@ValentinaKozlova ValentinaKozlova enabled auto-merge (squash) May 9, 2024 12:42
@ValentinaKozlova ValentinaKozlova merged commit 28b1bef into microsoft:master May 9, 2024
16 of 18 checks passed
@ValentinaKozlova ValentinaKozlova deleted the docs/swatch-picker-finalize-stories branch May 9, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants