Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update the Overflow docs with information about forwarding ref when custom component is rendered #31292

Conversation

george-cz
Copy link
Contributor

Fixes #27652

@george-cz george-cz requested a review from a team as a code owner May 7, 2024 09:10
@george-cz george-cz requested a review from ling1726 May 7, 2024 09:12
Copy link

codesandbox-ci bot commented May 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented May 7, 2024

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented May 7, 2024

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 610 620 5000
Button mount 316 298 5000
Field mount 1130 1106 5000
FluentProvider mount 710 715 5000
FluentProviderWithTheme mount 82 79 10
FluentProviderWithTheme virtual-rerender 33 29 10
FluentProviderWithTheme virtual-rerender-with-unmount 78 81 10
MakeStyles mount 857 850 50000
Persona mount 1729 1658 5000
SpinButton mount 1404 1419 5000
SwatchPicker mount 1535 1530 5000

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@george-cz george-cz merged commit 866a1c7 into microsoft:master May 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: Document that Overflow components need to be wrapped around components that forward ref
3 participants