Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move styles declared in useDisableBodyScroll() to a separate file #31299

Merged
merged 1 commit into from
May 7, 2024

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented May 7, 2024

New Behavior

All makeStyles() and makeResetStyles() calls should be declared in *.styles.ts files.

@layershifter layershifter requested a review from a team as a code owner May 7, 2024 15:13
@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone May 7, 2024
@layershifter layershifter enabled auto-merge (squash) May 7, 2024 15:15
Copy link

codesandbox-ci bot commented May 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender-with-unmount 70 69 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 624 634 5000
Button mount 320 316 5000
Field mount 1134 1114 5000
FluentProvider mount 724 710 5000
FluentProviderWithTheme mount 80 88 10
FluentProviderWithTheme virtual-rerender 34 31 10
FluentProviderWithTheme virtual-rerender-with-unmount 70 69 10 Possible regression
MakeStyles mount 869 871 50000
Persona mount 1728 1683 5000
SpinButton mount 1368 1364 5000
SwatchPicker mount 1542 1534 5000

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library
1.101 MB
267.249 kB
1.101 MB
267.271 kB
124 B
22 B
react-dialog
Dialog (including children components)
117.345 kB
36.161 kB
100.769 kB
30.092 kB
-16.576 kB
-6.069 kB
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
71.55 kB
20.584 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
221.825 kB
62.568 kB
react-components
react-components: FluentProvider & webLightTheme
44.037 kB
14.418 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
🤖 This report was generated against 87e288763044408ec4e9a0176d3c54a92f034ed3

@layershifter layershifter merged commit 6533854 into microsoft:master May 7, 2024
17 of 19 checks passed
@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants