Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expand button should be disabled when Combobox is disabled #31300

Merged
merged 2 commits into from
May 7, 2024

Conversation

smhigley
Copy link
Contributor

@smhigley smhigley commented May 7, 2024

This is a small semantics-only fix; the functionality to disabled expand/collapse is already there.

Previous Behavior

When the combobox is disabled, the expand/collapse button was not also semantically disabled.

New Behavior

Adds aria-disabled to the button based on the disabled combobox state.

Related Issue(s)

@smhigley smhigley requested review from a team as code owners May 7, 2024 17:27
@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone May 7, 2024
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 33 41 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 631 636 5000
Button mount 301 303 5000
Field mount 1115 1165 5000
FluentProvider mount 700 717 5000
FluentProviderWithTheme mount 85 87 10
FluentProviderWithTheme virtual-rerender 33 41 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 79 81 10
MakeStyles mount 863 874 50000
Persona mount 1770 1698 5000
SpinButton mount 1365 1367 5000
SwatchPicker mount 1540 1526 5000

Copy link

codesandbox-ci bot commented May 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-combobox
Combobox (including child components)
105.556 kB
33.9 kB
105.599 kB
33.902 kB
43 B
2 B
react-components
react-components: entire library
1.101 MB
267.271 kB
1.101 MB
267.303 kB
43 B
32 B
react-timepicker-compat
TimePicker
107.574 kB
35.25 kB
107.617 kB
35.278 kB
43 B
28 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-combobox
Dropdown (including child components)
107.028 kB
33.875 kB
react-components
react-components: Button, FluentProvider & webLightTheme
71.55 kB
20.584 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
221.825 kB
62.568 kB
react-components
react-components: FluentProvider & webLightTheme
44.037 kB
14.418 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-tag-picker-preview
@fluentui/react-tag-picker-preview - package
188.962 kB
55.803 kB
🤖 This report was generated against 6533854bc4236dd9070538dc89971a190e6689d3

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@smhigley smhigley merged commit 0df0796 into microsoft:master May 7, 2024
19 checks passed
@smhigley smhigley deleted the combobox-disable-expand branch May 7, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants