Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Fixing broken links across the repository #31303

Merged
merged 5 commits into from
May 7, 2024

Conversation

alex-y-z
Copy link
Contributor

@alex-y-z alex-y-z commented May 7, 2024

Previous Behavior

Several links on the documentation site, such as the styling handbook, had defunct URLs.

New Behavior

They now point to their respective correct locations in the repo.

@alex-y-z alex-y-z requested review from a team as code owners May 7, 2024 19:20
@alex-y-z
Copy link
Contributor Author

alex-y-z commented May 7, 2024

@microsoft-github-policy-service agree

Copy link

codesandbox-ci bot commented May 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@khmakoto
Copy link
Member

khmakoto commented May 7, 2024

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@khmakoto khmakoto changed the title Fix documentation link rot fix(docs): Fixing broken links across the repository May 7, 2024
@khmakoto khmakoto self-assigned this May 7, 2024
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 647 643 5000
Button mount 308 321 5000
Field mount 1130 1141 5000
FluentProvider mount 732 714 5000
FluentProviderWithTheme mount 84 81 10
FluentProviderWithTheme virtual-rerender 34 34 10
FluentProviderWithTheme virtual-rerender-with-unmount 75 77 10
MakeStyles mount 845 916 50000
Persona mount 1774 1746 5000
SpinButton mount 1370 1405 5000
SwatchPicker mount 1532 1544 5000

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
CarouselMinimalPerf.default 275 249 1.1:1
ChatWithPopoverPerf.default 203 185 1.1:1
AttachmentSlotsPerf.default 656 610 1.08:1
ButtonSlotsPerf.default 322 297 1.08:1
DividerMinimalPerf.default 220 204 1.08:1
ReactionMinimalPerf.default 221 205 1.08:1
StatusMinimalPerf.default 397 369 1.08:1
AlertMinimalPerf.default 157 147 1.07:1
ButtonMinimalPerf.default 90 84 1.07:1
TreeWith60ListItems.default 87 81 1.07:1
ChatDuplicateMessagesPerf.default 152 144 1.06:1
RefMinimalPerf.default 116 109 1.06:1
TextAreaMinimalPerf.default 297 280 1.06:1
BoxMinimalPerf.default 203 193 1.05:1
FlexMinimalPerf.default 156 149 1.05:1
SkeletonMinimalPerf.default 207 198 1.05:1
AnimationMinimalPerf.default 305 296 1.03:1
ProviderMinimalPerf.default 203 198 1.03:1
RadioGroupMinimalPerf.default 275 266 1.03:1
TableMinimalPerf.default 238 231 1.03:1
TreeMinimalPerf.default 489 475 1.03:1
VideoMinimalPerf.default 444 430 1.03:1
AttachmentMinimalPerf.default 82 80 1.02:1
ChatMinimalPerf.default 435 428 1.02:1
ItemLayoutMinimalPerf.default 708 695 1.02:1
SplitButtonMinimalPerf.default 2253 2219 1.02:1
TextMinimalPerf.default 202 199 1.02:1
CustomToolbarPrototype.default 1471 1449 1.02:1
AvatarMinimalPerf.default 112 111 1.01:1
HeaderSlotsPerf.default 472 469 1.01:1
ImageMinimalPerf.default 234 231 1.01:1
LayoutMinimalPerf.default 196 195 1.01:1
ListNestedPerf.default 333 331 1.01:1
SegmentMinimalPerf.default 203 201 1.01:1
SliderMinimalPerf.default 749 741 1.01:1
IconMinimalPerf.default 395 393 1.01:1
TableManyItemsPerf.default 1100 1093 1.01:1
ToolbarMinimalPerf.default 539 534 1.01:1
DatepickerMinimalPerf.default 3522 3531 1:1
FormMinimalPerf.default 218 217 1:1
MenuButtonMinimalPerf.default 939 940 1:1
PopupMinimalPerf.default 352 353 1:1
ProviderMergeThemesPerf.default 651 650 1:1
TooltipMinimalPerf.default 1243 1246 1:1
ButtonOverridesMissPerf.default 641 646 0.99:1
DialogMinimalPerf.default 438 442 0.99:1
GridMinimalPerf.default 191 193 0.99:1
RosterPerf.default 1549 1560 0.99:1
AccordionMinimalPerf.default 83 85 0.98:1
CheckboxMinimalPerf.default 1127 1146 0.98:1
DropdownMinimalPerf.default 1405 1430 0.98:1
EmbedMinimalPerf.default 1853 1885 0.98:1
InputMinimalPerf.default 520 530 0.98:1
MenuMinimalPerf.default 507 518 0.98:1
CardMinimalPerf.default 301 311 0.97:1
DropdownManyItemsPerf.default 386 398 0.97:1
HeaderMinimalPerf.default 205 211 0.97:1
LabelMinimalPerf.default 218 224 0.97:1
ListCommonPerf.default 382 400 0.96:1
ListWith60ListItems.default 357 370 0.96:1
ListMinimalPerf.default 296 312 0.95:1
LoaderMinimalPerf.default 180 190 0.95:1
PortalMinimalPerf.default 73 83 0.88:1

@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 634 666 5000
Breadcrumb mount 1707 1698 1000
Checkbox mount 1700 1718 5000
CheckboxBase mount 1508 1485 5000
ChoiceGroup mount 3012 3016 5000
ComboBox mount 673 707 1000
CommandBar mount 6895 6831 1000
ContextualMenu mount 14700 15756 1000
DefaultButton mount 786 797 5000
DetailsRow mount 2291 2258 5000
DetailsRowFast mount 2244 2216 5000
DetailsRowNoStyles mount 2073 2044 5000
Dialog mount 2818 2653 1000
DocumentCardTitle mount 236 244 1000
Dropdown mount 2019 2037 5000
FocusTrapZone mount 1189 1184 5000
FocusZone mount 1072 1116 5000
GroupedList mount 43018 42966 2
GroupedList virtual-rerender 18254 20569 2
GroupedList virtual-rerender-with-unmount 51435 53709 2
GroupedListV2 mount 228 238 2
GroupedListV2 virtual-rerender 225 225 2
GroupedListV2 virtual-rerender-with-unmount 248 240 2
IconButton mount 1114 1153 5000
Label mount 350 340 5000
Layer mount 2776 2770 5000
Link mount 408 391 5000
MenuButton mount 1003 991 5000
MessageBar mount 21751 21745 5000
Nav mount 2086 2051 1000
OverflowSet mount 815 803 5000
Panel mount 1788 1855 1000
Persona mount 761 756 1000
Pivot mount 925 897 1000
PrimaryButton mount 948 949 5000
Rating mount 4784 4847 5000
SearchBox mount 927 917 5000
Shimmer mount 1912 1927 5000
Slider mount 1372 1376 5000
SpinButton mount 3015 2988 5000
Spinner mount 399 398 5000
SplitButton mount 1887 1899 5000
Stack mount 414 416 5000
StackWithIntrinsicChildren mount 878 855 5000
StackWithTextChildren mount 2697 2668 5000
SwatchColorPicker mount 6543 6401 5000
TagPicker mount 1475 1449 5000
Text mount 364 380 5000
TextField mount 957 954 5000
ThemeProvider mount 842 867 5000
ThemeProvider virtual-rerender 604 575 5000
ThemeProvider virtual-rerender-with-unmount 1293 1291 5000
Toggle mount 629 594 5000
buttonNative mount 190 188 5000

@khmakoto khmakoto merged commit 73c2170 into microsoft:master May 7, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants