Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG 8768094, BUG 8813873 Updated opacity value to card title to fix color contrast issue #31307

Merged
merged 27 commits into from
May 17, 2024
Merged

BUG 8768094, BUG 8813873 Updated opacity value to card title to fix color contrast issue #31307

Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
4c9893c
Bug Fix 8856966, 8853539
v-baambati Apr 30, 2024
348c9e2
Merge branch 'master' into AccessibilityBugFixes
v-baambati Apr 30, 2024
ce38cb2
Merge branch 'master' of https://github.com/microsoft/fluentui into A…
v-baambati Apr 30, 2024
5cbd785
accessibility issue fix
v-baambati May 2, 2024
d0fd296
Merge branch 'AccessibilityBugFixes' of https://github.com/v-baambati…
v-baambati May 2, 2024
b119145
added hide tooltip feature in stacked bar chart example
v-baambati May 2, 2024
9d4f843
updated change file data
v-baambati May 2, 2024
8e86cb1
added hide tooltip feature in stacked bar chart example
v-baambati May 2, 2024
fc47b01
Merge branch 'master' into AccessibilityBugFixes
v-baambati May 6, 2024
224af4d
Merge branch 'master' of https://github.com/microsoft/fluentui into A…
v-baambati May 6, 2024
ab34ea2
removed base class changes
v-baambati May 6, 2024
a4472de
Merge branch 'AccessibilityBugFixes' of https://github.com/v-baambati…
v-baambati May 6, 2024
ee99bbd
updated aria label value for custom accessibility
v-baambati May 6, 2024
6034e21
custom callout issue fix in donut chart
v-baambati May 6, 2024
96279a7
resolved build errors
v-baambati May 7, 2024
8eb30c9
Merge branch 'master' into AccessibilityBugFixes
v-baambati May 7, 2024
c0e0978
Merge branch 'master' into AccessibilityBugFixes
v-baambati May 7, 2024
194eea9
resolved PR comments
v-baambati May 7, 2024
50b8bd3
enables focus for events in line chart with keyboard
v-baambati May 8, 2024
3562a4f
Merge branch 'master' of https://github.com/microsoft/fluentui into A…
v-baambati May 8, 2024
847abc6
added chnage file
v-baambati May 8, 2024
c7b5b99
resolved callout subtext accessibility issue
v-baambati May 8, 2024
16e89c2
Merge branch 'master' of https://github.com/microsoft/fluentui into A…
v-baambati May 14, 2024
6536505
updated snapshots for accessibility bug fix
v-baambati May 16, 2024
33a8837
removed line chart event related changes
v-baambati May 17, 2024
1535cc4
Merge branch 'master' of https://github.com/microsoft/fluentui into A…
v-baambati May 17, 2024
c2684b7
updated change file desc
v-baambati May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-charting-d3660b0d-d2af-403a-bc19-a05978feeee9.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
AtishayMsft marked this conversation as resolved.
Show resolved Hide resolved
"type": "patch",
"comment": "Enabled focus for events in line chart with keyboard",
"packageName": "@fluentui/react-charting",
"email": "132879294+v-baambati@users.noreply.github.com",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/react-charting/src/components/CommonComponents/CartesianChart.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export const getStyles = (props: ICartesianChartStyleProps): ICartesianChartStyl
{
...fonts.small,
lineHeight: '16px',
opacity: '0.8',
opacity: '0.85',
color: theme.semanticColors.bodySubtext,
},
],
Expand Down
2 changes: 1 addition & 1 deletion packages/react-charting/src/components/GaugeChart/GaugeChart.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export const getStyles = (props: IGaugeChartStyleProps): IGaugeChartStyles => {
{
...theme.fonts.small,
lineHeight: '16px',
opacity: '0.8',
opacity: '0.85',
v-baambati marked this conversation as resolved.
Show resolved Hide resolved
color: theme.semanticColors.bodySubtext,
},
],
Expand Down
2 changes: 1 addition & 1 deletion packages/react-charting/src/components/LineChart/eventAnnotation/LabelLink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export const LabelLink: React.FunctionComponent<ILabelLinkProps> = props => {

return (
<>
<g ref={gRef} onClick={onClick} data-is-focusable={false} style={{ cursor: 'pointer' }}>
<g ref={gRef} onClick={onClick} data-is-focusable={true} style={{ cursor: 'pointer' }}>
v-baambati marked this conversation as resolved.
Show resolved Hide resolved
<Textbox
text={text}
x={props.labelDef.x}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-charting/src/utilities/ChartHoverCard/ChartHoverCard.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const getChartHoverCardStyles = (props: IChartHoverCardStyleProps): IChar
theme.fonts.small,
{
lineHeight: '16px',
opacity: '0.8',
opacity: '0.85',
color: theme.semanticColors.bodySubtext,
},
],
Expand Down