Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(react-tag-picker): release stable version #31321

Merged
merged 2 commits into from
May 9, 2024
Merged

chore(react-tag-picker): release stable version #31321

merged 2 commits into from
May 9, 2024

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented May 9, 2024 •
edited

Previous Behavior

New Behavior

Follows up on Stable release for @fluentui/react-tag-picker package

Related Issue(s)

@bsunderhus bsunderhus self-assigned this May 9, 2024
@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone May 9, 2024
@bsunderhus bsunderhus marked this pull request as ready for review May 9, 2024 12:18
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 9, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented May 9, 2024 •
edited

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 660 647 5000
Button mount 299 309 5000
Field mount 1115 1137 5000
FluentProvider mount 691 728 5000
FluentProviderWithTheme mount 82 81 10
FluentProviderWithTheme virtual-rerender 35 37 10
FluentProviderWithTheme virtual-rerender-with-unmount 80 73 10
MakeStyles mount 862 844 50000
Persona mount 1802 1686 5000
SpinButton mount 1371 1381 5000
SwatchPicker mount 1520 1526 5000

@fabricteam
Copy link
Collaborator

fabricteam commented May 9, 2024 •
edited

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
TreeWith60ListItems.default 96 83 1.16:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PortalMinimalPerf.default 94 82 1.15:1
RefMinimalPerf.default 120 104 1.15:1
ImageMinimalPerf.default 240 211 1.14:1
FormMinimalPerf.default 247 220 1.12:1
ButtonMinimalPerf.default 89 82 1.09:1
BoxMinimalPerf.default 205 190 1.08:1
GridMinimalPerf.default 199 184 1.08:1
ListNestedPerf.default 337 311 1.08:1
TableMinimalPerf.default 257 238 1.08:1
DropdownManyItemsPerf.default 400 375 1.07:1
FlexMinimalPerf.default 158 149 1.06:1
ListWith60ListItems.default 372 352 1.06:1
SegmentMinimalPerf.default 201 190 1.06:1
AlertMinimalPerf.default 159 152 1.05:1
AttachmentSlotsPerf.default 658 625 1.05:1
CarouselMinimalPerf.default 268 255 1.05:1
ChatWithPopoverPerf.default 200 190 1.05:1
CardMinimalPerf.default 322 311 1.04:1
DividerMinimalPerf.default 208 200 1.04:1
ItemLayoutMinimalPerf.default 713 688 1.04:1
RosterPerf.default 1614 1551 1.04:1
ReactionMinimalPerf.default 216 207 1.04:1
AttachmentMinimalPerf.default 79 77 1.03:1
ButtonOverridesMissPerf.default 655 636 1.03:1
TooltipMinimalPerf.default 1287 1245 1.03:1
VideoMinimalPerf.default 445 432 1.03:1
ChatMinimalPerf.default 443 436 1.02:1
CheckboxMinimalPerf.default 1162 1137 1.02:1
DatepickerMinimalPerf.default 3699 3638 1.02:1
EmbedMinimalPerf.default 1879 1844 1.02:1
ListCommonPerf.default 392 383 1.02:1
MenuMinimalPerf.default 515 505 1.02:1
ToolbarMinimalPerf.default 548 535 1.02:1
DialogMinimalPerf.default 444 438 1.01:1
HeaderSlotsPerf.default 455 449 1.01:1
SplitButtonMinimalPerf.default 2277 2265 1.01:1
TableManyItemsPerf.default 1117 1102 1.01:1
TextMinimalPerf.default 198 196 1.01:1
TextAreaMinimalPerf.default 289 285 1.01:1
AnimationMinimalPerf.default 310 309 1:1
DropdownMinimalPerf.default 1437 1441 1:1
ListMinimalPerf.default 296 296 1:1
MenuButtonMinimalPerf.default 946 947 1:1
PopupMinimalPerf.default 348 349 1:1
RadioGroupMinimalPerf.default 260 261 1:1
SkeletonMinimalPerf.default 202 202 1:1
IconMinimalPerf.default 385 385 1:1
TreeMinimalPerf.default 478 480 1:1
AvatarMinimalPerf.default 105 106 0.99:1
ButtonSlotsPerf.default 306 310 0.99:1
InputMinimalPerf.default 535 539 0.99:1
LabelMinimalPerf.default 220 222 0.99:1
ProviderMergeThemesPerf.default 632 638 0.99:1
CustomToolbarPrototype.default 1469 1478 0.99:1
LoaderMinimalPerf.default 187 190 0.98:1
ProviderMinimalPerf.default 200 204 0.98:1
SliderMinimalPerf.default 747 761 0.98:1
StatusMinimalPerf.default 388 397 0.98:1
LayoutMinimalPerf.default 202 208 0.97:1
HeaderMinimalPerf.default 204 214 0.95:1
ChatDuplicateMessagesPerf.default 140 149 0.94:1
AccordionMinimalPerf.default 71 92 0.77:1

@fabricteam
Copy link
Collaborator

fabricteam commented May 9, 2024 •
edited

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library		 1.101 MB
267.303 kB		 1.139 MB
275.309 kB		 37.887 kB
8.006 kB
react-tag-picker
@fluentui/react-tag-picker - package		 0 B
0 B		 188.833 kB
55.784 kB		 🆕 New entry
Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 510 B
328 B
global-context
createContextSelector		 537 B
339 B
keyboard-key
keyboard-key package		 3.746 kB
1.928 kB
priority-overflow
createOverflowManager		 4.447 kB
1.853 kB
react
ActivityItem		 71.019 kB
23.288 kB
react
Announced		 38.291 kB
13.239 kB
react
Autofill		 15.365 kB
4.743 kB
react
Breadcrumb		 201.796 kB
60.267 kB
react
Button		 195.26 kB
56.471 kB
react
ButtonGrid		 180.207 kB
54.515 kB
react
Calendar		 121.542 kB
36.943 kB
react
Callout		 84.108 kB
27.552 kB
react
Check		 52.963 kB
17.773 kB
react
Checkbox		 59.751 kB
19.806 kB
react
ChoiceGroup		 65.276 kB
21.438 kB
react
ChoiceGroupOption		 58.531 kB
19.309 kB
react
Coachmark		 92.937 kB
29.356 kB
react
Color		 7.737 kB
3.106 kB
react
ColorPicker		 132.985 kB
41.502 kB
react
ComboBox		 251.561 kB
72.081 kB
react
CommandBar		 202.829 kB
59.975 kB
react
ContextualMenu		 154.789 kB
48.068 kB
react
DatePicker		 183.939 kB
56.079 kB
react
DateTimeUtilities		 5.244 kB
1.849 kB
react
DetailsList		 229.317 kB
65.63 kB
react
Dialog		 211.12 kB
62.982 kB
react
Divider		 19.399 kB
6.798 kB
react
DocumentCard		 216.805 kB
64.269 kB
react
DragDrop		 8.343 kB
2.724 kB
react
DraggableZone		 34.109 kB
11.448 kB
react
Dropdown		 233.726 kB
68.456 kB
react
ExtendedPicker		 96.565 kB
27.809 kB
react
Fabric		 41.537 kB
14.283 kB
react
Facepile		 210.377 kB
63.035 kB
react
FloatingPicker		 241.851 kB
68.827 kB
react
FocusTrapZone		 16.975 kB
5.917 kB
react
FocusZone		 54.844 kB
17.402 kB
react
Grid		 180.207 kB
54.515 kB
react
GroupedList		 134.634 kB
40.596 kB
react
GroupedListV2		 122.251 kB
37.703 kB
react
HoverCard		 96.969 kB
30.741 kB
react
Icon		 51.644 kB
17.197 kB
react
Icons		 66.305 kB
24.379 kB
react
Image		 46.701 kB
15.646 kB
react
Keytip		 81.482 kB
26.712 kB
react
KeytipData		 13.969 kB
4.57 kB
react
KeytipLayer		 103.278 kB
31.961 kB
react
Keytips		 106.046 kB
32.966 kB
react
Label		 38.134 kB
13.207 kB
react
Layer		 47.887 kB
16.295 kB
react
Link		 39.488 kB
13.614 kB
react
List		 39.176 kB
12.384 kB
react
MarqueeSelection		 74.321 kB
22.385 kB
react
MessageBar		 190.311 kB
56.941 kB
react
Modal		 93.44 kB
30.18 kB
react
Nav		 187.789 kB
56.378 kB
react
OverflowSet		 33.191 kB
11.252 kB
react
Overlay		 40.694 kB
14.023 kB
react
Panel		 200.831 kB
59.888 kB
react
Persona		 114.617 kB
36.442 kB
react
PersonaCoin		 114.617 kB
36.442 kB
react
PersonaPresence		 57.833 kB
19.303 kB
react
Pickers		 293.537 kB
82.173 kB
react
Pivot		 188.703 kB
57.114 kB
react
Popup		 12.242 kB
4.181 kB
react
Positioning		 22.608 kB
7.63 kB
react
PositioningContainer		 73.643 kB
23.706 kB
react
ProgressIndicator		 39.286 kB
13.482 kB
react
Rating		 81.762 kB
26.057 kB
react
Fluent UI React (entire library)		 1.013 MB
281.289 kB
react
ResizeGroup		 13.286 kB
4.365 kB
react
ResponsiveMode		 8.078 kB
2.95 kB
react
ScrollablePane		 55.325 kB
17.669 kB
react
SearchBox		 188.586 kB
56.544 kB
react
SelectableOption		 724 B
413 B
react
SelectedItemsList		 232.346 kB
67.779 kB
react
Selection		 42.252 kB
12.203 kB
react
Separator		 35.183 kB
12.088 kB
react
Shimmer		 49.049 kB
16.206 kB
react
ShimmeredDetailsList		 240.092 kB
68.397 kB
react
Slider		 57.449 kB
19.143 kB
react
SpinButton		 192.314 kB
57.665 kB
react
Spinner		 41.481 kB
14.412 kB
react
Stack		 41.547 kB
14.233 kB
react
Sticky		 32.541 kB
10.49 kB
react
Styling		 45.853 kB
15.082 kB
react
SwatchColorPicker		 190.533 kB
57.999 kB
react
TeachingBubble		 205.586 kB
60.896 kB
react
Text		 36.723 kB
12.763 kB
react
TextField		 80.555 kB
25.262 kB
react
Theme		 43.321 kB
14.129 kB
react
ThemeGenerator		 12.34 kB
4.106 kB
react
TimePicker		 241.365 kB
69.856 kB
react
Toggle		 46.02 kB
15.903 kB
react
Tooltip		 87.136 kB
28.164 kB
react
Utilities		 82.495 kB
25.047 kB
react
Viewport		 23.703 kB
7.589 kB
react
WeeklyDayPicker		 101.682 kB
31.738 kB
react
WindowProvider		 1.059 kB
541 B
react-accordion
Accordion (including children components)		 101.386 kB
30.643 kB
react-alert
Alert		 83.737 kB
23.475 kB
react-avatar
Avatar		 50.175 kB
15.944 kB
react-avatar
AvatarGroup		 19.702 kB
7.794 kB
react-avatar
AvatarGroupItem		 64.829 kB
20.272 kB
react-badge
Badge		 26.905 kB
8.73 kB
react-badge
CounterBadge		 27.806 kB
9.025 kB
react-badge
PresenceBadge		 25.311 kB
9.307 kB
react-breadcrumb
@fluentui/react-breadcrumb - package		 117.263 kB
32.241 kB
react-button
Button		 39.513 kB
11.17 kB
react-button
CompoundButton		 46.874 kB
12.662 kB
react-button
MenuButton		 44.292 kB
12.544 kB
react-button
SplitButton		 52.306 kB
14.135 kB
react-button
ToggleButton		 56.558 kB
13.068 kB
react-calendar-compat
Calendar Compat		 153.874 kB
40.203 kB
react-card
Card - All		 104.438 kB
29.41 kB
react-card
Card		 97.449 kB
27.681 kB
react-card
CardFooter		 13.971 kB
5.626 kB
react-card
CardHeader		 16.214 kB
6.386 kB
react-card
CardPreview		 14.015 kB
5.752 kB
react-checkbox
Checkbox		 36.102 kB
12.131 kB
react-combobox
Combobox (including child components)		 105.614 kB
33.905 kB
react-combobox
Dropdown (including child components)		 107.043 kB
33.877 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 71.55 kB
20.584 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 221.825 kB
62.568 kB
react-components
react-components: FluentProvider & webLightTheme		 44.037 kB
14.418 kB
react-datepicker-compat
DatePicker Compat		 227.989 kB
63.592 kB
react-dialog
Dialog (including children components)		 100.769 kB
30.092 kB
react-divider
Divider		 20.922 kB
7.791 kB
react-field
Field		 22.976 kB
8.722 kB
react-image
Image		 15.745 kB
6.231 kB
react-input
Input		 28.122 kB
9.36 kB
react-jsx-runtime
Classic Pragma		 1.057 kB
530 B
react-jsx-runtime
JSX Dev Runtime		 3.781 kB
1.646 kB
react-jsx-runtime
JSX Runtime		 4.377 kB
1.881 kB
react-label
Label		 14.266 kB
5.829 kB
react-link
Link		 17.082 kB
6.911 kB
react-menu
Menu (including children components)		 154.383 kB
46.161 kB
react-menu
Menu (including selectable components)		 157.069 kB
46.71 kB
react-message-bar
MessageBar (all components)		 24.204 kB
8.983 kB
react-northstar
Accordion		 85.392 kB
26.518 kB
react-northstar
Alert		 87.45 kB
26.902 kB
react-northstar
Animation		 55.34 kB
17.829 kB
react-northstar
Attachment		 86.844 kB
26.692 kB
react-northstar
Avatar		 80.279 kB
24.629 kB
react-northstar
Box		 75.248 kB
23.806 kB
react-northstar
Breadcrumb		 79.92 kB
24.709 kB
react-northstar
Button		 83.16 kB
25.947 kB
react-northstar
Card		 82.705 kB
25.023 kB
react-northstar
Carousel		 105.182 kB
31.871 kB
react-northstar
Chat		 152.378 kB
45.964 kB
react-northstar
Checkbox		 79.807 kB
25.078 kB
react-northstar
Datepicker		 184.939 kB
56.194 kB
react-northstar
Debug		 8.801 kB
3.594 kB
react-northstar
Design		 36.589 kB
12.067 kB
react-northstar
Dialog		 112.058 kB
33.615 kB
react-northstar
Divider		 76.619 kB
24.129 kB
react-northstar
Dropdown		 196.499 kB
59.455 kB
react-northstar
Embed		 81.477 kB
25.417 kB
react-northstar
Flex		 47.728 kB
15.438 kB
react-northstar
Form		 92.527 kB
28.879 kB
react-northstar
Grid		 70.584 kB
22.278 kB
react-northstar
Header		 74.756 kB
23.461 kB
react-northstar
Image		 73.591 kB
23.329 kB
react-northstar
Input		 88.346 kB
27.78 kB
react-northstar
ItemLayout		 78.231 kB
24.454 kB
react-northstar
Label		 77.92 kB
24.41 kB
react-northstar
Layout		 75.393 kB
23.798 kB
react-northstar
List		 88.493 kB
27.547 kB
react-northstar
Loader		 78.616 kB
24.729 kB
react-northstar
Menu		 126.89 kB
39.872 kB
react-northstar
MenuButton		 161.296 kB
48.883 kB
react-northstar
Pill		 83.722 kB
26.069 kB
react-northstar
Popup		 133.604 kB
41.483 kB
react-northstar
Portal		 58.338 kB
18.852 kB
react-northstar
Provider		 93.138 kB
29.63 kB
react-northstar
RadioGroup		 83.282 kB
26.053 kB
react-northstar
Reaction		 77.28 kB
24.122 kB
react-northstar
Segment		 76.209 kB
23.892 kB
react-northstar
Skeleton		 77.765 kB
24.2 kB
react-northstar
Slider		 84.27 kB
26.737 kB
react-northstar
SplitButton		 176.534 kB
52.63 kB
react-northstar
Status		 76.272 kB
24.05 kB
react-northstar
SvgIcon		 36.823 kB
11.743 kB
react-northstar
Table		 80.796 kB
25.154 kB
react-northstar
Text		 74.114 kB
23.507 kB
react-northstar
TextArea		 74.248 kB
23.492 kB
react-northstar
Toolbar		 173.345 kB
52.08 kB
react-northstar
Tooltip		 108.261 kB
34.482 kB
react-northstar
Tree		 87.855 kB
27.217 kB
react-northstar
Video		 75.411 kB
23.799 kB
react-overflow
hooks only		 12.86 kB
4.825 kB
react-persona
Persona		 57.066 kB
17.821 kB
react-popover
Popover		 128.669 kB
40.26 kB
react-portal
Portal		 14.163 kB
4.948 kB
react-portal-compat
PortalCompatProvider		 8.39 kB
2.64 kB
react-positioning
usePositioning		 26.489 kB
9.552 kB
react-progress
ProgressBar		 17.428 kB
6.899 kB
react-provider
FluentProvider		 24.211 kB
8.721 kB
react-radio
Radio		 33.396 kB
10.316 kB
react-radio
RadioGroup		 15.354 kB
6.265 kB
react-select
Select		 28.609 kB
10.204 kB
react-slider
Slider		 40.395 kB
13.024 kB
react-spinbutton
SpinButton		 36.78 kB
11.789 kB
react-spinner
Spinner		 24.729 kB
8.348 kB
react-swatch-picker-preview
@fluentui/react-swatch-picker-preview - package		 108.862 kB
30.32 kB
react-switch
Switch		 36.04 kB
11.305 kB
react-table
DataGrid		 169.274 kB
46.907 kB
react-table
Table (Primitives only)		 45.77 kB
14.174 kB
react-table
Table as DataGrid		 138.358 kB
37.213 kB
react-table
Table (Selection only)		 76.774 kB
20.602 kB
react-table
Table (Sort only)		 75.417 kB
20.205 kB
react-tags
InteractionTag		 15.299 kB
6.08 kB
react-tags
Tag		 29.092 kB
9.418 kB
react-tags
TagGroup		 82.49 kB
24.46 kB
react-text
Text - Default		 16.705 kB
6.57 kB
react-text
Text - Wrappers		 19.878 kB
6.897 kB
react-textarea
Textarea		 30.947 kB
10.477 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 35.666 kB
7.453 kB
react-theme
Teams: Light theme		 19.642 kB
5.549 kB
react-timepicker-compat
TimePicker		 107.632 kB
35.279 kB
react-toast
Toast (including Toaster)		 99.113 kB
29.844 kB
react-tooltip
Tooltip		 55.201 kB
19.285 kB
react-utilities
SSRProvider		 180 B
160 B
🤖 This report was generated against 1eb9ebc1183e1afd59f13896673641ae2b8194d3

@fabricteam
Copy link
Collaborator

fabricteam commented May 9, 2024 •
edited

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented May 9, 2024 •
edited

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 644 621 5000
Breadcrumb mount 1694 1695 1000
Checkbox mount 1702 1735 5000
CheckboxBase mount 1487 1476 5000
ChoiceGroup mount 2951 2959 5000
ComboBox mount 676 685 1000
CommandBar mount 6583 6595 1000
ContextualMenu mount 14277 14639 1000
DefaultButton mount 806 817 5000
DetailsRow mount 2239 2245 5000
DetailsRowFast mount 2256 2256 5000
DetailsRowNoStyles mount 2026 2063 5000
Dialog mount 2771 2720 1000
DocumentCardTitle mount 244 234 1000
Dropdown mount 2001 2006 5000
FocusTrapZone mount 1146 1173 5000
FocusZone mount 1090 1084 5000
GroupedList mount 42317 42415 2
GroupedList virtual-rerender 18240 20512 2
GroupedList virtual-rerender-with-unmount 51019 51564 2
GroupedListV2 mount 231 233 2
GroupedListV2 virtual-rerender 215 207 2
GroupedListV2 virtual-rerender-with-unmount 229 233 2
IconButton mount 1141 1162 5000
Label mount 340 348 5000
Layer mount 2727 2759 5000
Link mount 392 399 5000
MenuButton mount 968 998 5000
MessageBar mount 21464 21548 5000
Nav mount 2069 2052 1000
OverflowSet mount 802 778 5000
Panel mount 1807 1813 1000
Persona mount 735 759 1000
Pivot mount 876 894 1000
PrimaryButton mount 929 915 5000
Rating mount 4631 4678 5000
SearchBox mount 922 904 5000
Shimmer mount 1940 1910 5000
Slider mount 1339 1352 5000
SpinButton mount 3006 2975 5000
Spinner mount 395 396 5000
SplitButton mount 1858 1909 5000
Stack mount 405 407 5000
StackWithIntrinsicChildren mount 849 866 5000
StackWithTextChildren mount 2626 2641 5000
SwatchColorPicker mount 6310 6337 5000
TagPicker mount 1472 1483 5000
Text mount 376 376 5000
TextField mount 953 912 5000
ThemeProvider mount 850 832 5000
ThemeProvider virtual-rerender 582 576 5000
ThemeProvider virtual-rerender-with-unmount 1289 1275 5000
Toggle mount 623 604 5000
buttonNative mount 185 186 5000

@fabricteam
Copy link
Collaborator

fabricteam commented May 9, 2024 •
edited

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus force-pushed the react-tag-picker/chore--release-stable-version branch from 089d770 to 852a2fc Compare May 9, 2024 17:08
@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@bsunderhus bsunderhus merged commit b2b9964 into microsoft:master May 9, 2024
21 checks passed
@bsunderhus bsunderhus deleted the react-tag-picker/chore--release-stable-version branch May 9, 2024 18:58
@bsunderhus bsunderhus mentioned this pull request May 9, 2024
Closed
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hotell Hotell Hotell approved these changes

@YuanboXue-Amber YuanboXue-Amber YuanboXue-Amber approved these changes

@JustSlone JustSlone JustSlone approved these changes

@spmonahan spmonahan spmonahan approved these changes

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar jurokapsiar is a code owner

@tudorpopams tudorpopams Awaiting requested review from tudorpopams tudorpopams is a code owner

Assignees

@bsunderhus bsunderhus

Labels
Area: Components Component: PeoplePicker
Projects
None yet
Milestone
April Project Cycle Q1 2024
Development

Successfully merging this pull request may close these issues.

TagPicker
6 participants
@bsunderhus @fabricteam @Hotell @YuanboXue-Amber @JustSlone @spmonahan