Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extract root storybook shared types so they can be used by web-component domain #31424

Merged
merged 2 commits into from
May 22, 2024
Merged

feat: extract root storybook shared types so they can be used by web-component domain #31424

merged 2 commits into from
May 22, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented May 20, 2024 •
edited
Loading

Previous Behavior

New Behavior

see PR title

Related Issue(s)

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone May 20, 2024
@Hotell Hotell mentioned this pull request May 20, 2024
Closed
6 tasks
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 20, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented May 20, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme mount 87 85 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 611 642 5000
Button mount 311 312 5000
Field mount 1143 1114 5000
FluentProvider mount 731 714 5000
FluentProviderWithTheme mount 87 85 10 Possible regression
FluentProviderWithTheme virtual-rerender 31 26 10
FluentProviderWithTheme virtual-rerender-with-unmount 73 67 10
MakeStyles mount 870 853 50000
Persona mount 1760 1693 5000
SpinButton mount 1368 1368 5000
SwatchPicker mount 1529 1552 5000

@fabricteam
Copy link
Collaborator

fabricteam commented May 20, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 98 80 1.23:1
ButtonMinimalPerf.default 97 86 1.13:1
GridMinimalPerf.default 200 186 1.08:1
ReactionMinimalPerf.default 213 199 1.07:1
TextAreaMinimalPerf.default 299 280 1.07:1
AttachmentMinimalPerf.default 84 79 1.06:1
PortalMinimalPerf.default 88 83 1.06:1
RefMinimalPerf.default 112 106 1.06:1
ChatWithPopoverPerf.default 200 190 1.05:1
MenuMinimalPerf.default 524 502 1.04:1
SliderMinimalPerf.default 774 747 1.04:1
CustomToolbarPrototype.default 1504 1452 1.04:1
AnimationMinimalPerf.default 310 301 1.03:1
AvatarMinimalPerf.default 109 106 1.03:1
LabelMinimalPerf.default 223 217 1.03:1
ListCommonPerf.default 397 384 1.03:1
ProviderMergeThemesPerf.default 657 638 1.03:1
SegmentMinimalPerf.default 203 198 1.03:1
SplitButtonMinimalPerf.default 2316 2259 1.03:1
ButtonSlotsPerf.default 314 309 1.02:1
CardMinimalPerf.default 326 320 1.02:1
CheckboxMinimalPerf.default 1140 1122 1.02:1
DropdownManyItemsPerf.default 386 380 1.02:1
EmbedMinimalPerf.default 1903 1864 1.02:1
ListMinimalPerf.default 311 305 1.02:1
ListWith60ListItems.default 352 346 1.02:1
PopupMinimalPerf.default 354 348 1.02:1
TreeMinimalPerf.default 492 484 1.02:1
DatepickerMinimalPerf.default 3587 3562 1.01:1
DividerMinimalPerf.default 197 195 1.01:1
DropdownMinimalPerf.default 1461 1452 1.01:1
LoaderMinimalPerf.default 198 196 1.01:1
MenuButtonMinimalPerf.default 948 942 1.01:1
TableManyItemsPerf.default 1111 1100 1.01:1
ChatMinimalPerf.default 441 441 1:1
DialogMinimalPerf.default 439 438 1:1
FormMinimalPerf.default 224 223 1:1
HeaderMinimalPerf.default 205 205 1:1
RosterPerf.default 1592 1590 1:1
ProviderMinimalPerf.default 201 201 1:1
IconMinimalPerf.default 382 382 1:1
ButtonOverridesMissPerf.default 632 636 0.99:1
FlexMinimalPerf.default 155 156 0.99:1
HeaderSlotsPerf.default 458 464 0.99:1
InputMinimalPerf.default 545 550 0.99:1
ListNestedPerf.default 319 323 0.99:1
RadioGroupMinimalPerf.default 252 255 0.99:1
ItemLayoutMinimalPerf.default 709 726 0.98:1
AttachmentSlotsPerf.default 647 665 0.97:1
ImageMinimalPerf.default 228 236 0.97:1
StatusMinimalPerf.default 397 409 0.97:1
TextMinimalPerf.default 194 199 0.97:1
TooltipMinimalPerf.default 1257 1292 0.97:1
AlertMinimalPerf.default 156 163 0.96:1
LayoutMinimalPerf.default 192 201 0.96:1
VideoMinimalPerf.default 435 454 0.96:1
AccordionMinimalPerf.default 83 87 0.95:1
TableMinimalPerf.default 225 237 0.95:1
ToolbarMinimalPerf.default 519 547 0.95:1
SkeletonMinimalPerf.default 194 207 0.94:1
CarouselMinimalPerf.default 255 280 0.91:1
ChatDuplicateMessagesPerf.default 151 166 0.91:1
BoxMinimalPerf.default 200 224 0.89:1

@fabricteam
Copy link
Collaborator

fabricteam commented May 20, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented May 20, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented May 20, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 625 626 5000
Breadcrumb mount 1686 1701 1000
Checkbox mount 1750 1658 5000
CheckboxBase mount 1465 1494 5000
ChoiceGroup mount 2977 2982 5000
ComboBox mount 669 668 1000
CommandBar mount 6488 6439 1000
ContextualMenu mount 12607 13361 1000
DefaultButton mount 773 777 5000
DetailsRow mount 2206 2201 5000
DetailsRowFast mount 2182 2205 5000
DetailsRowNoStyles mount 2022 2025 5000
Dialog mount 2957 2567 1000
DocumentCardTitle mount 228 230 1000
Dropdown mount 1996 2006 5000
FocusTrapZone mount 1142 1164 5000
FocusZone mount 1052 1095 5000
GroupedList mount 42110 42448 2
GroupedList virtual-rerender 20392 20342 2
GroupedList virtual-rerender-with-unmount 50598 50509 2
GroupedListV2 mount 247 232 2
GroupedListV2 virtual-rerender 214 213 2
GroupedListV2 virtual-rerender-with-unmount 213 231 2
IconButton mount 1147 1105 5000
Label mount 342 344 5000
Layer mount 2723 2767 5000
Link mount 386 397 5000
MenuButton mount 974 966 5000
MessageBar mount 21168 21186 5000
Nav mount 2018 1977 1000
OverflowSet mount 781 796 5000
Panel mount 1836 1774 1000
Persona mount 739 740 1000
Pivot mount 897 896 1000
PrimaryButton mount 934 935 5000
Rating mount 4639 4713 5000
SearchBox mount 923 908 5000
Shimmer mount 1861 1902 5000
Slider mount 1349 1321 5000
SpinButton mount 2919 2961 5000
Spinner mount 387 378 5000
SplitButton mount 1850 1860 5000
Stack mount 417 405 5000
StackWithIntrinsicChildren mount 845 849 5000
StackWithTextChildren mount 2645 2680 5000
SwatchColorPicker mount 6424 6367 5000
TagPicker mount 1417 1453 5000
Text mount 372 374 5000
TextField mount 969 940 5000
ThemeProvider mount 837 839 5000
ThemeProvider virtual-rerender 575 584 5000
ThemeProvider virtual-rerender-with-unmount 1250 1283 5000
Toggle mount 597 599 5000
buttonNative mount 190 181 5000

@Hotell Hotell marked this pull request as ready for review May 20, 2024 15:50
@Hotell Hotell requested review from a team as code owners May 20, 2024 15:50
@tudorpopams tudorpopams self-requested a review May 21, 2024 12:05
@Hotell Hotell force-pushed the wc-3-followup/shared-sb-types branch from 810f183 to 2f38556 Compare May 22, 2024 09:23
@Hotell Hotell enabled auto-merge (squash) May 22, 2024 09:25
@Hotell Hotell disabled auto-merge May 22, 2024 10:00
@Hotell Hotell force-pushed the wc-3-followup/shared-sb-types branch from e2492bd to a3262a2 Compare May 22, 2024 12:19
@Hotell Hotell enabled auto-merge (squash) May 22, 2024 12:19
@Hotell Hotell merged commit e6fbfed into microsoft:master May 22, 2024
22 checks passed
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request Jun 14, 2024
@Hotell @miroslavstastny
feat: extract root storybook shared types so they can be used by web-…
6f4da30 
…component domain (microsoft#31424)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@chrisdholt chrisdholt chrisdholt approved these changes

@layershifter layershifter layershifter approved these changes

@tudorpopams tudorpopams tudorpopams approved these changes

Assignees
No one assigned
Labels
Area: Build System Storybook web-components
Projects
None yet
Milestone
April Project Cycle Q1 2024
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Hotell @fabricteam @chrisdholt @layershifter @tudorpopams