-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: tweak release commit message in order to easily determine what release did happen from git history #31695
Merged
Hotell
merged 2 commits into
microsoft:master
from
Hotell:ci/release/git-commit-message-tweaks
Jun 18, 2024
Merged
ci: tweak release commit message in order to easily determine what release did happen from git history #31695
Hotell
merged 2 commits into
microsoft:master
from
Hotell:ci/release/git-commit-message-tweaks
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lease did happen from git history
Hotell
added
Fluent UI react-components (v9)
Fluent UI react (v8)
Issues about @fluentui/react (v8)
web-components
CI
labels
Jun 13, 2024
fabricteam
reviewed
Jun 13, 2024
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 629 | 622 | 5000 | |
Button | mount | 296 | 296 | 5000 | |
Field | mount | 1153 | 1122 | 5000 | |
FluentProvider | mount | 693 | 710 | 5000 | |
FluentProviderWithTheme | mount | 91 | 82 | 10 | |
FluentProviderWithTheme | virtual-rerender | 31 | 40 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 80 | 80 | 10 | |
MakeStyles | mount | 857 | 833 | 50000 | |
Persona | mount | 1777 | 1742 | 5000 | |
SpinButton | mount | 1363 | 1435 | 5000 | |
SwatchPicker | mount | 1656 | 1672 | 5000 |
Perf Analysis (
|
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
ButtonMinimalPerf.default | 99 | 80 | 1.24:1 |
LayoutMinimalPerf.default | 213 | 187 | 1.14:1 |
FlexMinimalPerf.default | 170 | 151 | 1.13:1 |
CarouselMinimalPerf.default | 267 | 246 | 1.09:1 |
ChatWithPopoverPerf.default | 207 | 190 | 1.09:1 |
ImageMinimalPerf.default | 234 | 215 | 1.09:1 |
ReactionMinimalPerf.default | 219 | 202 | 1.08:1 |
BoxMinimalPerf.default | 203 | 191 | 1.06:1 |
CardMinimalPerf.default | 313 | 296 | 1.06:1 |
InputMinimalPerf.default | 568 | 536 | 1.06:1 |
TextMinimalPerf.default | 201 | 189 | 1.06:1 |
AttachmentSlotsPerf.default | 648 | 620 | 1.05:1 |
RefMinimalPerf.default | 112 | 107 | 1.05:1 |
SegmentMinimalPerf.default | 212 | 201 | 1.05:1 |
StatusMinimalPerf.default | 413 | 394 | 1.05:1 |
AvatarMinimalPerf.default | 117 | 113 | 1.04:1 |
ButtonOverridesMissPerf.default | 660 | 637 | 1.04:1 |
ChatMinimalPerf.default | 447 | 431 | 1.04:1 |
DividerMinimalPerf.default | 205 | 197 | 1.04:1 |
DropdownMinimalPerf.default | 1456 | 1397 | 1.04:1 |
FormMinimalPerf.default | 231 | 222 | 1.04:1 |
ProviderMinimalPerf.default | 212 | 203 | 1.04:1 |
RadioGroupMinimalPerf.default | 266 | 257 | 1.04:1 |
IconMinimalPerf.default | 393 | 379 | 1.04:1 |
TableManyItemsPerf.default | 1143 | 1095 | 1.04:1 |
ListMinimalPerf.default | 318 | 310 | 1.03:1 |
MenuMinimalPerf.default | 510 | 494 | 1.03:1 |
VideoMinimalPerf.default | 433 | 419 | 1.03:1 |
DatepickerMinimalPerf.default | 3556 | 3495 | 1.02:1 |
LabelMinimalPerf.default | 222 | 217 | 1.02:1 |
LoaderMinimalPerf.default | 180 | 176 | 1.02:1 |
PortalMinimalPerf.default | 86 | 84 | 1.02:1 |
SliderMinimalPerf.default | 756 | 740 | 1.02:1 |
TextAreaMinimalPerf.default | 299 | 293 | 1.02:1 |
AttachmentMinimalPerf.default | 81 | 80 | 1.01:1 |
ChatDuplicateMessagesPerf.default | 146 | 144 | 1.01:1 |
DialogMinimalPerf.default | 440 | 435 | 1.01:1 |
EmbedMinimalPerf.default | 1872 | 1859 | 1.01:1 |
HeaderMinimalPerf.default | 204 | 202 | 1.01:1 |
HeaderSlotsPerf.default | 459 | 454 | 1.01:1 |
ListNestedPerf.default | 327 | 325 | 1.01:1 |
TooltipMinimalPerf.default | 1292 | 1283 | 1.01:1 |
TreeWith60ListItems.default | 82 | 81 | 1.01:1 |
AnimationMinimalPerf.default | 296 | 297 | 1:1 |
CheckboxMinimalPerf.default | 1154 | 1149 | 1:1 |
ListCommonPerf.default | 395 | 394 | 1:1 |
MenuButtonMinimalPerf.default | 959 | 958 | 1:1 |
ProviderMergeThemesPerf.default | 656 | 653 | 1:1 |
SkeletonMinimalPerf.default | 199 | 200 | 1:1 |
SplitButtonMinimalPerf.default | 2244 | 2252 | 1:1 |
CustomToolbarPrototype.default | 1460 | 1461 | 1:1 |
ToolbarMinimalPerf.default | 540 | 540 | 1:1 |
TreeMinimalPerf.default | 486 | 484 | 1:1 |
DropdownManyItemsPerf.default | 394 | 397 | 0.99:1 |
ItemLayoutMinimalPerf.default | 700 | 710 | 0.99:1 |
ListWith60ListItems.default | 363 | 366 | 0.99:1 |
PopupMinimalPerf.default | 351 | 353 | 0.99:1 |
RosterPerf.default | 1590 | 1626 | 0.98:1 |
TableMinimalPerf.default | 233 | 238 | 0.98:1 |
GridMinimalPerf.default | 188 | 194 | 0.97:1 |
AlertMinimalPerf.default | 157 | 163 | 0.96:1 |
ButtonSlotsPerf.default | 303 | 317 | 0.96:1 |
AccordionMinimalPerf.default | 79 | 84 | 0.94:1 |
🕵 fluentuiv8 No visual regressions between this PR and main |
🕵 FluentUIV0 No visual regressions between this PR and main |
📊 Bundle size report✅ No changes found |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 617 | 628 | 5000 | |
Breadcrumb | mount | 1680 | 1696 | 1000 | |
Checkbox | mount | 1709 | 1688 | 5000 | |
CheckboxBase | mount | 1484 | 1492 | 5000 | |
ChoiceGroup | mount | 2920 | 2996 | 5000 | |
ComboBox | mount | 690 | 696 | 1000 | |
CommandBar | mount | 6506 | 6424 | 1000 | |
ContextualMenu | mount | 11763 | 11772 | 1000 | |
DefaultButton | mount | 788 | 788 | 5000 | |
DetailsRow | mount | 2231 | 2196 | 5000 | |
DetailsRowFast | mount | 2220 | 2199 | 5000 | |
DetailsRowNoStyles | mount | 2061 | 2012 | 5000 | |
Dialog | mount | 2709 | 2803 | 1000 | |
DocumentCardTitle | mount | 229 | 235 | 1000 | |
Dropdown | mount | 1971 | 2022 | 5000 | |
FocusTrapZone | mount | 1158 | 1177 | 5000 | |
FocusZone | mount | 1090 | 1082 | 5000 | |
GroupedList | mount | 37338 | 42001 | 2 | |
GroupedList | virtual-rerender | 18018 | 20104 | 2 | |
GroupedList | virtual-rerender-with-unmount | 50720 | 51049 | 2 | |
GroupedListV2 | mount | 236 | 222 | 2 | |
GroupedListV2 | virtual-rerender | 208 | 211 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 221 | 230 | 2 | |
IconButton | mount | 1119 | 1128 | 5000 | |
Label | mount | 335 | 341 | 5000 | |
Layer | mount | 2734 | 2733 | 5000 | |
Link | mount | 390 | 396 | 5000 | |
MenuButton | mount | 1021 | 977 | 5000 | |
MessageBar | mount | 21612 | 21676 | 5000 | |
Nav | mount | 2083 | 2025 | 1000 | |
OverflowSet | mount | 803 | 778 | 5000 | |
Panel | mount | 1827 | 1804 | 1000 | |
Persona | mount | 752 | 779 | 1000 | |
Pivot | mount | 899 | 906 | 1000 | |
PrimaryButton | mount | 936 | 940 | 5000 | |
Rating | mount | 4817 | 4728 | 5000 | |
SearchBox | mount | 921 | 947 | 5000 | |
Shimmer | mount | 1892 | 1926 | 5000 | |
Slider | mount | 1317 | 1300 | 5000 | |
SpinButton | mount | 2952 | 3045 | 5000 | |
Spinner | mount | 393 | 400 | 5000 | |
SplitButton | mount | 1917 | 1890 | 5000 | |
Stack | mount | 418 | 420 | 5000 | |
StackWithIntrinsicChildren | mount | 848 | 853 | 5000 | |
StackWithTextChildren | mount | 2722 | 2736 | 5000 | |
SwatchColorPicker | mount | 6423 | 6299 | 5000 | |
TagPicker | mount | 1494 | 1444 | 5000 | |
Text | mount | 387 | 377 | 5000 | |
TextField | mount | 965 | 938 | 5000 | |
ThemeProvider | mount | 850 | 850 | 5000 | |
ThemeProvider | virtual-rerender | 588 | 591 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1275 | 1283 | 5000 | |
Toggle | mount | 617 | 618 | 5000 | |
buttonNative | mount | 197 | 192 | 5000 |
fabricteam
reviewed
Jun 13, 2024
marcosmoura
reviewed
Jun 13, 2024
…what release did happen from git history
marcosmoura
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI
Fluent UI react (v8)
Issues about @fluentui/react (v8)
Fluent UI react-components (v9)
web-components
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
when release is triggered it creates commit with generic message
applying package updates
, which is not obvious for what library/framework did the release happen.New Behavior
when release is triggered it creates commit with proper context about library/framework:
release: applying package updates - <framework-name>
Related Issue(s)