feat(web-components): Use ElementInternals for Radio and RadioGroup components #31783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Jun 20, 2024
change/@fluentui-web-components-43e80800-54d6-4c42-85f9-c04e6746bd00.json
Outdated
Show resolved
Hide resolved
radium-v
force-pushed
the
users/radium-v/wc3-radio
branch
2 times, most recently
from
da4b780
to
492772d
Compare
|
Support for radio groups in a toolbar will need to come at a later time when a toolbar component is added via #26717 |
marchbox
reviewed
Jun 21, 2024
radium-v
force-pushed
the
users/radium-v/wc3-radio
branch
2 times, most recently
from
dcc4b33
to
f142afa
Compare
eljefe223
reviewed
Jun 25, 2024
eljefe223
reviewed
Jun 25, 2024
janechu
reviewed
Jun 26, 2024
radium-v
force-pushed
the
users/radium-v/wc3-radio
branch
3 times, most recently
from
5948663
to
e004311
Compare
janechu
approved these changes
Jul 1, 2024
marchbox
reviewed
Jul 1, 2024
radium-v
force-pushed
the
users/radium-v/wc3-radio
branch
from
e004311
to
f7731a0
Compare
marchbox
approved these changes
Jul 2, 2024
radium-v
force-pushed
the
users/radium-v/wc3-radio
branch
from
f7731a0
to
5024cc9
Compare
davatron5000
approved these changes
Jul 2, 2024
radium-v
force-pushed
the
users/radium-v/wc3-radio
branch
from
5024cc9
to
6d0bb90
Compare
eljefe223
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Currently, form-associated custom elements use the
FormAssociatedclass mixin. This mixin is heavy and duplicative, being copied wholesale for every component which utilizes it. WhileFormAssociatedincludes minimal support forElementInternals, the implementation isn't fully baked.New Behavior
<fluent-radio>and<fluent-radio-group>to useElementInternals<fluent-field>,<fluent-checkbox>, and<fluent-switch>Related Issue(s)
ElementInternals#31400