[ContextualMenu] Made disabled buttons focusable #4074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschect
reviewed
Feb 23, 2018
| const items: IContextualMenuItem[] = [ | ||
| { | ||
| name: 'TestText 1', | ||
| key: 'TestKey1', | ||
| isDisabled: true, |
There was a problem hiding this comment.
Still validate isDisabled, it needs to be removed in 6.0 once it's deprecated.
joschect
approved these changes
Feb 23, 2018
…into magellan/focusableDisabledItems
manishgarg1
reviewed
Feb 23, 2018
| @@ -531,6 +531,10 @@ export class ContextualMenu extends BaseComponent<IContextualMenuProps, IContext | |||
| const defaultRole = canCheck ? 'menuitemcheckbox' : 'menuitem'; | |||
| const itemHasSubmenu = hasSubmenu(item); | |||
|
|
|||
| const buttonNativeProperties = getNativeProps(item, buttonProperties); | |||
| // Do not add the deleted attribute to the button so that it is focusable | |||
There was a problem hiding this comment.
Typo. Not deleted but disabled
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Feb 27, 2018
* master: (28 commits) Scrollable pane sort stickies (microsoft#4111) Allow ScrollablePane to accept native properties. (microsoft#4095) Sticky (microsoft#4091) Applying package updates. [ColorRectangle, Sticky] Fixed null root refs (microsoft#4099) DatePicker: order of callbacks for onSelectDate and onAfterMenuDismiss (microsoft#4092) Applying package updates. Alhenry fix split button props (microsoft#4090) Fixing ComboBox styling by reverting button classname move (microsoft#4088) Update CODEOWNERS Undoing terrible change. [DetailsList] Fixed focus test (microsoft#4087) Added icons package screener test (microsoft#4082) ContextualMenu: Fix ContextualMenuUtility imports (microsoft#4085) [ContextualMenu] Made disabled buttons focusable (microsoft#4074) Convert Check to mergeStyles (microsoft#3880) [DetailsList] Add public focusIndex function (microsoft#3852) ComboBox button should have data-is-focusable="false" (microsoft#4070) Applying package updates. Focus Zone: Allow Tab to Skip Selection (microsoft#4061) ...
chrismohr
pushed a commit
to chrismohr/office-ui-fabric-react
that referenced
this pull request
Apr 17, 2018
* Made disabled buttons focusable * Change file * Fixed test logic * Added test failure * Added isDisabled tests * Fixed tslint in test * Updated DetailsList snapshot * Fix typo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Removed the
disabledattribute from ContextualMenu buttons.Focus areas to test
Ensured that disabled buttons do no execute when clicked or when spacebar/enter is pressed while the button is focused. The button is not focusable via mouse but is focusable via keyboard navigation.