Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse commit for PR #4897 #5085

Merged
merged 2 commits into from Jun 4, 2018

Conversation

jspurlin
Copy link
Collaborator

@jspurlin jspurlin commented Jun 4, 2018

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ npm run change
  • Microsoft Alias (if you have one): jspurlin

Description of changes

This PR reverts PR #4897 which regressed focus callbacks in the FocusTrapZone

Focus areas to test

Verified reverting that PR fixed the regression

Microsoft Reviewers: Open in CodeFlow

@jspurlin
Copy link
Collaborator Author

jspurlin commented Jun 4, 2018

@bworline and @kelseyyoung as an fyi

@jspurlin jspurlin requested review from chang47 and ddlbrena June 4, 2018 18:24
@jspurlin jspurlin merged commit 471bf4a into microsoft:master Jun 4, 2018
Markionium added a commit to Markionium/office-ui-fabric-react that referenced this pull request Jun 4, 2018
* master:
  CommandBarPage: Remove FabricJS reference (microsoft#5087)
  Applying package updates.
  Reverse commit for PR microsoft#4897 (microsoft#5085)
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants