This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Associate label with input. Include name in input. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ecraig12345
suggested changes
Mar 6, 2019
step1-03/demo/README.md
Outdated
| @@ -6,7 +6,7 @@ In this demo we are going to cover a few core basics of the language that will h | |||
|
|
|||
| ```html | |||
| <div id="contact-form"> | |||
| <label>Email</label><input id="email" type="email" /> | |||
| <label for="email">Email</label><input id="email" type="email" name="email"/> | |||
There was a problem hiding this comment.
Since this form won't be submitted via POST, the name property shouldn't be necessary as far as I'm aware. If you've seen guidance to the contrary, would you mind sharing a link?
There was a problem hiding this comment.
Yes, you are right. The name attribute is for server-side processing.
step1-03/demo/index.html
Outdated
| > | ||
| <pre data-lang="css"> | ||
|
|
||
| <body> |
There was a problem hiding this comment.
Would you please revert all the changes to this file aside from adding the for attribute to the label?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gave the label element a for attribute to link it to its corresponding input element. Also added name attribute to input. Those are best practices.