Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encodeToBase64 and decodeBase64 are not symmetric #2

Closed
danyoel opened this issue Aug 1, 2016 · 1 comment
Closed

encodeToBase64 and decodeBase64 are not symmetric #2

danyoel opened this issue Aug 1, 2016 · 1 comment

Comments

@danyoel
Copy link

danyoel commented Aug 1, 2016

in FSharpLu\Text.cs, encodeToBase64 uses ASCIIEncoding while decodeBase64 uses UTF8Encoding. Recommend using UTF-8 for both.
blumu added a commit that referenced this issue Aug 12, 2016
@blumu
Fix bug #2 and add corresponding test case
52b95c6
@blumu blumu mentioned this issue Aug 12, 2016
Merged
blumu added a commit that referenced this issue Nov 4, 2016
@blumu
encodeToBase64 and decodeBase64 are not symmetric #2
7ba01bf
@blumu
Copy link
Contributor

blumu commented Jan 14, 2017

Closing, fix reached master branch.

@blumu blumu closed this as completed Jan 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blumu @danyoel