Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#148 Implement TES Task Runner] Execute Task commands via the Runner #151

Closed
Tracked by #148
giventocode opened this issue Mar 22, 2023 · 1 comment · Fixed by #404
Closed
Tracked by #148

[#148 Implement TES Task Runner] Execute Task commands via the Runner #151

giventocode opened this issue Mar 22, 2023 · 1 comment · Fixed by #404
Milestone

Comments

@giventocode
Copy link
Contributor

giventocode commented Mar 22, 2023

Overview
The TES Task runner has the capability to create a docker container and execute the command on the container using the Docker API. The goal of this story is to integrate this capability with the TES scheduler and add required functionality if needed.'

AC:

  • Must avoid using the docker container instance and instead using the docker API.
  • Must handle the ability to download a container image, for both public container registries and CRs requiring authentication.
  • Must delete the container after its execution.
  • Must refactor the existing code base execute the task commands via the runner.
  • Must return logs from the execution.
  • Must add options using the IOptions pattern in the scheduler if required.

DoD:

  • Code merged into main, with unit tests for the new functionality, integration tests pass.
  • Documented new options if required.
@giventocode giventocode added the linked issue Related issues label Mar 22, 2023
@BMurri BMurri changed the title Execute Taks commands via the Runner Execute Task commands via the Runner Mar 24, 2023
@giventocode giventocode added this to the 4.4.0 milestone May 9, 2023
@ngambani ngambani added contextualized and removed linked issue Related issues labels Jul 7, 2023
@BMurri
Copy link
Collaborator

BMurri commented Aug 28, 2023

Non-public container registry authentication is now required.

@ngambani ngambani changed the title Execute Task commands via the Runner [#148 Implement TES Task Runner] Execute Task commands via the Runner Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants