Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#148 Implement TES Task Runner] Make file names consistent for the runner binary, its task definition file and server TES task. #439

Closed
Tracked by #148
giventocode opened this issue Oct 2, 2023 · 1 comment · Fixed by #453

Comments

@giventocode
Copy link
Contributor

giventocode commented Oct 2, 2023

Problem:
The runner’s binary file name is tRunner, while the node task definition file name is TesTask.json. These file names follow inconsistent naming conventions. Also, TesTask is an inaccurate name because it suggests that it is the task sent to the TES server. The TES server also uploads a serialized version of the TesTask model using the file name ServerTesTask.json.

Solution:
Rename files following Linux style naming convention and using descripted names.

AC:

  • Runner's binary file name: tes-runner,
  • Node task definition file name: runner-task.json
  • Server TES task model: server-tes-task.json
@giventocode giventocode changed the title Make file names consistent for the runner binary and the runner task definition file. Make file names consistent for the runner binary and task definition file. Oct 2, 2023
@giventocode giventocode changed the title Make file names consistent for the runner binary and task definition file. Make file names consistent for the runner binary and its task definition file. Oct 2, 2023
@giventocode giventocode changed the title Make file names consistent for the runner binary and its task definition file. Make file names consistent for the runner binary, its task definition file and server TES task. Oct 2, 2023
@ngambani
Copy link

ngambani commented Oct 3, 2023

@giventocode can we link this issue to the TES runner #148? Or should this be separate from the runner implementation?

@ngambani ngambani changed the title Make file names consistent for the runner binary, its task definition file and server TES task. [#148 Implement TES Task Runner] Make file names consistent for the runner binary, its task definition file and server TES task. Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants