Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[439] File renaming refactoring #453

Merged
merged 4 commits into from
Oct 12, 2023
Merged

[439] File renaming refactoring #453

merged 4 commits into from
Oct 12, 2023

Conversation

giventocode
Copy link
Contributor

Closes: #439

In this PR:

  • Renames files as follows:
    • Runner binary: tes-runner
    • Node task definition: runner-task.json
    • Server TES task: server-tes-task.json

@giventocode giventocode requested a review from a team October 9, 2023 13:07
BMurri
BMurri requested changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@BMurri BMurri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a project src\PublishTesRunnerToTesApiArtifacts\PublishTesRunnerToTesApiArtifacts.csproj that is not in the sln file where you also need to rename the binary.

@giventocode
Copy link
Contributor Author

There is a project src\PublishTesRunnerToTesApiArtifacts\PublishTesRunnerToTesApiArtifacts.csproj that is not in the sln file where you also need to rename the binary.

The changes in that file are already included in the PR: 0a59e86

BMurri
BMurri approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@BMurri BMurri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason I could not see that file in the files changed list. LGTM

@giventocode giventocode merged commit 928fc95 into main Oct 12, 2023
8 checks passed
@giventocode giventocode deleted the ja-439 branch October 12, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BMurri BMurri BMurri approved these changes

@MattMcL4475 MattMcL4475 MattMcL4475 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@giventocode @BMurri @MattMcL4475