New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use generic host for GarnetServer #579

Open

Meir017 opened this issue Aug 9, 2024 · 1 comment

Labels

Contributor

Meir017 commented Aug 9, 2024 •

edited

Loading

Feature request type

enhancement

Is your feature request related to a problem? Please describe

Using the generic host https://learn.microsoft.com/en-us/aspnet/core/fundamentals/host/generic-host will simplify how we bootstrap the server

Describe the solution you'd like

wire up using DI the dependencies that are created manually.

Describe alternatives you've considered

No response

Additional context

see the manual configuration https://github.com/microsoft/garnet/blob/main/libs/host/GarnetServer.cs#L151C13-L210C57

badrishc added the help wanted label

Contributor Author

Meir017 commented Aug 12, 2024

#394 starts doing this,

I think we can take that PR without the windows service code as I think it's still in discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment